GNU bug report logs - #75885
[PATCH] gnu: rofi-pass-wayland

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Leo Famulari <leo <at> famulari.name>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#75885: closed ([PATCH] gnu: rofi-pass-wayland)
Date: Sun, 02 Feb 2025 21:56:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 2 Feb 2025 16:55:05 -0500
with message-id <Z5_puS1qKCklbCzV <at> jasmine.lan>
and subject line Re: [bug#75885] QA review for 75885
has caused the debbugs.gnu.org bug report #75885,
regarding [PATCH] gnu: rofi-pass-wayland
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
75885: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=75885
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jake Koroman <jakekoroman <at> proton.me>
To: guix-patches <at> gnu.org
Cc: Jake Koroman <jakekoroman <at> proton.me>
Subject: [PATCH] gnu: rofi-pass-wayland
Date: Mon, 27 Jan 2025 03:05:16 +0000

* gnu/packages/password-utils.scm (rofi-pass-wayland): Removed doubled /etc substitute.

The substitute is wrong here as it is already being inherited from the rofi-pass package.
This causes the substitute to run twice and cause an error in the outputted config file.

Change-Id: I61d7ed4f9f84903aef2a21a3bc5ca3e65a092577
---
 gnu/packages/password-utils.scm | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.scm
index 0a3711b..81758ce 100644
--- a/gnu/packages/password-utils.scm
+++ b/gnu/packages/password-utils.scm
@@ -1073,10 +1073,7 @@ (define-public rofi-pass-wayland
                        (("#clibpoard_backend=xclip")
                         "clipboard_backend=wl-clipboard")
                        (("#backend=xdotool")
-                        "backend=wtype"))
-                     (substitute* "rofi-pass"
-                       (("/etc")
-                        (string-append #$output "/etc")))))
+                        "backend=wtype"))))
             ;; Use Wayland related tools instead.
             (replace 'wrap-path
               (lambda* (#:key inputs #:allow-other-keys)

base-commit: 5133fe25d4c105ce4bdc7134bc585a1f673d8a8b
-- 
2.47.1

[Message part 3 (message/rfc822, inline)]

From: Leo Famulari <leo <at> famulari.name>
To: Nicolas Graves <ngraves <at> ngraves.fr>, Jake Koroman <jakekoroman <at> proton.me>
Cc: 75885-done <at> debbugs.gnu.org
Subject: Re: [bug#75885] QA review for 75885
Date: Sun, 2 Feb 2025 16:55:05 -0500

On Sun, Feb 02, 2025 at 03:45:06PM +0100, Nicolas Graves via Guix-patches via wrote:
> user guix
> usertag 75885 + reviewed-looks-good
> thanks
> 
> Guix QA review form submission:
> The commit message could be more precise, but is acceptable IMO. I can confirm the fix claimed indeed happens.
> 
> Items marked as checked: Lint warnings, Package builds, Commit messages

Thanks Jake, for identifying the bug and sending a patch to fix it!

I pushed your patch as commit ad59a0c88bac673e1267d928fdfe2e83858d2839
after rewriting the commit message to follow our format and be a little
more informative (in my opinion):

https://git.savannah.gnu.org/cgit/guix.git/commit/?id=ad59a0c88bac673e1267d928fdfe2e83858d2839

Nicolas, thanks for the review!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.