From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 27 00:22:18 2025 Received: (at submit) by debbugs.gnu.org; 27 Jan 2025 05:22:18 +0000 Received: from localhost ([127.0.0.1]:58899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tcHZh-0000ib-Db for submit@debbugs.gnu.org; Mon, 27 Jan 2025 00:22:18 -0500 Received: from lists.gnu.org ([2001:470:142::17]:48286) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tcFRP-0002ZT-S4 for submit@debbugs.gnu.org; Sun, 26 Jan 2025 22:05:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tcFRI-0000SW-9f for guix-patches@gnu.org; Sun, 26 Jan 2025 22:05:29 -0500 Received: from mail-40131.protonmail.ch ([185.70.40.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tcFRF-0004Qr-GA for guix-patches@gnu.org; Sun, 26 Jan 2025 22:05:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1737947121; x=1738206321; bh=tK8DfMWG6wUU089whtUcRh8We9RRuSHsQasfa0DQ8o0=; h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector: List-Unsubscribe:List-Unsubscribe-Post; b=F5cU1DtiEODdjCSN/gIkeYhcAUxsNWOupMgLi4QXkIns30ZXkat0bT+5ZQ3IUBsQB A6bhHY5fXEv8KlJuXTXSNGtPNJw3v4i/e+DU7HbGrfLLdhXUK+LbQyyrW5kvZGT6I7 5nHbxP7eGwVPsdoA8shPM5sWm/+TP0kncSRniHVIj3L3T6WDG419fsKN8oBf+XOtYx 2GeKpKC1kN3aQV9feQYo7o8hScP98+WUOAUzOmhtMA3VGKQux962eyHZIaVIaT29cV UgzRWBif3qVfx7pH75lPPVMFxbtzksMoUcyd0vJbDcV5wZILZkKEzMhFURn8XNXxf4 +iMUq/DiXqc6Q== Date: Mon, 27 Jan 2025 03:05:16 +0000 To: guix-patches@gnu.org From: Jake Koroman Subject: [PATCH] gnu: rofi-pass-wayland Message-ID: <540352f17234386be527c9cc4ae0530f97fb7529.1737946971.git.jakekoroman@proton.me> Feedback-ID: 120522492:user:proton X-Pm-Message-ID: 0c63bdf6f1624fdfda37ab42c08dab024ae3bac7 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.40.131; envelope-from=jakekoroman@proton.me; helo=mail-40131.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.01, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 27 Jan 2025 00:22:10 -0500 Cc: Jake Koroman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * gnu/packages/password-utils.scm (rofi-pass-wayland): Removed doubled /etc= substitute. The substitute is wrong here as it is already being inherited from the rofi= -pass package. This causes the substitute to run twice and cause an error in the outputted= config file. Change-Id: I61d7ed4f9f84903aef2a21a3bc5ca3e65a092577 --- gnu/packages/password-utils.scm | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.= scm index 0a3711b..81758ce 100644 --- a/gnu/packages/password-utils.scm +++ b/gnu/packages/password-utils.scm @@ -1073,10 +1073,7 @@ (define-public rofi-pass-wayland (("#clibpoard_backend=3Dxclip") "clipboard_backend=3Dwl-clipboard") (("#backend=3Dxdotool") - "backend=3Dwtype")) - (substitute* "rofi-pass" - (("/etc") - (string-append #$output "/etc"))))) + "backend=3Dwtype")))) ;; Use Wayland related tools instead. (replace 'wrap-path (lambda* (#:key inputs #:allow-other-keys) base-commit: 5133fe25d4c105ce4bdc7134bc585a1f673d8a8b --=20 2.47.1 From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 02 08:58:55 2025 Received: (at submit) by debbugs.gnu.org; 2 Feb 2025 13:58:55 +0000 Received: from localhost ([127.0.0.1]:33642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1teaUx-0007MN-6z for submit@debbugs.gnu.org; Sun, 02 Feb 2025 08:58:55 -0500 Received: from lists.gnu.org ([2001:470:142::17]:47178) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1teaUs-0007M4-J7 for submit@debbugs.gnu.org; Sun, 02 Feb 2025 08:58:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1teaUn-0000r5-2t for guix-patches@gnu.org; Sun, 02 Feb 2025 08:58:45 -0500 Received: from 19.mo583.mail-out.ovh.net ([46.105.35.78]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1teaUk-0004SY-LA for guix-patches@gnu.org; Sun, 02 Feb 2025 08:58:44 -0500 Received: from director3.ghost.mail-out.ovh.net (unknown [10.109.148.178]) by mo583.mail-out.ovh.net (Postfix) with ESMTP id 4YmB702nydz1SHf for ; Sun, 2 Feb 2025 13:58:36 +0000 (UTC) Received: from ghost-submission-5b5ff79f4f-hw96f (unknown [10.111.182.250]) by director3.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 5CAF51FE0F; Sun, 2 Feb 2025 13:58:35 +0000 (UTC) Received: from ngraves.fr ([37.59.142.111]) by ghost-submission-5b5ff79f4f-hw96f with ESMTPSA id GMNWLgp6n2dvIAAAKgAxXQ (envelope-from ); Sun, 02 Feb 2025 13:58:35 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-111S0052434ca12-3e09-4711-8d97-f495919a05d7, 0EB4F4ACF34A069A1D12270FF355DD325781616A) smtp.auth=ngraves@ngraves.fr X-OVh-ClientIp: 176.179.136.47 From: Nicolas Graves To: Jake Koroman via Guix-patches via , 75885@debbugs.gnu.org Subject: Re: [bug#75885] [PATCH] gnu: rofi-pass-wayland In-Reply-To: <540352f17234386be527c9cc4ae0530f97fb7529.1737946971.git.jakekoroman@proton.me> References: <540352f17234386be527c9cc4ae0530f97fb7529.1737946971.git.jakekoroman@proton.me> Date: Sun, 02 Feb 2025 14:58:33 +0100 Message-ID: <87zfj4ih2u.fsf@ngraves.fr> MIME-Version: 1.0 Content-Type: text/plain X-Ovh-Tracer-Id: 8794404173154935415 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddugeekhecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhffkfggtgesthdtredttddttdenucfhrhhomheppfhitgholhgrshcuifhrrghvvghsuceonhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrqeenucggtffrrghtthgvrhhnpeevkeelueejtdehgfffkeelkefhhffftefgvdehkeeluefhheeuleejtdejhfdvgfenucfkphepuddvjedrtddrtddruddpudejiedrudejledrudefiedrgeejpdefjedrheelrddugedvrdduuddunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpehnghhrrghvvghssehnghhrrghvvghsrdhfrhdpnhgspghrtghpthhtohepuddprhgtphhtthhopehguhhigidqphgrthgthhgvshesghhnuhdrohhrghdpoffvtefjohhsthepmhhoheekfegmpdhmohguvgepshhmthhpohhuth DKIM-Signature: a=rsa-sha256; bh=7FRkCeYARmkwdLsdZLeR0CHlcPj5T+UIFHtUfk6UjDc=; c=relaxed/relaxed; d=ngraves.fr; h=From; s=ovhmo4487190-selector1; t=1738504716; v=1; b=bN3VxtIfc8rzzLiPa0P2kpKiOwVz9DZN39xAfFxwW+C2Ry5WyHM/PEU6G0OlBu+PiNyyfG6F S8l/gXpz8njDgpMnTzQ1uHCnV3OgOFujR7vFbpP6+C3apC55e3MbbSZv73kT89S+tVkiE1akKdp IyJwqsmFGwmfRiidDaW6+0GuqiillowiKYo5tyxnMJXtakXnYhsCkyqi72bE0y/FyKfYMqM8s1d TyiCyOf92h2sAkW2CvuP4hdUfNbyB6escwC6FY3/QtkRkJghavQnqOFqIeWE3WAL0ykmJHDeWgv gQc3t0L0hcujlV8srkM/hcoOBEOxYYrjRvo6tLWb4oB5A== Received-SPF: pass client-ip=46.105.35.78; envelope-from=ngraves@ngraves.fr; helo=19.mo583.mail-out.ovh.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: Jake Koroman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On 2025-01-27 03:05, Jake Koroman via Guix-patches via wrote: > * gnu/packages/password-utils.scm (rofi-pass-wayland): Removed doubled > /etc substitute. Hi Jake, welcome! Maybe you could be a little more precise, like that : [arguments]<#:phases>: Remove code doubling /etc prefix in phase 'set-wayland-defaults. But that's not a blocker to me. Tested, marking as LGTM. -- Best regards, Nicolas Graves From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 02 09:45:15 2025 Received: (at 75885) by debbugs.gnu.org; 2 Feb 2025 14:45:15 +0000 Received: from localhost ([127.0.0.1]:33700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tebDm-00046v-Ow for submit@debbugs.gnu.org; Sun, 02 Feb 2025 09:45:14 -0500 Received: from 13.mo550.mail-out.ovh.net ([178.33.253.128]:49969) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tebDi-00044K-FN for 75885@debbugs.gnu.org; Sun, 02 Feb 2025 09:45:12 -0500 Received: from director10.ghost.mail-out.ovh.net (unknown [10.108.9.41]) by mo550.mail-out.ovh.net (Postfix) with ESMTP id 4YmC8h3DcWz1VWW for <75885@debbugs.gnu.org>; Sun, 2 Feb 2025 14:45:08 +0000 (UTC) Received: from ghost-submission-5b5ff79f4f-v5t6v (unknown [10.110.118.5]) by director10.ghost.mail-out.ovh.net (Postfix) with ESMTPS id C7FE61FE67; Sun, 2 Feb 2025 14:45:07 +0000 (UTC) Received: from ngraves.fr ([37.59.142.103]) by ghost-submission-5b5ff79f4f-v5t6v with ESMTPSA id yBsQE/OEn2dneQAASd3DHQ (envelope-from ); Sun, 02 Feb 2025 14:45:07 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-103G005deb8fba3-b139-4558-a4f3-14d3a7d7fb6a, 0EB4F4ACF34A069A1D12270FF355DD325781616A) smtp.auth=ngraves@ngraves.fr X-OVh-ClientIp: 89.207.171.131 From: Nicolas Graves To: control@debbugs.gnu.org,75885@debbugs.gnu.org Subject: QA review for 75885 Date: Sun, 02 Feb 2025 15:45:06 +0100 Message-ID: <87seowl825.fsf@ngraves.fr> MIME-Version: 1.0 Content-Type: text/plain X-Ovh-Tracer-Id: 9580282309993816731 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddugeelhecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecunecujfgurhephffvufffkfggtgesthdtredttddttdenucfhrhhomheppfhitgholhgrshcuifhrrghvvghsuceonhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrqeenucggtffrrghtthgvrhhnpeeujeelieeljeffhfelteejtdeljeehveduffelvefgudefkeehgfdvvdevgeevfeenucfkphepuddvjedrtddrtddruddpkeelrddvtdejrddujedurddufedupdefjedrheelrddugedvrddutdefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpehnghhrrghvvghssehnghhrrghvvghsrdhfrhdpnhgspghrtghpthhtohepuddprhgtphhtthhopeejheekkeehseguvggssghughhsrdhgnhhurdhorhhgpdfovfetjfhoshhtpehmohehhedtmgdpmhhouggvpehsmhhtphhouhht DKIM-Signature: a=rsa-sha256; bh=X90Z8RFSjCIztahpOgLaubaT8KWOtdqrS8cGQKKy57Y=; c=relaxed/relaxed; d=ngraves.fr; h=From; s=ovhmo4487190-selector1; t=1738507508; v=1; b=fof5RnXjpSO0IHumK5X6g9MVQlKV/AHhVvBLdkukRkMGKbJ80varLKTLxjNRSlayhW12Hgq1 vp44EUt+DxDZRBy0Dakya1igUCmMVUyUqcj1V6TTFu/kvgsk3LRgZZA0SkXTiJd/4iRUJedfLB/ 7q2WRYKWq6/OAkZis5YnHO+fJVQM+qpo/4QZZ40fTEMO1/Ixn0kHcBGeivX1yu2S5Jh4pyzMkup B5aAiDMhMd5WGe1ej7dtdp9yqkKao1w30odE7nMkOVSTsOnW0KEEJT2gRI8S5Lu6S5ZwKlnVXSm r0e7ovx0kzqZMJEwmiORCqwBV7xMSMD+v+nJgRx0yhZCw== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75885 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) user guix usertag 75885 + reviewed-looks-good thanks Guix QA review form submission: The commit message could be more precise, but is acceptable IMO. I can confirm the fix claimed indeed happens. Items marked as checked: Lint warnings, Package builds, Commit messages -- Best regards, Nicolas Graves From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 02 16:55:17 2025 Received: (at 75885-done) by debbugs.gnu.org; 2 Feb 2025 21:55:17 +0000 Received: from localhost ([127.0.0.1]:36537 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tehvw-0000a1-Sb for submit@debbugs.gnu.org; Sun, 02 Feb 2025 16:55:17 -0500 Received: from fhigh-b7-smtp.messagingengine.com ([202.12.124.158]:57435) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tehvu-0000YV-Gw for 75885-done@debbugs.gnu.org; Sun, 02 Feb 2025 16:55:15 -0500 Received: from phl-compute-04.internal (phl-compute-04.phl.internal [10.202.2.44]) by mailfhigh.stl.internal (Postfix) with ESMTP id 4D72F254011B; Sun, 2 Feb 2025 16:55:08 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Sun, 02 Feb 2025 16:55:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=mesmtp; t=1738533308; x= 1738619708; bh=BI5SMv+mrVq1hqh5LolUv7bxlwgjxlgQq3arrGARjbI=; b=c nWyrQ92rB1LEQv3lu0nhiGHCNkHXzw1uspjRwW0gODLgRFeKXqvetJZC6lSLvUhq 1W54rrXQf0nsY56F5PvnEF1vk2n5VhVgp2KV9rBTVFK+NdPh2b2w0GxIBmY0yxwR 3Q+Cm2ZhAoeNWkph56sBjmTpdkBQMIvetJc7SFUlDQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1738533308; x=1738619708; bh=BI5SMv+mrVq1hqh5LolUv7bxlwgjxlgQq3a rrGARjbI=; b=lKxXmX7T/uwvtC5d26b8KHTk9wpC6g3ai+IKfh5bQ6T+SoGUaXa 1Lv7EojNW9UDRxYNXg2PYFY25D782nd/g8HjS1+2LJ6ZXeg8887KndModT6WxtpC p713OGJKjCAb0tuZlg4vSADHsDzKuhESOPzse2lhX9Eo+OFlOHk7qQVHLwsgMbXP QQbGCxydZ69XXO7QBCThg72wV+FCSt7006ilpfy6o90iQKlowY3Mch89PBECOOPU vkz04+92meFYlc2tUAeXVFVhxpk7aoEL9aztj6JjD3Y35IgIM4YziVn/SuN7cA1k JZHoGh8s/C0L87XutIoleE1g14uAfo7UKVw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduheekvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddv necuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnh grmhgvqeenucggtffrrghtthgvrhhnpeetheeuvdeivdelueeukefhtdeihedtgefhvddv lefhudejudeiheelfeevteeuhfenucffohhmrghinhepghhnuhdrohhrghenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhl rghrihdrnhgrmhgvpdhnsggprhgtphhtthhopeefpdhmohguvgepshhmthhpohhuthdprh gtphhtthhopehnghhrrghvvghssehnghhrrghvvghsrdhfrhdprhgtphhtthhopehjrghk vghkohhrohhmrghnsehprhhothhonhdrmhgvpdhrtghpthhtohepjeehkeekhedqughonh gvseguvggssghughhsrdhgnhhurdhorhhg X-ME-Proxy: Feedback-ID: i819c4023:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 2 Feb 2025 16:55:07 -0500 (EST) Date: Sun, 2 Feb 2025 16:55:05 -0500 From: Leo Famulari To: Nicolas Graves , Jake Koroman Subject: Re: [bug#75885] QA review for 75885 Message-ID: References: <540352f17234386be527c9cc4ae0530f97fb7529.1737946971.git.jakekoroman@proton.me> <87seowl825.fsf@ngraves.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87seowl825.fsf@ngraves.fr> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 75885-done Cc: 75885-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sun, Feb 02, 2025 at 03:45:06PM +0100, Nicolas Graves via Guix-patches via wrote: > user guix > usertag 75885 + reviewed-looks-good > thanks > > Guix QA review form submission: > The commit message could be more precise, but is acceptable IMO. I can confirm the fix claimed indeed happens. > > Items marked as checked: Lint warnings, Package builds, Commit messages Thanks Jake, for identifying the bug and sending a patch to fix it! I pushed your patch as commit ad59a0c88bac673e1267d928fdfe2e83858d2839 after rewriting the commit message to follow our format and be a little more informative (in my opinion): https://git.savannah.gnu.org/cgit/guix.git/commit/?id=ad59a0c88bac673e1267d928fdfe2e83858d2839 Nicolas, thanks for the review! From unknown Mon Aug 18 09:02:44 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 03 Mar 2025 12:24:15 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator