GNU bug report logs - #75880
relax five-digit maximum on revisions?

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Karl Berry <karl <at> freefriends.org>
Subject: bug#75880: closed (Re: bug#75880: relax five-digit maximum on
 revisions?)
Date: Tue, 28 Jan 2025 14:58:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#75880: relax five-digit maximum on revisions?

which was filed against the libtool package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 75880 <at> debbugs.gnu.org.

-- 
75880: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=75880
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ileana Dumitrescu <ileanadumitrescu95 <at> gmail.com>
To: 75880-done <at> debbugs.gnu.org
Cc: luigi.scarso <at> gmail.com, Karl Berry <karl <at> freefriends.org>
Subject: Re: bug#75880: relax five-digit maximum on revisions?
Date: Tue, 28 Jan 2025 16:57:05 +0200

[Message part 3 (text/plain, inline)]

The patch has been updated and pushed to the development branch [1].

Thank you for the bug report and help improving libtool!

[1] 
https://git.savannah.gnu.org/cgit/libtool.git/commit/?h=development&id=7b49ee14f9f350e60d890fc109143aa721bf76a9

-- 
Ileana Dumitrescu

GPG Public Key: FA26 CA78 4BE1 8892 7F22 B99F 6570 EA01 146F 7354

[OpenPGP_0x6570EA01146F7354.asc (application/pgp-keys, attachment)]

[OpenPGP_signature.asc (application/pgp-signature, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Karl Berry <karl <at> freefriends.org>
To: bug-libtool <at> gnu.org
Cc: luigi.scarso <at> gmail.com
Subject: relax five-digit maximum on revisions?
Date: Sun, 26 Jan 2025 15:35:07 -0700

Hi Ileana and all - in ltmain.in, there is:

    case $revision in
    0|[1-9]|[1-9][0-9]|[1-9][0-9][0-9]|[1-9][0-9][0-9][0-9]|[1-9][0-9][0-9][0-9][0-9]) ;;
    *)
      func_error "REVISION '$revision' must be a nonnegative integer"
      func_fatal_error "'$vinfo' is not valid version information"
      ;;
    esac

Which allows for at most five digits of $revision.
Is there a technical reason for that, or is it arbitrary?
Can it be increased, perhaps allowing any number?

My friend Luigi (cc-d) incorporates the luajit library into luatex with
libtool. Luajit is now a rolling release. Therefore using epoch-seconds
or similar seems reasonable, since there is no specific revision number
other than that. For example, 1736781742 (corresponding to a couple
weeks ago).

Wdyt?

Thanks,
Karl

P.S. I speculate that there's a technical maximum of 32 or 64 bits, so
"any" number (as in \d+) would technically be wrong, but presumably such
a huge number will fail at some point. IMHO the user doesn't deserve a
nice error message if they exceed a maximum like that.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.