GNU bug report logs - #75877
30.0.91; dired-omit-expunge embeds unquoted filename in format string

Previous Next

Package: emacs;

Reported by: Derek Upham <derek_upham <at> mailfence.com>

Date: Sun, 26 Jan 2025 18:27:02 UTC

Severity: normal

Found in version 30.0.91

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #13 received at 75877-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Derek Upham <derek_upham <at> mailfence.com>
Cc: 75877-done <at> debbugs.gnu.org
Subject: Re: bug#75877: 30.0.91; dired-omit-expunge embeds unquoted filename
 in format string
Date: Wed, 05 Feb 2025 15:49:46 +0200
> From: Derek Upham <derek_upham <at> mailfence.com>
> Date: Tue, 04 Feb 2025 15:40:12 -0800
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > Thanks.  Is the below the right fix?
> >
> > diff --git a/lisp/dired-x.el b/lisp/dired-x.el
> > index 4a05f60..89390a4 100644
> > --- a/lisp/dired-x.el
> > +++ b/lisp/dired-x.el
> > @@ -498,8 +498,10 @@ dired-omit-expunge
> >                                 nil
> >                                 (if dired-omit-verbose
> >                                     (format "Omitted %%d line%%s 
> >                                     in %s"
> > - 
> > (abbreviate-file-name
> > -                                            dired-directory))
> > + 
> > (replace-regexp-in-string
> > +                                            "%" "%%"
> > + 
> > (abbreviate-file-name
> > +                                             dired-directory)))
> >                                   "")
> >                                 init-count)))
> >                (force-mode-line-update))))
> 
> Yeah, that patch will handle that use case.  Thanks.

Thanks, installed on the master branch, and closing the bug.




This bug report was last modified 110 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.