From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 07 15:56:03 2010 Received: (at submit) by debbugs.gnu.org; 7 Dec 2010 20:56:03 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PQ4Zu-0000ck-Le for submit@debbugs.gnu.org; Tue, 07 Dec 2010 15:56:03 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PQ4Zq-0000cF-Ec for submit@debbugs.gnu.org; Tue, 07 Dec 2010 15:55:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PQ4fZ-0007Rk-Fv for submit@debbugs.gnu.org; Tue, 07 Dec 2010 16:01:54 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,T_RP_MATCHES_RCVD,T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:58893) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PQ4fZ-0007Rg-Dq for submit@debbugs.gnu.org; Tue, 07 Dec 2010 16:01:53 -0500 Received: from [140.186.70.92] (port=52450 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PQ4fY-0007QE-Ik for bug-gnu-emacs@gnu.org; Tue, 07 Dec 2010 16:01:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PQ4fW-0007QJ-LN for bug-gnu-emacs@gnu.org; Tue, 07 Dec 2010 16:01:52 -0500 Received: from fmmailgate01.web.de ([217.72.192.221]:54577) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PQ4fU-0007O3-Ha for bug-gnu-emacs@gnu.org; Tue, 07 Dec 2010 16:01:50 -0500 Received: from smtp01.web.de ( [172.20.0.243]) by fmmailgate01.web.de (Postfix) with ESMTP id D5326180E6414 for ; Tue, 7 Dec 2010 22:01:05 +0100 (CET) Received: from [217.185.137.27] (helo=snow) by smtp01.web.de with asmtp (WEB.DE 4.110 #24) id 1PQ4en-0002Lg-00 for bug-gnu-emacs@gnu.org; Tue, 07 Dec 2010 22:01:05 +0100 From: Michael Heerdegen To: bug-gnu-emacs@gnu.org Subject: 23.2; `format-mode-line' makes Emacs crash Date: Tue, 07 Dec 2010 22:01:25 +0100 Message-ID: <87d3pd5mca.fsf@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Sender: michael_heerdegen@web.de X-Provags-ID: V01U2FsdGVkX1+uEfGTuHvMv5bggenbY7KNcT2yjfVe3fRp7wS+ wH0ZsXvxEeXmcdHWyq8mHE1f/Q/luuIt9UNTl6G7nu0/yctQSG NIENeVG2EjgMyU7zqZeQ== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -6.6 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: michael_heerdegen@web.de List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) Hello, if I evaluate the following sexp in a fresh emacs -Q (e.g. with `eval-expression'): (progn (face-remap-add-relative 'mode-line :height 1.0) (format-mode-line mode-line-format t)) Emacs instantly crashes. In GNU Emacs 23.2.1 (i486-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2010-08-14 on raven, modified by Debian Windowing system distributor `The X.Org Foundation', version 11.0.10707000 configured using `configure '--build' 'i486-linux-gnu' '--build' 'i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.2/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.2/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.2/leim' '--with-x=yes' '--with-x-toolkit=lucid' '--with-toolkit-scroll-bars' '--without-gconf' 'build_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS='' Important settings: value of $LC_ALL: de_DE.utf8 value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: C value of $LANG: de_DE.utf8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default enable-multibyte-characters: t From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 10 10:56:16 2010 Received: (at 7587) by debbugs.gnu.org; 10 Dec 2010 15:56:17 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PR5KS-0001f2-HW for submit@debbugs.gnu.org; Fri, 10 Dec 2010 10:56:16 -0500 Received: from mtaout21.012.net.il ([80.179.55.169]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PR5KO-0001en-VH for 7587@debbugs.gnu.org; Fri, 10 Dec 2010 10:56:14 -0500 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0LD700F00Z6PKZ00@a-mtaout21.012.net.il> for 7587@debbugs.gnu.org; Fri, 10 Dec 2010 18:02:09 +0200 (IST) Received: from HOME-C4E4A596F7 ([84.229.142.197]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LD700FG6Z7KBA60@a-mtaout21.012.net.il>; Fri, 10 Dec 2010 18:02:09 +0200 (IST) Date: Fri, 10 Dec 2010 18:02:21 +0200 From: Eli Zaretskii Subject: Re: bug#7587: 23.2; `format-mode-line' makes Emacs crash In-reply-to: <87d3pd5mca.fsf@web.de> X-012-Sender: halo1@inter.net.il To: michael_heerdegen@web.de Message-id: <83k4jh1ur6.fsf@gnu.org> References: <87d3pd5mca.fsf@web.de> X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 7587 Cc: 7587@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > From: Michael Heerdegen > Date: Tue, 07 Dec 2010 22:01:25 +0100 > Cc: > > if I evaluate the following sexp in a fresh emacs -Q (e.g. with > `eval-expression'): > > (progn > (face-remap-add-relative 'mode-line :height 1.0) > (format-mode-line mode-line-format t)) > > Emacs instantly crashes. This happens because, for some reason I don't understand, when face-remapping-alist is non-nil, lookup_basic_face insists on getting only one of the basic faces, and otherwise aborts: if (NILP (Vface_remapping_alist)) return face_id; /* Nothing to do. */ switch (face_id) { case DEFAULT_FACE_ID: name = Qdefault; break; case MODE_LINE_FACE_ID: name = Qmode_line; break; case MODE_LINE_INACTIVE_FACE_ID: name = Qmode_line_inactive; break; case HEADER_LINE_FACE_ID: name = Qheader_line; break; case TOOL_BAR_FACE_ID: name = Qtool_bar; break; case FRINGE_FACE_ID: name = Qfringe; break; case SCROLL_BAR_FACE_ID: name = Qscroll_bar; break; case BORDER_FACE_ID: name = Qborder; break; case CURSOR_FACE_ID: name = Qcursor; break; case MOUSE_FACE_ID: name = Qmouse; break; case MENU_FACE_ID: name = Qmenu; break; default: abort (); /* the caller is supposed to pass us a basic face id */ } This is inconsistent, because if face-remapping-alist _is_ nil, the function returns face_id unaltered, no matter if it is or isn't a basic face. Any objections to the following patch? On the release branch as well? === modified file 'src/xfaces.c' --- src/xfaces.c 2010-08-06 10:12:41 +0000 +++ src/xfaces.c 2010-12-10 15:58:25 +0000 @@ -4673,9 +4673,6 @@ lookup_basic_face (struct frame *f, int case CURSOR_FACE_ID: name = Qcursor; break; case MOUSE_FACE_ID: name = Qmouse; break; case MENU_FACE_ID: name = Qmenu; break; - - default: - abort (); /* the caller is supposed to pass us a basic face id */ } /* Do a quick scan through Vface_remapping_alist, and return immediately From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 10 11:34:26 2010 Received: (at 7587) by debbugs.gnu.org; 10 Dec 2010 16:34:26 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PR5vO-0002Wn-0O for submit@debbugs.gnu.org; Fri, 10 Dec 2010 11:34:26 -0500 Received: from mtaout23.012.net.il ([80.179.55.175]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PR5vK-0002WY-Jk for 7587@debbugs.gnu.org; Fri, 10 Dec 2010 11:34:23 -0500 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0LD800A000T3OH00@a-mtaout23.012.net.il> for 7587@debbugs.gnu.org; Fri, 10 Dec 2010 18:39:01 +0200 (IST) Received: from HOME-C4E4A596F7 ([84.229.142.197]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LD800AVS0WZF490@a-mtaout23.012.net.il>; Fri, 10 Dec 2010 18:39:00 +0200 (IST) Date: Fri, 10 Dec 2010 18:39:12 +0200 From: Eli Zaretskii Subject: Re: bug#7587: 23.2; `format-mode-line' makes Emacs crash In-reply-to: <83k4jh1ur6.fsf@gnu.org> X-012-Sender: halo1@inter.net.il To: michael_heerdegen@web.de, 7587@debbugs.gnu.org Message-id: <83ipz11t1r.fsf@gnu.org> References: <87d3pd5mca.fsf@web.de> <83k4jh1ur6.fsf@gnu.org> X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 7587 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > Date: Fri, 10 Dec 2010 18:02:21 +0200 > From: Eli Zaretskii > Cc: 7587@debbugs.gnu.org > > === modified file 'src/xfaces.c' > --- src/xfaces.c 2010-08-06 10:12:41 +0000 > +++ src/xfaces.c 2010-12-10 15:58:25 +0000 > @@ -4673,9 +4673,6 @@ lookup_basic_face (struct frame *f, int > case CURSOR_FACE_ID: name = Qcursor; break; > case MOUSE_FACE_ID: name = Qmouse; break; > case MENU_FACE_ID: name = Qmenu; break; > - > - default: > - abort (); /* the caller is supposed to pass us a basic face id */ > } > > /* Do a quick scan through Vface_remapping_alist, and return immediately Sorry, wrong patch. I meant this one: === modified file 'src/xfaces.c' --- src/xfaces.c 2010-08-06 10:12:41 +0000 +++ src/xfaces.c 2010-12-10 16:36:37 +0000 @@ -4675,7 +4675,7 @@ lookup_basic_face (struct frame *f, int case MENU_FACE_ID: name = Qmenu; break; default: - abort (); /* the caller is supposed to pass us a basic face id */ + return face_id; /* Nothing to do. */ } /* Do a quick scan through Vface_remapping_alist, and return immediately From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 10 15:44:36 2010 Received: (at 7587) by debbugs.gnu.org; 10 Dec 2010 20:44:36 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PR9pU-0000s3-MK for submit@debbugs.gnu.org; Fri, 10 Dec 2010 15:44:36 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PR9pN-0000rR-R0 for 7587@debbugs.gnu.org; Fri, 10 Dec 2010 15:44:30 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Aj8LAL4hAk3O+KIs/2dsb2JhbACic4Eaeb9NhUoEhGSOBQ X-IronPort-AV: E=Sophos;i="4.59,326,1288584000"; d="scan'208";a="85136200" Received: from 206-248-162-44.dsl.teksavvy.com (HELO ceviche.home) ([206.248.162.44]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 10 Dec 2010 15:50:31 -0500 Received: by ceviche.home (Postfix, from userid 20848) id 6586B6616B; Fri, 10 Dec 2010 15:50:31 -0500 (EST) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#7587: 23.2; `format-mode-line' makes Emacs crash Message-ID: References: <87d3pd5mca.fsf@web.de> <83k4jh1ur6.fsf@gnu.org> Date: Fri, 10 Dec 2010 15:50:31 -0500 In-Reply-To: <83k4jh1ur6.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 10 Dec 2010 18:02:21 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 7587 Cc: michael_heerdegen@web.de, 7587@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > This happens because, for some reason I don't understand, when > face-remapping-alist is non-nil, lookup_basic_face insists on getting > only one of the basic faces, and otherwise aborts: I don't know anything about this code, but the name `lookup_basic_face' suggests it only works for basic faces, so maybe the problem is that the function gets incorrectly called for a non-basic face. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 10 17:34:01 2010 Received: (at 7587) by debbugs.gnu.org; 10 Dec 2010 22:34:01 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PRBXM-0004Ap-HT for submit@debbugs.gnu.org; Fri, 10 Dec 2010 17:34:00 -0500 Received: from mtaout20.012.net.il ([80.179.55.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PRBXK-0004Ab-PU for 7587@debbugs.gnu.org; Fri, 10 Dec 2010 17:33:59 -0500 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LD800G00H72XA00@a-mtaout20.012.net.il> for 7587@debbugs.gnu.org; Sat, 11 Dec 2010 00:40:02 +0200 (IST) Received: from HOME-C4E4A596F7 ([84.229.142.197]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LD800GR8HMORP50@a-mtaout20.012.net.il>; Sat, 11 Dec 2010 00:40:02 +0200 (IST) Date: Sat, 11 Dec 2010 00:40:14 +0200 From: Eli Zaretskii Subject: Re: bug#7587: 23.2; `format-mode-line' makes Emacs crash In-reply-to: X-012-Sender: halo1@inter.net.il To: Stefan Monnier , Miles Bader Message-id: <83fwu51cc1.fsf@gnu.org> References: <87d3pd5mca.fsf@web.de> <83k4jh1ur6.fsf@gnu.org> X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 7587 Cc: michael_heerdegen@web.de, 7587@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > From: Stefan Monnier > Cc: michael_heerdegen@web.de, 7587@debbugs.gnu.org > Date: Fri, 10 Dec 2010 15:50:31 -0500 > > > This happens because, for some reason I don't understand, when > > face-remapping-alist is non-nil, lookup_basic_face insists on getting > > only one of the basic faces, and otherwise aborts: > > I don't know anything about this code Who does? Miles, do you? > but the name `lookup_basic_face' suggests it only works for basic > faces Actually, it works for non-basic faces as well--but only if face-remapping-alist is nil. See this part of it, which I cited: if (NILP (Vface_remapping_alist)) return face_id; /* Nothing to do. */ The patch I suggest simply make lookup_basic_face behave consistently regardless of the value of face-remapping-alist. > so maybe the problem is that the function gets incorrectly called > for a non-basic face. It _does_ get called with a basic face (`mode-line'), but that face has been remapped. Remapping actually creates a new face ID in the face cache, but lookup_basic_face gets an ID (an integer), not a symbol Qmode_line etc. So if the face ID that lookup_basic_face gets is not one of the IDs reserved for the 12 basic faces, _and_ face-remapping-alist is non-nil, lookup_basic_face always pukes. Here's more context about the chain of calls that leads to the crash: The call to lookup_basic_face comes from init_iterator: /* Perhaps remap BASE_FACE_ID to a user-specified alternative. */ if (! NILP (Vface_remapping_alist)) remapped_base_face_id = lookup_basic_face (XFRAME (w->frame), base_face_id); init_iterator does this because it expects a truly basic face in base_face_id, and it wants to use its face-remapped variety, as the user would expect. But in this case, we pass to it an already remapped basic face, see this part of format-mode-line: if (!NILP (face)) { if (EQ (face, Qt)) face = (EQ (window, selected_window) ? Qmode_line : Qmode_line_inactive); face_id = lookup_named_face (XFRAME (WINDOW_FRAME (w)), face, 0); } ... init_iterator (&it, w, -1, -1, NULL, face_id); lookup_named_face returns the face ID of the remapped mode-line face. So in this case, face_id is already an ID of the remapped mode-line face, and returning it unaltered from lookup_basic_face is TRT. As an alternative, we could refrain from calling lookup_basic_face in init_iterator if the argument base_face_id is not one of the 12 basic face IDs. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 15 21:11:41 2010 Received: (at 7587) by debbugs.gnu.org; 16 Dec 2010 02:11:42 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PT3Jl-0000BY-1Q for submit@debbugs.gnu.org; Wed, 15 Dec 2010 21:11:41 -0500 Received: from vm-emlprdomr-03.its.yale.edu ([130.132.50.144]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PT3Jj-0000BM-Aq for 7587@debbugs.gnu.org; Wed, 15 Dec 2010 21:11:39 -0500 Received: from furball (bb121-6-218-24.singnet.com.sg [121.6.218.24]) (authenticated bits=0) by vm-emlprdomr-03.its.yale.edu (8.14.4/8.14.4) with ESMTP id oBG2Hr1X011548 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 15 Dec 2010 21:17:56 -0500 Received: by furball (Postfix, from userid 1000) id AE7E3161788; Wed, 15 Dec 2010 21:17:51 -0500 (EST) From: Chong Yidong To: Eli Zaretskii Subject: Re: bug#7587: 23.2; `format-mode-line' makes Emacs crash References: <87d3pd5mca.fsf@web.de> <83k4jh1ur6.fsf@gnu.org> <83fwu51cc1.fsf@gnu.org> Date: Thu, 16 Dec 2010 10:17:51 +0800 In-Reply-To: <83fwu51cc1.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 11 Dec 2010 00:40:14 +0200") Message-ID: <87ei9icvg0.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.144 X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 7587 Cc: michael_heerdegen@web.de, 7587@debbugs.gnu.org, Stefan Monnier , Miles Bader X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) Eli Zaretskii writes: > The call to lookup_basic_face comes from init_iterator: > init_iterator does this because it expects a truly basic face in > base_face_id, and it wants to use its face-remapped variety, as the > user would expect. But in this case, we pass to it an already > remapped basic face, see this part of format-mode-line: > lookup_named_face returns the face ID of the remapped mode-line face. > So in this case, face_id is already an ID of the remapped mode-line > face, and returning it unaltered from lookup_basic_face is TRT. format-mode-line should not pass non-basic faces to init_iterator. I'm not even sure what the FACE argument to format-mode-line is useful for; it doesn't seem to be used anywhere in the sources. I've changed format-mode-line so that if you pass a face argument to FACES, it should be one of `default', `mode-line', etc. Any other face gets treated as `default'. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 15 21:11:53 2010 Received: (at control) by debbugs.gnu.org; 16 Dec 2010 02:11:54 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PT3Jx-0000Bu-Ay for submit@debbugs.gnu.org; Wed, 15 Dec 2010 21:11:53 -0500 Received: from vm-emlprdomr-03.its.yale.edu ([130.132.50.144]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PT3Jw-0000Bj-4C for control@debbugs.gnu.org; Wed, 15 Dec 2010 21:11:52 -0500 Received: from furball (bb121-6-218-24.singnet.com.sg [121.6.218.24]) (authenticated bits=0) by vm-emlprdomr-03.its.yale.edu (8.14.4/8.14.4) with ESMTP id oBG2I6B9011591 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Wed, 15 Dec 2010 21:18:09 -0500 Received: by furball (Postfix, from userid 1000) id 00F41161788; Wed, 15 Dec 2010 21:18:04 -0500 (EST) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 7587 Date: Thu, 16 Dec 2010 10:18:04 +0800 Message-ID: <8739pyihpf.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.144 X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) close 7587 thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 15 23:33:04 2010 Received: (at 7587) by debbugs.gnu.org; 16 Dec 2010 04:33:05 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PT5Wa-0004hi-H5 for submit@debbugs.gnu.org; Wed, 15 Dec 2010 23:33:04 -0500 Received: from rcsinet10.oracle.com ([148.87.113.121]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PT5WX-0004hF-TD for 7587@debbugs.gnu.org; Wed, 15 Dec 2010 23:33:02 -0500 Received: from rcsinet13.oracle.com (rcsinet13.oracle.com [148.87.113.125]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id oBG4dHgd030907 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 16 Dec 2010 04:39:19 GMT Received: from acsmt355.oracle.com (acsmt355.oracle.com [141.146.40.155]) by rcsinet13.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id oBG4dETa030725; Thu, 16 Dec 2010 04:39:14 GMT Received: from abhmt018.oracle.com by acsmt353.oracle.com with ESMTP id 879328341292474343; Wed, 15 Dec 2010 20:39:03 -0800 Received: from dradamslap1 (/10.159.220.11) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 15 Dec 2010 20:39:03 -0800 From: "Drew Adams" To: "'Chong Yidong'" , "'Eli Zaretskii'" References: <87d3pd5mca.fsf@web.de> <83k4jh1ur6.fsf@gnu.org> <83fwu51cc1.fsf@gnu.org> <87ei9icvg0.fsf@stupidchicken.com> Subject: RE: bug#7587: 23.2; `format-mode-line' makes Emacs crash Date: Wed, 15 Dec 2010 20:39:01 -0800 Message-ID: <494A553B7DD74813AD43A51BAEB37703@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87ei9icvg0.fsf@stupidchicken.com> Thread-Index: AcucyCGF58ZThnYaTH+bwc6AUU1chAAEu5Uw X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 7587 Cc: michael_heerdegen@web.de, 7587@debbugs.gnu.org, 'Miles Bader' X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) > I've changed format-mode-line so that if you pass a face argument to > FACES, it should be one of `default', `mode-line', etc. Any > other face gets treated as `default'. I guess that restriction will be documented in the doc string, then? Thx. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 16 00:29:39 2010 Received: (at 7587) by debbugs.gnu.org; 16 Dec 2010 05:29:40 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PT6PL-0005tc-Gd for submit@debbugs.gnu.org; Thu, 16 Dec 2010 00:29:39 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PT6PJ-0005tQ-30 for 7587@debbugs.gnu.org; Thu, 16 Dec 2010 00:29:37 -0500 Received: from eliz by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1PT6VL-0006G6-N2; Thu, 16 Dec 2010 00:35:51 -0500 From: Eli Zaretskii To: Chong Yidong In-reply-to: <87ei9icvg0.fsf@stupidchicken.com> (message from Chong Yidong on Thu, 16 Dec 2010 10:17:51 +0800) Subject: Re: bug#7587: 23.2; `format-mode-line' makes Emacs crash References: <87d3pd5mca.fsf@web.de> <83k4jh1ur6.fsf@gnu.org> <83fwu51cc1.fsf@gnu.org> <87ei9icvg0.fsf@stupidchicken.com> Message-Id: Date: Thu, 16 Dec 2010 00:35:51 -0500 X-Spam-Score: -6.5 (------) X-Debbugs-Envelope-To: 7587 Cc: michael_heerdegen@web.de, 7587@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.5 (------) > From: Chong Yidong > Cc: Stefan Monnier , Miles Bader , > michael_heerdegen@web.de, 7587@debbugs.gnu.org > Date: Thu, 16 Dec 2010 10:17:51 +0800 > > format-mode-line should not pass non-basic faces to init_iterator. Where do you see this condition enforced or assumed in the code? I see only the commentary before init_iterator, but I'm not sure which code (except lookup_basic_face) would really puke or DTWT with a non-basic face. And support for face remapping already means that you can sneak a non-basic face in, anyway. > I'm not even sure what the FACE argument to format-mode-line is > useful for The doc string and the ELisp manual clearly answer that question: format-mode-line can be used to compute the formatted string without displaying it. When you use this API that way, you can specify a face for the parts of mode line that don't have their faces specified in the mode-line format. IOW, it sounds like a deliberate feature, given the description in the ELisp manual. > it doesn't seem to be used anywhere in the sources. ?? init_iterator uses it (well, its index in the face cache) to initialize the appropriate member of the iterator object. > I've changed format-mode-line so that if you pass a face argument to > FACES, it should be one of `default', `mode-line', etc. Any other face > gets treated as `default'. Given some history of discussions here, and the fact that no one seems to be sure how this code should really work and why, I wonder why you went ahead with the change without discussing it first. I'm afraid that this change breaks backward compatibility for no good reason. Anyway, this being an incompatible change, it should be in NEWS. In addition, the ELisp manual should be modified accordingly. Also, there seems to be a bug in the change itself, in this line: + : EQ (face, Qmode_line_inactive) ? MODE_LINE_FACE_ID From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 16 00:31:04 2010 Received: (at 7587) by debbugs.gnu.org; 16 Dec 2010 05:31:04 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PT6Qh-0005ws-S9 for submit@debbugs.gnu.org; Thu, 16 Dec 2010 00:31:04 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PT6Qa-0005wU-TT for 7587@debbugs.gnu.org; Thu, 16 Dec 2010 00:30:57 -0500 Received: from eliz by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1PT6We-0006Jr-5X; Thu, 16 Dec 2010 00:37:12 -0500 From: Eli Zaretskii To: "Drew Adams" In-reply-to: <494A553B7DD74813AD43A51BAEB37703@us.oracle.com> (drew.adams@oracle.com) Subject: Re: bug#7587: 23.2; `format-mode-line' makes Emacs crash References: <87d3pd5mca.fsf@web.de> <83k4jh1ur6.fsf@gnu.org> <83fwu51cc1.fsf@gnu.org> <87ei9icvg0.fsf@stupidchicken.com> <494A553B7DD74813AD43A51BAEB37703@us.oracle.com> Message-Id: Date: Thu, 16 Dec 2010 00:37:12 -0500 X-Spam-Score: -6.5 (------) X-Debbugs-Envelope-To: 7587 Cc: michael_heerdegen@web.de, 7587@debbugs.gnu.org, cyd@stupidchicken.com, miles@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.5 (------) > From: "Drew Adams" > Cc: , <7587@debbugs.gnu.org>, > "'Miles Bader'" > Date: Wed, 15 Dec 2010 20:39:01 -0800 > > > I've changed format-mode-line so that if you pass a face argument to > > FACES, it should be one of `default', `mode-line', etc. Any > > other face gets treated as `default'. > > I guess that restriction will be documented in the doc string, then? Thx. That's part of the change committed by Chong, yes. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 18 03:49:58 2010 Received: (at 7587) by debbugs.gnu.org; 18 Dec 2010 08:49:58 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PTsUI-0005a5-1G for submit@debbugs.gnu.org; Sat, 18 Dec 2010 03:49:58 -0500 Received: from mtaout20.012.net.il ([80.179.55.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PTsUF-0005Zr-TP for 7587@debbugs.gnu.org; Sat, 18 Dec 2010 03:49:57 -0500 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LDM00C008OSRA00@a-mtaout20.012.net.il> for 7587@debbugs.gnu.org; Sat, 18 Dec 2010 10:56:11 +0200 (IST) Received: from HOME-C4E4A596F7 ([84.229.167.122]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LDM00BCA8TMY790@a-mtaout20.012.net.il>; Sat, 18 Dec 2010 10:56:11 +0200 (IST) Date: Sat, 18 Dec 2010 10:56:18 +0200 From: Eli Zaretskii Subject: Re: bug#7587: 23.2; `format-mode-line' makes Emacs crash In-reply-to: X-012-Sender: halo1@inter.net.il To: cyd@stupidchicken.com, michael_heerdegen@web.de, 7587@debbugs.gnu.org Message-id: <83r5dffoi5.fsf@gnu.org> References: <87d3pd5mca.fsf@web.de> <83k4jh1ur6.fsf@gnu.org> <83fwu51cc1.fsf@gnu.org> <87ei9icvg0.fsf@stupidchicken.com> X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 7587 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > From: Eli Zaretskii > Date: Thu, 16 Dec 2010 00:35:51 -0500 > Cc: michael_heerdegen@web.de, 7587@debbugs.gnu.org > > Anyway, this being an incompatible change, it should be in NEWS. In > addition, the ELisp manual should be modified accordingly. > > Also, there seems to be a bug in the change itself, in this line: > > + : EQ (face, Qmode_line_inactive) ? MODE_LINE_FACE_ID I fixed these now. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 20 10:23:24 2010 Received: (at 7587) by debbugs.gnu.org; 20 Dec 2010 15:23:24 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PUha7-0000Vb-Os for submit@debbugs.gnu.org; Mon, 20 Dec 2010 10:23:23 -0500 Received: from vm-emlprdomr-04.its.yale.edu ([130.132.50.145]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PUha6-0000VP-6R for 7587@debbugs.gnu.org; Mon, 20 Dec 2010 10:23:22 -0500 Received: from furball (bb116-14-228-227.singnet.com.sg [116.14.228.227]) (authenticated bits=0) by vm-emlprdomr-04.its.yale.edu (8.14.4/8.14.4) with ESMTP id oBKFTldq022795 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 20 Dec 2010 10:29:50 -0500 Received: by furball (Postfix, from userid 1000) id 865DC161E17; Mon, 20 Dec 2010 23:29:48 +0800 (SGT) From: Chong Yidong To: Eli Zaretskii Subject: Re: bug#7587: 23.2; `format-mode-line' makes Emacs crash References: <87d3pd5mca.fsf@web.de> <83k4jh1ur6.fsf@gnu.org> <83fwu51cc1.fsf@gnu.org> <87ei9icvg0.fsf@stupidchicken.com> <83r5dffoi5.fsf@gnu.org> Date: Mon, 20 Dec 2010 23:29:48 +0800 In-Reply-To: <83r5dffoi5.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 18 Dec 2010 10:56:18 +0200") Message-ID: <87y67k1mz7.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.145 X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 7587 Cc: michael_heerdegen@web.de, 7587@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Eli Zaretskii writes: >> + : EQ (face, Qmode_line_inactive) ? MODE_LINE_FACE_ID > > I fixed these now. Thanks. > > I'm not even sure what the FACE argument to format-mode-line is > > useful for > > The doc string and the ELisp manual clearly answer that question: > format-mode-line can be used to compute the formatted string without > displaying it. When you use this API that way, you can specify a face > for the parts of mode line that don't have their faces specified in > the mode-line format. IOW, it sounds like a deliberate feature, given > the description in the ELisp manual. > > > it doesn't seem to be used anywhere in the sources. > > ?? init_iterator uses it (well, its index in the face cache) to > initialize the appropriate member of the iterator object. I mean, format-mode-line with a non-nil FACE argument doesn't seem to be used anywhere. > Given some history of discussions here, and the fact that no one seems > to be sure how this code should really work and why, I wonder why you > went ahead with the change without discussing it first. I'm afraid > that this change breaks backward compatibility for no good reason. Given that the backward compatible behavior is to segfault, this breakage might be acceptable. Less flippantly, the FACE argument, if non-nil, is still applied as a text property to the returned string. So I don't think there's going to be any noticeable difference (again, we don't have any concrete use cases, so it's difficult to say). The docstring change might not even be necessary. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 20 13:29:07 2010 Received: (at 7587) by debbugs.gnu.org; 20 Dec 2010 18:29:08 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PUkTr-0004Yo-NF for submit@debbugs.gnu.org; Mon, 20 Dec 2010 13:29:07 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PUkTo-0004YK-Rm for 7587@debbugs.gnu.org; Mon, 20 Dec 2010 13:29:06 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LDQ00200OY0LL00@a-mtaout22.012.net.il> for 7587@debbugs.gnu.org; Mon, 20 Dec 2010 20:35:26 +0200 (IST) Received: from HOME-C4E4A596F7 ([84.229.167.122]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LDQ0007OOZ0MFJ0@a-mtaout22.012.net.il>; Mon, 20 Dec 2010 20:35:26 +0200 (IST) Date: Mon, 20 Dec 2010 20:33:22 +0200 From: Eli Zaretskii Subject: Re: bug#7587: 23.2; `format-mode-line' makes Emacs crash In-reply-to: <87y67k1mz7.fsf@stupidchicken.com> X-012-Sender: halo1@inter.net.il To: Chong Yidong Message-id: <83d3owfg5p.fsf@gnu.org> References: <87d3pd5mca.fsf@web.de> <83k4jh1ur6.fsf@gnu.org> <83fwu51cc1.fsf@gnu.org> <87ei9icvg0.fsf@stupidchicken.com> <83r5dffoi5.fsf@gnu.org> <87y67k1mz7.fsf@stupidchicken.com> X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 7587 Cc: michael_heerdegen@web.de, 7587@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > From: Chong Yidong > Cc: michael_heerdegen@web.de, 7587@debbugs.gnu.org > Date: Mon, 20 Dec 2010 23:29:48 +0800 > > I mean, format-mode-line with a non-nil FACE argument doesn't seem to be > used anywhere. Not in Emacs sources, no. But it's a feature that some application could plausibly want. > > Given some history of discussions here, and the fact that no one seems > > to be sure how this code should really work and why, I wonder why you > > went ahead with the change without discussing it first. I'm afraid > > that this change breaks backward compatibility for no good reason. > > Given that the backward compatible behavior is to segfault, this > breakage might be acceptable. It only crashed if some faces were remapped, otherwise it would "just work". (And it isn't a segfault, it's a deliberate call to `abort'.) > Less flippantly, the FACE argument, if non-nil, is still applied as a > text property to the returned string. Which makes me wonder why we need to pass to init_iterator anything but DEFAULT_FACE_ID... > So I don't think there's going to be any noticeable difference > (again, we don't have any concrete use cases, so it's difficult to > say). The docstring change might not even be necessary. If FACE is still applied, then the doc string change (and part of what I wrote in NEWS and the ELisp manual) should indeed be reverted. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 25 05:13:57 2010 Received: (at 7587) by debbugs.gnu.org; 25 Dec 2010 10:13:57 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PWR8O-0008Fl-NF for submit@debbugs.gnu.org; Sat, 25 Dec 2010 05:13:56 -0500 Received: from mtaout23.012.net.il ([80.179.55.175]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PWR8N-0008FY-6B for 7587@debbugs.gnu.org; Sat, 25 Dec 2010 05:13:56 -0500 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0LDZ00700B1Q2600@a-mtaout23.012.net.il> for 7587@debbugs.gnu.org; Sat, 25 Dec 2010 12:20:36 +0200 (IST) Received: from HOME-C4E4A596F7 ([84.229.17.87]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LDZ0076EBEA0R40@a-mtaout23.012.net.il>; Sat, 25 Dec 2010 12:20:35 +0200 (IST) Date: Sat, 25 Dec 2010 12:18:39 +0200 From: Eli Zaretskii Subject: Re: bug#7587: 23.2; `format-mode-line' makes Emacs crash In-reply-to: <83d3owfg5p.fsf@gnu.org> X-012-Sender: halo1@inter.net.il To: cyd@stupidchicken.com Message-id: <83tyi2cg00.fsf@gnu.org> References: <87d3pd5mca.fsf@web.de> <83k4jh1ur6.fsf@gnu.org> <83fwu51cc1.fsf@gnu.org> <87ei9icvg0.fsf@stupidchicken.com> <83r5dffoi5.fsf@gnu.org> <87y67k1mz7.fsf@stupidchicken.com> <83d3owfg5p.fsf@gnu.org> X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 7587 Cc: michael_heerdegen@web.de, 7587@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > Date: Mon, 20 Dec 2010 20:33:22 +0200 > From: Eli Zaretskii > Cc: michael_heerdegen@web.de, 7587@debbugs.gnu.org > > > Less flippantly, the FACE argument, if non-nil, is still applied as a > > text property to the returned string. > > Which makes me wonder why we need to pass to init_iterator anything > but DEFAULT_FACE_ID... > > > So I don't think there's going to be any noticeable difference > > (again, we don't have any concrete use cases, so it's difficult to > > say). The docstring change might not even be necessary. > > If FACE is still applied, then the doc string change (and part of what > I wrote in NEWS and the ELisp manual) should indeed be reverted. Done. From unknown Sun Jun 22 00:16:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 22 Jan 2011 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator