GNU bug report logs - #75858
[PATCH] Display separators on tty menus with display table entries

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 75858 in the body.
You can then email your comments to 75858 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Display separators on tty menus with display table entries
Date: Sun, 26 Jan 2025 13:12:03 +0100

[Message part 1 (text/plain, inline)]

Tags: patch

This completes a point I left open last time I changed tty menu
separators: displaying separators with nicer Unicode chars.
Which can be activated with standard-display-unicode-special-glyphs.

In GNU Emacs 31.0.50 (build 22, aarch64-apple-darwin24.2.0) of
 2025-01-26 built on pro2
Repository revision: cdd32a73f8029102252ebb33fa42dbdec399969a
Repository branch: cl-packages
System Description:  macOS 15.2

Configured using:
 'configure --without-ns --cache-file
 /var/folders/1d/k_6t25f94sl83szqbf8gpkrh0000gn/T//config.cache.cl-packages
 --with-native-compilation --with-mps=yes CC=clang
 'CFLAGS=-Wgnu-imaginary-constant -Wunused-result -g -F
 /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks
 -Wno-ignored-attributes -Wno-flag-enum -Wno-missing-method-return-type
 -Wno-variadic-macros -Wno-strict-prototypes -Wno-availability
 -Wno-nullability-completeness' --prefix=/Users/gerd/.local'

[0001-Display-separators-on-tty-menus-with-display-table-e.patch (text/patch, attachment)]

Message #8 received at 75858 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Gerd Möllmann <gerd.moellmann <at> gmail.com>
Cc: 75858 <at> debbugs.gnu.org
Subject: Re: bug#75858: [PATCH] Display separators on tty menus with display
 table entries
Date: Sun, 26 Jan 2025 14:39:11 +0200

> From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
> Date: Sun, 26 Jan 2025 13:12:03 +0100
> 
> This completes a point I left open last time I changed tty menu
> separators: displaying separators with nicer Unicode chars.
> Which can be activated with standard-display-unicode-special-glyphs.

Thanks.  I think this needs to be documented in the ELisp manual and
in NEWS.

>  (defun display-table-slot (display-table slot)
>    "Return the value of the extra slot in DISPLAY-TABLE named SLOT.
> -SLOT may be a number from 0 to 11 inclusive, or a slot name (symbol).
> +SLOT may be a number from 0 to 17 inclusive, or a slot name (symbol).
>  Valid symbols are `truncation', `wrap', `escape', `control',
>  `selective-display', `vertical-border', `box-vertical',
> -`box-horizontal', `box-down-right', `box-down-left', `box-up-right',
> -and `box-up-left'."
> +`box-horizontal', `box-down-right', `box-down-right', `box-up-left',
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
One of these should probably be box-down-left?

> +`box-double-vertical',`box-double-horizontal', `box-double-down-right',
> +`box-double-down-right', `box-double-up-left',"

Same here?  And what about box-up-right and box-double-up-right?

>  (defun set-display-table-slot (display-table slot value)
>    "Set the value of the extra slot in DISPLAY-TABLE named SLOT to VALUE.
> -SLOT may be a number from 0 to 11 inclusive, or a name (symbol).
> +SLOT may be a number from 0 to 17 inclusive, or a name (symbol).
>  Valid symbols are `truncation', `wrap', `escape', `control',
> -`selective-display',  `vertical-border', `box-vertical',
> -`box-horizontal', `box-down-right', `box-down-left', `box-up-right',
> -and `box-up-left'."
> +`selective-display', `vertical-border', `box-vertical',
> +`box-horizontal', `box-down-right', `box-down-right', `box-up-left',
> +`box-double-vertical',`box-double-horizontal', `box-double-down-right',
> +`box-double-down-right', `box-double-up-left',"

Same here.

> +/* Return the character to be used for displaying a tty menu separator.
> +   C is the character to be used by default. BOX is the display table
                                              ^^
Two spaces there.

Message #11 received at 75858 <at> debbugs.gnu.org (full text, mbox):

From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 75858 <at> debbugs.gnu.org
Subject: Re: bug#75858: [PATCH] Display separators on tty menus with display
 table entries
Date: Sun, 26 Jan 2025 15:13:25 +0100

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> This completes a point I left open last time I changed tty menu
>> separators: displaying separators with nicer Unicode chars.
>> Which can be activated with standard-display-unicode-special-glyphs.
>
> Thanks.  I think this needs to be documented in the ELisp manual and
> in NEWS.

Thanks, please find patch for doc strings and C comment attached. I'll
send another one for NEWS and Elisp later.

[0001-Fix-doc-strings-and-C-comment.patch (text/x-patch, attachment)]

Message #14 received at 75858 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Gerd Möllmann <gerd.moellmann <at> gmail.com>
Cc: 75858 <at> debbugs.gnu.org
Subject: Re: bug#75858: [PATCH] Display separators on tty menus with display
 table entries
Date: Sun, 26 Jan 2025 16:55:09 +0200

> From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
> Cc: 75858 <at> debbugs.gnu.org
> Date: Sun, 26 Jan 2025 15:13:25 +0100
> 
> Thanks, please find patch for doc strings and C comment attached. I'll
> send another one for NEWS and Elisp later.

Thanks.

> --- a/lisp/disp-table.el
> +++ b/lisp/disp-table.el
> @@ -67,9 +67,10 @@ display-table-slot
>  SLOT may be a number from 0 to 17 inclusive, or a slot name (symbol).
>  Valid symbols are `truncation', `wrap', `escape', `control',
>  `selective-display', `vertical-border', `box-vertical',
> -`box-horizontal', `box-down-right', `box-down-right', `box-up-left',
> -`box-double-vertical',`box-double-horizontal', `box-double-down-right',
> -`box-double-down-right', `box-double-up-left',"
> +`box-horizontal', `box-down-right', `box-down-left', `box-up-right',
> +`box-up-left',`box-double-vertical',`box-double-horizontal',
> +`box-double-down-right', `box-double-down-left',
> +`box-double-down-left',`box-double-up-left',"

box-double-down-left is mentioned twice, box-double-up-right
missing.

> @@ -82,9 +83,10 @@ set-display-table-slot
>  SLOT may be a number from 0 to 17 inclusive, or a name (symbol).
>  Valid symbols are `truncation', `wrap', `escape', `control',
>  `selective-display', `vertical-border', `box-vertical',
> -`box-horizontal', `box-down-right', `box-down-right', `box-up-left',
> -`box-double-vertical',`box-double-horizontal', `box-double-down-right',
> -`box-double-down-right', `box-double-up-left',"
> +`box-horizontal', `box-down-right', `box-down-left', `box-up-right',
> +`box-up-left',`box-double-vertical',`box-double-horizontal',
> +`box-double-down-right', `box-double-down-left',
> +`box-double-down-left',`box-double-up-left',"

Same.

> @@ -177,8 +179,9 @@ describe-current-display-table
>  (defun standard-display-unicode-special-glyphs ()
>    "Display some glyps using Unicode characters.
>  The glyphs being changed by this function are `vertical-border',
> -`box-vertical', `box-horizontal', `box-down-right', `box-down-left',
> -`box-up-right', and `box-up-left'."
> +`box-vertical',`box-horizontal', `box-down-right', `box-down-right',
> +`box-up-left',`box-double-vertical',`box-double-horizontal',
> +`box-double-down-right',`box-double-down-right', `box-double-up-left',"

Duplicate box-down-right, box-up-right and box-down-left missing.
Duplicate box-double-down-right, box-double-down-left and
box-double-up-right missing.

Message #17 received at 75858 <at> debbugs.gnu.org (full text, mbox):

From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 75858 <at> debbugs.gnu.org
Subject: Re: bug#75858: [PATCH] Display separators on tty menus with display
 table entries
Date: Sun, 26 Jan 2025 16:06:42 +0100

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

> box-double-down-left is mentioned twice, box-double-up-right
> missing.

Please find fixes for these + NEWS + Elisp manual attached.

[0001-Info-manual-NEWS-and-further-doc-string-fixes.patch (text/x-patch, attachment)]

Message #20 received at 75858 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Gerd Möllmann <gerd.moellmann <at> gmail.com>
Cc: 75858 <at> debbugs.gnu.org
Subject: Re: bug#75858: [PATCH] Display separators on tty menus with display
 table entries
Date: Sun, 26 Jan 2025 17:34:20 +0200

> From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
> Cc: 75858 <at> debbugs.gnu.org
> Date: Sun, 26 Jan 2025 16:06:42 +0100
> 
> Please find fixes for these + NEWS + Elisp manual attached.

Thanks, feel free to install.

Message #23 received at 75858 <at> debbugs.gnu.org (full text, mbox):

From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 75858 <at> debbugs.gnu.org
Subject: Re: bug#75858: [PATCH] Display separators on tty menus with display
 table entries
Date: Sun, 26 Jan 2025 16:45:36 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

> Thanks, feel free to install.

Thanks for the review! Pushed and closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.