GNU bug report logs - #7585
23.2.90; [PATCH] fix eshell-previous-matching-input

Previous Next

Package: emacs;

Reported by: Leo <sdl.web <at> gmail.com>

Date: Tue, 7 Dec 2010 18:46:01 UTC

Severity: normal

Tags: patch

Found in version 23.2.90

Done: Chong Yidong <cyd <at> stupidchicken.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Leo <sdl.web <at> gmail.com>
Cc: John Wiegley <jwiegley <at> gmail.com>, 7585 <at> debbugs.gnu.org
Subject: bug#7585: 23.2.90; [PATCH] fix eshell-previous-matching-input
Date: Mon, 13 Dec 2010 12:00:19 -0500

> There is a customisable variable eshell-hist-move-to-end when set to
> nil, point is not guaranteed to be located behind
> eshell-last-output-end. Thus blindly calling delete-region and
> insert-and-inherit will generate an error in that case.

The patch looks good as well, tho we usually prefer not to use `assert'
in this way (I'd keep assert for actual coding errors, so better use an
if test that then `signal's an error).


        Stefan
This bug report was last modified 14 years and 161 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.