From unknown Fri Jun 20 19:45:52 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#7585 <7585@debbugs.gnu.org> To: bug#7585 <7585@debbugs.gnu.org> Subject: Status: 23.2.90; [PATCH] fix eshell-previous-matching-input Reply-To: bug#7585 <7585@debbugs.gnu.org> Date: Sat, 21 Jun 2025 02:45:52 +0000 retitle 7585 23.2.90; [PATCH] fix eshell-previous-matching-input reassign 7585 emacs submitter 7585 Leo severity 7585 normal tag 7585 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 07 13:45:39 2010 Received: (at submit) by debbugs.gnu.org; 7 Dec 2010 18:45:39 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PQ2Xj-0005sN-87 for submit@debbugs.gnu.org; Tue, 07 Dec 2010 13:45:39 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PQ2Xh-0005s7-HD for submit@debbugs.gnu.org; Tue, 07 Dec 2010 13:45:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PQ2dM-0001z5-EU for submit@debbugs.gnu.org; Tue, 07 Dec 2010 13:51:33 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:53955) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PQ2dM-0001yo-4N for submit@debbugs.gnu.org; Tue, 07 Dec 2010 13:51:28 -0500 Received: from [140.186.70.92] (port=55244 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PQ2dG-0001tF-04 for bug-gnu-emacs@gnu.org; Tue, 07 Dec 2010 13:51:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PQ2d6-0001su-Qa for bug-gnu-emacs@gnu.org; Tue, 07 Dec 2010 13:51:21 -0500 Received: from mail-ew0-f43.google.com ([209.85.215.43]:34390) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PQ2d6-0001s5-M9 for bug-gnu-emacs@gnu.org; Tue, 07 Dec 2010 13:51:12 -0500 Received: by ewy22 with SMTP id 22so254363ewy.30 for ; Tue, 07 Dec 2010 10:51:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:x-debbugs-cc :date:message-id:mime-version:content-type; bh=EcpTzqXIA2LcUrDoFehvvV8NHeHqw9DvGjRvvW8c4NQ=; b=uaxa4LKf/Tfhj/K7aoQEiZ/wpYUQevj4VmfyHtXY01lN0Caz5PASyTkaiiwabbB9mD ED8mLi6R8QD6Jio68TTO9YEcjXYTSWx1BvtNyvjB7cyT5Sb3GCvUr3u5mb+ElxkhBU6C UTo35vE76BE3zy1NtjGjk7vr5p1IadsgwKmXg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:x-debbugs-cc:date:message-id:mime-version :content-type; b=l3gP1EBz3vLK0chX50h6Lcoz6t2cEq/qhGJP3Ly6lWci92x2pTgpdLdnCBqCklUqhX O8hpKDWDnuCaXyscfh+9QqcYCooij06RXB1yC2KVSfw+EAWSErMCXCmsK6Arns4AeRTW cuN6PxNpUljkC4gRlvVPwz8WQrVyiRLR99+b8= Received: by 10.216.141.213 with SMTP id g63mr724794wej.24.1291747871157; Tue, 07 Dec 2010 10:51:11 -0800 (PST) Received: from Victoria.local (cpc1-cmbg13-0-0-cust596.5-4.cable.virginmedia.com [86.9.122.85]) by mx.google.com with ESMTPS id 7sm3115851wet.0.2010.12.07.10.51.09 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 07 Dec 2010 10:51:10 -0800 (PST) From: Leo To: bug-gnu-emacs@gnu.org Subject: 23.2.90; [PATCH] fix eshell-previous-matching-input X-Debbugs-CC: John Wiegley Date: Tue, 07 Dec 2010 18:51:07 +0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -5.8 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.8 (-----) There is a customisable variable eshell-hist-move-to-end when set to nil, point is not guaranteed to be located behind eshell-last-output-end. Thus blindly calling delete-region and insert-and-inherit will generate an error in that case. diff --git a/lisp/eshell/em-hist.el b/lisp/eshell/em-hist.el index 45fe050..defaf5a 100644 --- a/lisp/eshell/em-hist.el +++ b/lisp/eshell/em-hist.el @@ -837,6 +837,8 @@ With prefix argument N, search for Nth previous match. If N is negative, find the next or Nth next match." (interactive (eshell-regexp-arg "Previous input matching (regexp): ")) (setq arg (eshell-search-arg arg)) + (assert (<= eshell-last-output-end (point)) + nil "Point not located after prompt") (let ((pos (eshell-previous-matching-input-string-position regexp arg))) ;; Has a match been found? (if (null pos) From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 13 11:54:10 2010 Received: (at 7585) by debbugs.gnu.org; 13 Dec 2010 16:54:10 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PSBf8-0001Z0-Db for submit@debbugs.gnu.org; Mon, 13 Dec 2010 11:54:10 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PSBf6-0001Yq-KH for 7585@debbugs.gnu.org; Mon, 13 Dec 2010 11:54:09 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AtUJAGffBU1FpZA//2dsb2JhbACiaIEcecJDhUoEhGSOBQ X-IronPort-AV: E=Sophos;i="4.59,336,1288584000"; d="scan'208";a="85311941" Received: from 69-165-144-63.dsl.teksavvy.com (HELO pastel.home) ([69.165.144.63]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 13 Dec 2010 12:00:19 -0500 Received: by pastel.home (Postfix, from userid 20848) id 6816658CC2; Mon, 13 Dec 2010 12:00:19 -0500 (EST) From: Stefan Monnier To: Leo Subject: Re: bug#7585: 23.2.90; [PATCH] fix eshell-previous-matching-input Message-ID: References: Date: Mon, 13 Dec 2010 12:00:19 -0500 In-Reply-To: (Leo's message of "Tue, 07 Dec 2010 18:51:07 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 7585 Cc: John Wiegley , 7585@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > There is a customisable variable eshell-hist-move-to-end when set to > nil, point is not guaranteed to be located behind > eshell-last-output-end. Thus blindly calling delete-region and > insert-and-inherit will generate an error in that case. The patch looks good as well, tho we usually prefer not to use `assert' in this way (I'd keep assert for actual coding errors, so better use an if test that then `signal's an error). Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 13 13:24:58 2010 Received: (at 7585) by debbugs.gnu.org; 13 Dec 2010 18:24:58 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PSD4z-0003Yc-My for submit@debbugs.gnu.org; Mon, 13 Dec 2010 13:24:58 -0500 Received: from mail-wy0-f172.google.com ([74.125.82.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PSD4x-0003YQ-Rb for 7585@debbugs.gnu.org; Mon, 13 Dec 2010 13:24:56 -0500 Received: by wyf23 with SMTP id 23so6436583wyf.3 for <7585@debbugs.gnu.org>; Mon, 13 Dec 2010 10:31:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:references :date:in-reply-to:message-id:user-agent:mime-version:content-type; bh=UK8pj/5fOHdvFto9OFnC+JK9P0aTpo/sEMw4hXev9A0=; b=rtSPpAdOK2CC7Oz1D67SHfouHm7DqiTWj2y3MC07xwD6w+NutS7vnfgrWq91hdI0c3 JrIvRzhyRzUtUyWKtujzomD+NzlZ6Q5PPpX0NVORnNqQSxRsRePI40qjztmEKzBp/en9 U5If+6TLAkr26nsLOVIm2dtNMqwzOKH0OVMi0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=Ol8RnqWKNVhfAql3r2AxcZ6qxYRRs68vjzf5FkHbsK7miXFxsuF9z15xfbia5BNlzB DANWNvuL/hCgZdwKXY/zq25rlu6nE2rSggyi1fm77oXOTIWIr36DLtx3dxmZY07BDVrp LWVAQAZelhYRDxeRjJoxLsZCJscRyw8VMRuLI= Received: by 10.216.167.132 with SMTP id i4mr4997609wel.1.1292265066794; Mon, 13 Dec 2010 10:31:06 -0800 (PST) Received: from Victoria.local (cpc1-cmbg13-0-0-cust596.5-4.cable.virginmedia.com [86.9.122.85]) by mx.google.com with ESMTPS id o33sm2350564wej.13.2010.12.13.10.31.04 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 13 Dec 2010 10:31:05 -0800 (PST) From: Leo To: Stefan Monnier Subject: Re: bug#7585: 23.2.90; [PATCH] fix eshell-previous-matching-input References: Date: Mon, 13 Dec 2010 18:31:00 +0000 In-Reply-To: (Stefan Monnier's message of "Mon, 13 Dec 2010 12:00:19 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2.91 (Mac OS X 10.6.5) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.6 (----) X-Debbugs-Envelope-To: 7585 Cc: John Wiegley , 7585@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) On 2010-12-13 17:00 +0000, Stefan Monnier wrote: >> There is a customisable variable eshell-hist-move-to-end when set to >> nil, point is not guaranteed to be located behind >> eshell-last-output-end. Thus blindly calling delete-region and >> insert-and-inherit will generate an error in that case. > > The patch looks good as well, tho we usually prefer not to use `assert' > in this way (I'd keep assert for actual coding errors, so better use an > if test that then `signal's an error). Would something like the following acceptable? Thanks. Leo 2010-12-13 Leo * eshell/em-hist.el (eshell-previous-matching-input): Check point is located after eshell prompt in case `eshell-hist-move-to-end' is nil. lisp/eshell/em-hist.el | 22 ++++++++++++---------- 1 files changed, 12 insertions(+), 10 deletions(-) diff --git a/lisp/eshell/em-hist.el b/lisp/eshell/em-hist.el index 45fe050..47e0b2b 100644 --- a/lisp/eshell/em-hist.el +++ b/lisp/eshell/em-hist.el @@ -837,16 +837,18 @@ With prefix argument N, search for Nth previous match. If N is negative, find the next or Nth next match." (interactive (eshell-regexp-arg "Previous input matching (regexp): ")) (setq arg (eshell-search-arg arg)) - (let ((pos (eshell-previous-matching-input-string-position regexp arg))) - ;; Has a match been found? - (if (null pos) - (error "Not found") - (setq eshell-history-index pos) - (unless (minibuffer-window-active-p (selected-window)) - (message "History item: %d" (- (ring-length eshell-history-ring) pos))) - ;; Can't use kill-region as it sets this-command - (delete-region eshell-last-output-end (point)) - (insert-and-inherit (eshell-get-history pos))))) + (if (<= eshell-last-output-end (point)) + (let ((pos (eshell-previous-matching-input-string-position regexp arg))) + ;; Has a match been found? + (if (null pos) + (error "Not found") + (setq eshell-history-index pos) + (unless (minibuffer-window-active-p (selected-window)) + (message "History item: %d" (- (ring-length eshell-history-ring) pos))) + ;; Can't use kill-region as it sets this-command + (delete-region eshell-last-output-end (point)) + (insert-and-inherit (eshell-get-history pos)))) + (message "Point not located after prompt"))) (defun eshell-next-matching-input (regexp arg) "Search forwards through input history for match for REGEXP. -- 1.7.3 From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 13 15:36:29 2010 Received: (at 7585) by debbugs.gnu.org; 13 Dec 2010 20:36:29 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PSF8G-0006Sy-RR for submit@debbugs.gnu.org; Mon, 13 Dec 2010 15:36:29 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PSF8F-0006Sm-W4 for 7585@debbugs.gnu.org; Mon, 13 Dec 2010 15:36:28 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AtUJACIUBk1FpZA//2dsb2JhbACibIEcecNlhUoEhGSOBQ X-IronPort-AV: E=Sophos;i="4.59,337,1288584000"; d="scan'208";a="85340259" Received: from 69-165-144-63.dsl.teksavvy.com (HELO pastel.home) ([69.165.144.63]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 13 Dec 2010 15:42:39 -0500 Received: by pastel.home (Postfix, from userid 20848) id 3505558CC2; Mon, 13 Dec 2010 15:42:39 -0500 (EST) From: Stefan Monnier To: Leo Subject: Re: bug#7585: 23.2.90; [PATCH] fix eshell-previous-matching-input Message-ID: References: Date: Mon, 13 Dec 2010 15:42:39 -0500 In-Reply-To: (Leo's message of "Mon, 13 Dec 2010 18:31:00 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 7585 Cc: John Wiegley , 7585@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > Would something like the following acceptable? Thanks. Leo No, don't use `message': this is a real error, use `signal' or `error'. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 14 01:06:54 2010 Received: (at 7585) by debbugs.gnu.org; 14 Dec 2010 06:06:55 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PSO2I-0002lG-4y for submit@debbugs.gnu.org; Tue, 14 Dec 2010 01:06:54 -0500 Received: from mail-ww0-f46.google.com ([74.125.82.46]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PSO2G-0002l3-13 for 7585@debbugs.gnu.org; Tue, 14 Dec 2010 01:06:52 -0500 Received: by wwj40 with SMTP id 40so240372wwj.15 for <7585@debbugs.gnu.org>; Mon, 13 Dec 2010 22:13:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:references :date:in-reply-to:message-id:user-agent:mime-version:content-type; bh=W0hStAfG0IaSdF59VGXZ8vd+tnPkrBfGcraF9ek6AZ4=; b=exIyUNe+N5AdRYkEQN8ZZqEhNots8QX8JSpnBRzQLSczV1jrXxFha0uucLpocc8dbK WIt2fZejyXHM37wyZpbvX/USCCxuz1faFkZaHs/MEjzVuPQotRRYEH1jjli2VMueXeGM Ia7bEK6KLjyZnvW8bqOSo7602mAvehLmfCoek= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=b9l2U5hTlv/nCZwdCS7mXxgJM2ujxSu5kIsY5XognFg0WhnbQjXehGujFwik+maugH QQzo5IC1tf06hDtNh06Kv6R4lzpiywpfFDwAx7izEjgrlF6NF3kVboUPw/35R4Rr6/1b Htt4H0AHJIK/TcbCJ7e8ykJfK/wBvghGB+8ek= Received: by 10.216.185.2 with SMTP id t2mr1044007wem.70.1292307184088; Mon, 13 Dec 2010 22:13:04 -0800 (PST) Received: from Victoria.local (cpc1-cmbg13-0-0-cust596.5-4.cable.virginmedia.com [86.9.122.85]) by mx.google.com with ESMTPS id m50sm1286010wek.8.2010.12.13.22.13.02 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 13 Dec 2010 22:13:02 -0800 (PST) From: Leo To: Stefan Monnier Subject: Re: bug#7585: 23.2.90; [PATCH] fix eshell-previous-matching-input References: Date: Tue, 14 Dec 2010 06:13:00 +0000 In-Reply-To: (Stefan Monnier's message of "Mon, 13 Dec 2010 15:42:39 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2.91 (Mac OS X 10.6.5) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.6 (----) X-Debbugs-Envelope-To: 7585 Cc: John Wiegley , 7585@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) On 2010-12-13 20:42 +0000, Stefan Monnier wrote: >> Would something like the following acceptable? Thanks. Leo > > No, don't use `message': this is a real error, use `signal' or `error'. > > > Stefan OK. Here is the whole thing with the change of `message' to `error'. Without this patch, one usually gets an error like "Text is read-only" when M-n/p. So the error is obscure. The patch makes the error more useful. 2010-12-13 Leo * eshell/em-hist.el (eshell-previous-matching-input): Check point is located after eshell prompt in case `eshell-hist-move-to-end' is nil. lisp/eshell/em-hist.el | 22 ++++++++++++---------- 1 files changed, 12 insertions(+), 10 deletions(-) diff --git a/lisp/eshell/em-hist.el b/lisp/eshell/em-hist.el index 45fe050..47e0b2b 100644 --- a/lisp/eshell/em-hist.el +++ b/lisp/eshell/em-hist.el @@ -837,16 +837,18 @@ With prefix argument N, search for Nth previous match. If N is negative, find the next or Nth next match." (interactive (eshell-regexp-arg "Previous input matching (regexp): ")) (setq arg (eshell-search-arg arg)) - (let ((pos (eshell-previous-matching-input-string-position regexp arg))) - ;; Has a match been found? - (if (null pos) - (error "Not found") - (setq eshell-history-index pos) - (unless (minibuffer-window-active-p (selected-window)) - (message "History item: %d" (- (ring-length eshell-history-ring) pos))) - ;; Can't use kill-region as it sets this-command - (delete-region eshell-last-output-end (point)) - (insert-and-inherit (eshell-get-history pos))))) + (if (<= eshell-last-output-end (point)) + (let ((pos (eshell-previous-matching-input-string-position regexp arg))) + ;; Has a match been found? + (if (null pos) + (error "Not found") + (setq eshell-history-index pos) + (unless (minibuffer-window-active-p (selected-window)) + (message "History item: %d" (- (ring-length eshell-history-ring) pos))) + ;; Can't use kill-region as it sets this-command + (delete-region eshell-last-output-end (point)) + (insert-and-inherit (eshell-get-history pos)))) + (error "Point not located after prompt"))) (defun eshell-next-matching-input (regexp arg) "Search forwards through input history for match for REGEXP. -- 1.7.3 From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 14 14:40:28 2010 Received: (at 7585) by debbugs.gnu.org; 14 Dec 2010 19:40:28 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PSajc-0006u6-MZ for submit@debbugs.gnu.org; Tue, 14 Dec 2010 14:40:28 -0500 Received: from pruche.dit.umontreal.ca ([132.204.246.22]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PSaja-0006tp-GZ for 7585@debbugs.gnu.org; Tue, 14 Dec 2010 14:40:27 -0500 Received: from alfajor.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id oBEJkct2026168; Tue, 14 Dec 2010 14:46:39 -0500 Received: by alfajor.home (Postfix, from userid 20848) id 7A3536408D; Tue, 14 Dec 2010 14:46:38 -0500 (EST) From: Stefan Monnier To: Leo Subject: Re: bug#7585: 23.2.90; [PATCH] fix eshell-previous-matching-input Message-ID: References: Date: Tue, 14 Dec 2010 14:46:38 -0500 In-Reply-To: (Leo's message of "Tue, 14 Dec 2010 06:13:00 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Level: X-NAI-Spam-Score: 0.7 X-NAI-Spam-Rules: 2 Rules triggered SUBJ_HAS_UNIQ_ID=0.7, RV3709=0 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 7585 Cc: John Wiegley , 7585@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > OK. Here is the whole thing with the change of `message' to `error'. Looks good, please install it, Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 17 05:58:46 2010 Received: (at 7585) by debbugs.gnu.org; 17 Dec 2010 10:58:47 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PTY1O-0005n1-AL for submit@debbugs.gnu.org; Fri, 17 Dec 2010 05:58:46 -0500 Received: from vm-emlprdomr-03.its.yale.edu ([130.132.50.144]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PTY12-0005mH-23 for 7585@debbugs.gnu.org; Fri, 17 Dec 2010 05:58:44 -0500 Received: from furball (bb121-6-218-24.singnet.com.sg [121.6.218.24]) (authenticated bits=0) by vm-emlprdomr-03.its.yale.edu (8.14.4/8.14.4) with ESMTP id oBHB4fkn009208 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 17 Dec 2010 06:04:44 -0500 Received: by furball (Postfix, from userid 1000) id 19DD8161F11; Fri, 17 Dec 2010 06:04:40 -0500 (EST) From: Chong Yidong To: Leo Subject: Re: bug#7585: 23.2.90; [PATCH] fix eshell-previous-matching-input References: Date: Fri, 17 Dec 2010 19:04:39 +0800 In-Reply-To: (Leo's message of "Tue, 14 Dec 2010 06:13:00 +0000") Message-ID: <87fwtw3bjs.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.144 X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 7585 Cc: John Wiegley , 7585@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.8 (--) Leo writes: > OK. Here is the whole thing with the change of `message' to `error'. > > Without this patch, one usually gets an error like "Text is read-only" > when M-n/p. So the error is obscure. The patch makes the error more > useful. Thanks; committed. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 17 05:58:46 2010 Received: (at control) by debbugs.gnu.org; 17 Dec 2010 10:58:47 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PTY1O-0005n4-IX for submit@debbugs.gnu.org; Fri, 17 Dec 2010 05:58:46 -0500 Received: from vm-emlprdomr-04.its.yale.edu ([130.132.50.145]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PTY1D-0005mV-25 for control@debbugs.gnu.org; Fri, 17 Dec 2010 05:58:45 -0500 Received: from furball (bb121-6-218-24.singnet.com.sg [121.6.218.24]) (authenticated bits=0) by vm-emlprdomr-04.its.yale.edu (8.14.4/8.14.4) with ESMTP id oBHB4rdm030682 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Fri, 17 Dec 2010 06:04:55 -0500 Received: by furball (Postfix, from userid 1000) id D29C3161F11; Fri, 17 Dec 2010 06:04:51 -0500 (EST) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 7585 Date: Fri, 17 Dec 2010 19:04:51 +0800 Message-ID: <8762usirsc.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.145 X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.8 (--) close 7585 thanks From unknown Fri Jun 20 19:45:52 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 14 Jan 2011 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator