GNU bug report logs - #75847
[PATCH 0/2] Reinstate auto-configuration for GNOME Boxes.

Previous Next

Full log

Message #19 received at 75847-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 75847-done <at> debbugs.gnu.org
Subject: Re: [PATCH 1/2] services/desktop: Use transitively propagated GNOME
 packages for polkit/udev.
Date: Mon, 27 Jan 2025 02:05:30 +0900

Hi Liliana,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

[...]

>> +(define* (gnome-profile config #:key transitive?)
>> +  "Return the list of the packages specified in CONFIG.  When
>> TRANSITIVE? is
>> +#t, also include their transitive propagated inputs."
>> +  (define gnome-packages
>> +    (append
>> +     (gnome-desktop-configuration-core-services config)
>> +     (gnome-desktop-configuration-shell config)
>> +     (gnome-desktop-configuration-utilities config)
>> +     (let ((gnome-meta (gnome-desktop-configuration-gnome config)))
>> +       (if (maybe-value-set? gnome-meta)
>> +           (begin
>> +             (warning
>> +              (gnome-desktop-configuration-source-location config)
>> +              (G_ "Using a meta-package for gnome-desktop is
>> discouraged.~%"))
>> +             (list gnome-meta))
>> +           (list)))
>> +     (gnome-desktop-configuration-extra-packages config)))
>> +  (if transitive?
>> +      (append gnome-packages
>> +              (append-map (compose (cut map second <>) ;discard
>> labels
>> +                                   package-transitive-propagated-
>> inputs)
>> +                          gnome-packages))
> There is a small bug in here in that packages with outputs will have
> said output ignored.  This typically doesn't matter, but for the sake
> of completeness, something like
>   (match-lambda
>     ((_ pkg) pkg)
>     ((_ pkg out) (list pkg out)))
> preserves the output.

Well observed.  I've used something similar to the above, but using
gexp-input objects so that lowering the gexp would result in store paths
compatible with the 'search-path-as-list' for example.

I added Reviewed-by git trailers to credit your review and pushed, after
testing I could successfully reconfigure my system with the change.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.