GNU bug report logs - #75842
Adding sfwbar package

Previous Next

To reply to this bug, email your comments to 75842 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Josep Bigorra <jjbigorra <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: Adding sfwbar package
Date: Sat, 25 Jan 2025 22:32:50 +0100

[Message part 1 (text/plain, inline)]

Hi all I am working on making a subset of Guix setup which is
accessible to all users, as part of the SSS project:
https://codeberg.org/jjba23/sss

For this, I want to use sfwbar (https://github.com/LBCrion/sfwbar),
which is a nice Wayland taskbar, focused on floating window
compositors, like labwc. I think a lot of people will benefit from
having this package in Guix.

I have made a start, and the build phase succeeds, but am at a loss at
what is going wrong, could I get a hand?
The project uses meson to build so should make it easier for Guix.
I get an error like: RUNPATH validation failed and the
validate-runpath phase fails.

I am attaching the build logs and the PoC package definition,
Best,
Joe

[sfwbar.scm (text/x-scheme, attachment)]

[sfwbar-error-log.drv (application/octet-stream, attachment)]

Message #8 received at 75842 <at> debbugs.gnu.org (full text, mbox):

From: Josep Bigorra <jjbigorra <at> gmail.com>
To: 75842 <at> debbugs.gnu.org
Subject: New error message, now something with ninja?
Date: Sat, 25 Jan 2025 23:43:52 +0100

Got a bit further now, but now i get error with ninja?

```

(define-public swfbar
  (package
    (name "sfwbar")
    (version "v1.0_beta16")
    (source
     (origin
       (method git-fetch)
       (uri (git-reference
             (url "https://github.com/LBCrion/sfwbar.git")
             (commit "v1.0_beta16")))
       (sha256
        (base32 "1jgd33fn5x213dg4fry35qg16yqg3c71a2psfwl6fsz5fp1iphcc"))))
    (inputs (list pkg-config (specification->package "gtk+@3.24.41")
json-c gtk-layer-shell))
    (build-system meson-build-system)
    (arguments
     (list
      #:glib-or-gtk? #t
      #:configure-flags
      #~(list (string-append #$output "/lib"))))
    (synopsis "Flexible Wayland taskbar focused on stacking layout
compositors.")
    (description
     "SFWBar (S* Floating Window Bar) is a flexible taskbar
application for Wayland compositors, designed with a stacking layout
in mind. Originally developed for Sway, SFWBar will work with any
Wayland compositor supporting layer shell protocol, the taskbar and
window switcher functionality shall work with any compositor
supporting foreign top-level protocol, but the pager, and window
placement functionality require sway (or at least i3 IPC support).")
    (home-page "https://github.com/LBCrion/sfwbar")
    (license license:gpl3+)))

```

Message #11 received at 75842 <at> debbugs.gnu.org (full text, mbox):

From: Josep Bigorra <jjbigorra <at> gmail.com>
To: 75842 <at> debbugs.gnu.org
Subject: ok now it seems like it's calling the wrong meson target?
Date: Sun, 26 Jan 2025 00:17:19 +0100

[Message part 1 (text/plain, inline)]

Hi, please see proper patch attached now, and new error message, yay,
sfwbar is undefined

Thanks in advance

[0001-adding-the-sfwbar-package-to-wm.scm.patch (text/x-patch, attachment)]

[sfwbar-error-log.drv (application/octet-stream, attachment)]

Message #14 received at 75842 <at> debbugs.gnu.org (full text, mbox):

From: Ian Eure <ian <at> retrospec.tv>
To: 75842 <at> debbugs.gnu.org, Josep Bigorra <jjbigorra <at> gmail.com>
Subject: Re: Adding sfwbar package
Date: Wed, 29 Jan 2025 20:36:18 -0800

Hi Josep,

Josep Bigorra wrote 4 days ago:
> ok now it seems like it's calling the wrong meson target?
> Hi, please see proper patch attached now, and new error message, 
> yay, sfwbar is undefined
>

I believe the issue is that you need to set the #:build-type 
argument to meson-build-system.  Take a look at (guix)Build 
Systems in the Guix manual, and compare that with the sfwbar 
README’s build from source instructions.


> ---
>  gnu/packages/wm.scm | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> Toggle diff (39 lines)
> diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
> index cc5da92eef..6875b47c17 100644
> --- a/gnu/packages/wm.scm
> +++ b/gnu/packages/wm.scm
> @@ -2486,6 +2486,32 @@ (define-public waybar-experimental
>                    #$flags))))
>        (synopsis "Waybar with experimental features"))))
>
> +(define-public swfbar
> +  (package
> +    (name "sfwbar")
> +    (version "v1.0_beta16")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/LBCrion/sfwbar.git")
> +             (commit "v1.0_beta16")))
>

Should be:

   (commit version)))

...to keep the source/package versions from drifting.

> +       (sha256
> +        (base32 
> "1jgd33fn5x213dg4fry35qg16yqg3c71a2psfwl6fsz5fp1iphcc"))))
> +    (native-inputs (list pkg-config))
> +    (inputs (list libmpdclient mpd pulseaudio alsa-lib 
> python-docutils (specification->package "gtk+@3.24.41") json-c 
> gtk-layer-shell))
>

Please directly reference the variable holding the needed gtk 
version instead of using specification->package to look it up.

This should also be run through `guix style' and pass `guix lint'. 
You’ll likely need to fix up some things manually that `guix 
style' doesn’t handle.

Thanks for taking this on!

 -- Ian

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.