GNU bug report logs - #75828
[PATCH] Correct make-frame docstring vis-a-vis make_frame.c

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ship Mints <shipmints <at> gmail.com>
Subject: bug#75828: closed (Re: bug#75828: [PATCH] Correct make-frame
 docstring vis-a-vis make_frame.c)
Date: Thu, 13 Feb 2025 10:43:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#75828: [PATCH] Correct make-frame docstring vis-a-vis make_frame.c

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 75828 <at> debbugs.gnu.org.

-- 
75828: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=75828
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Stefan Kangas <stefankangas <at> gmail.com>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 75828-done <at> debbugs.gnu.org,
 shipmints <at> gmail.com
Subject: Re: bug#75828: [PATCH] Correct make-frame docstring vis-a-vis
 make_frame.c
Date: Thu, 13 Feb 2025 02:42:37 -0800

Version: 31.1

martin rudalics <rudalics <at> gmx.at> writes:

>   I see that dc6b3560e56 was installed.  Does that conclude this bug or is
>> there more to do here?
>
> It concludes the bug AFAIAC.

OK, thanks.  Closing.

[Message part 3 (message/rfc822, inline)]

From: Ship Mints <shipmints <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Correct make-frame docstring vis-a-vis make_frame.c
Date: Sat, 25 Jan 2025 09:12:50 -0500

[Message part 4 (text/plain, inline)]

make-frame's docstring says "creates and returns a new frame, displaying
the current buffer." This is not true if the buffer is considered
conventionally hidden.

struct frame *
make_frame (bool mini_p)
...
    Lisp_Object buf = Fcurrent_buffer ();
    /* If current buffer is hidden, try to find another one.  */
    if (BUFFER_HIDDEN_P (XBUFFER (buf)))
      buf = other_buffer_safely (buf);

I'd prefer to have an option to be literal and allow users to make a frame
on a hidden current buffer. I might submit this idea under a different bug
for discussion.

-Stephane

[Message part 5 (text/html, inline)]

[0001-make-frame-docstring-matches-frame.c-if-current-buff.patch (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.