GNU bug report logs - #75826
[PATCH] New variable 'bookmark-bmenu-type-column-width'

Previous Next

Package: emacs;

Reported by: Ship Mints <shipmints <at> gmail.com>

Date: Sat, 25 Jan 2025 13:49:01 UTC

Severity: normal

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #11 received at 75826 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 75826 <at> debbugs.gnu.org
Subject: Re: bug#75826: [PATCH] New variable 'bookmark-bmenu-type-column-width'
Date: Mon, 27 Jan 2025 11:20:25 -0500
[Message part 1 (text/plain, inline)]
Thank you for the feedback. Revised patch attached.

On Sun, Jan 26, 2025 at 6:30 AM Robert Pluim <rpluim <at> gmail.com> wrote:

> >>>>> On Sat, 25 Jan 2025 08:45:53 -0500, Ship Mints <shipmints <at> gmail.com>
> said:
>
>     Ship> *** New variable 'bookmark-bmenu-type-column-width'.
>     Ship> This variable allows a user to control the width of the type
> column
>     Ship> on the bookmark menu 'bookmark-bmenu-list'. The default value is
> 8
>     Ship> which is backwards compatible.
>
>     Ship> I marked this new variable as of 31.1 but could also be for 30.2.
>
> If itʼs a defcustom we call it a "user option". Putting on my
> wordsmithing hat:
>
> *** New user option 'bookmark-bmenu-type-column-width'.
> Specifies the width of the type column in the bookmark menu shown by
> 'bookmark-bmenu-list'. Default value is 8, which is backwards
> compatible.
>
>
>     Ship> Rationale: In one package I co-maintain, we have custom bookmark
> handlers
>     Ship> with appropriate properties set. The limit of 8 characters for
> display in
>     Ship> the bookmark menu can lead to cumbersome naming for handler
> abbreviations.
>
>     Ship> -Stephane
>     Ship> From b4cc1e055755ceaaa348776f1c2fe40b67f02511 Mon Sep 17
> 00:00:00 2001
>     Ship> From: shipmints <shipmints <at> gmail.com>
>     Ship> Date: Sat, 25 Jan 2025 08:36:12 -0500
>     Ship> Subject: [PATCH] Add new custom variable
> bookmark-bmenu-type-column-width
>
>     Ship> This variable allows a user to control the width of the type
> column
>     Ship> on the bookmark menu 'bookmark-bmenu-list'. The default value is
> 8
>     Ship> which is backwards compatible.
>
>     Ship> * lisp/bookmark.el (bookmark-bmenu-mode):
>     Ship> Honor bookmark-bmenu-type-column-width when creating the
>     Ship> tabulated list.
>
> The commit message should mention the new defcustom.
>
> Robert
> --
>
[Message part 2 (text/html, inline)]
[0001-Add-new-user-option-bookmark-bmenu-type-column-width.patch (application/octet-stream, attachment)]

This bug report was last modified 109 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.