GNU bug report logs - #75825
[PATCH] New user option 'Buffer-menu-human-readable-size'

Previous Next

Package: emacs;

Reported by: Pengji Zhang <me <at> pengjiz.com>

Date: Sat, 25 Jan 2025 11:46:01 UTC

Severity: normal

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #16 received at 75825-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Pengji Zhang <me <at> pengjiz.com>
Cc: rpluim <at> gmail.com, 75825-done <at> debbugs.gnu.org
Subject: Re: bug#75825: [PATCH] New user option
 'Buffer-menu-human-readable-size'
Date: Sat, 01 Feb 2025 12:39:49 +0200
> Cc: 75825 <at> debbugs.gnu.org
> From: Pengji Zhang <me <at> pengjiz.com>
> Date: Mon, 27 Jan 2025 19:48:43 +0800
> 
> Thanks for the review!
> 
> Robert Pluim <rpluim <at> gmail.com> writes:
> 
> > As with #75495, "size" or "sizes", please pick one and only one.
> 
> I do not have a preference for this. So I updated the patch to use
> "sizes" consistently following your comment in #75495.
> 
> > When adding a new user option, please describe the default value. I
> > assume itʼs nil, but NEWS should tell me (especially as NEWS is often
> > read outside Emacs).
> 
> Added in the updated patch.

Thanks, installed on the master branch, and closing the bug.

Please in the future, once the bug number is known (as it always is
when you post a corrected version of a patch), mention the bug number
in the commit log message.  Otherwise, I have to add it manually, when
installing the patch.




This bug report was last modified 110 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.