From unknown Fri Jun 20 07:12:56 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#7582 <7582@debbugs.gnu.org> To: bug#7582 <7582@debbugs.gnu.org> Subject: Status: whitespace.el: whitespace-cleanup does not clean spaces before tabs Reply-To: bug#7582 <7582@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:12:56 +0000 retitle 7582 whitespace.el: whitespace-cleanup does not clean spaces before= tabs reassign 7582 emacs submitter 7582 Jeff Dairiki severity 7582 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 07 12:29:38 2010 Received: (at submit) by debbugs.gnu.org; 7 Dec 2010 17:29:39 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PQ1M1-0002RI-PK for submit@debbugs.gnu.org; Tue, 07 Dec 2010 12:29:38 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PQ1LI-0002PR-HI for submit@debbugs.gnu.org; Tue, 07 Dec 2010 12:28:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PQ1R0-0007yP-UK for submit@debbugs.gnu.org; Tue, 07 Dec 2010 12:34:39 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, T_DKIM_INVALID,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:39922) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PQ1R0-0007yE-G1 for submit@debbugs.gnu.org; Tue, 07 Dec 2010 12:34:38 -0500 Received: from [140.186.70.92] (port=59227 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PQ1Qv-00074q-AI for bug-gnu-emacs@gnu.org; Tue, 07 Dec 2010 12:34:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PQ1Qt-0007vp-CG for bug-gnu-emacs@gnu.org; Tue, 07 Dec 2010 12:34:33 -0500 Received: from postal.dairiki.org ([207.14.34.37]:50984) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PQ1Qs-0007vF-Uo for bug-gnu-emacs@gnu.org; Tue, 07 Dec 2010 12:34:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dairiki.org; s=alpha; h=Content-Type:MIME-Version:Message-ID:Subject:To:From:Date; bh=twtF8yuHveEzVWvrxuR2IPScSQR4mGHxiDX7vyWYWzg=; b=pFoW3CjIW2VkuGEwL2qpQcAJ2/YgcqVoimgjjnKMAC2FqFsu9dLF3AYbM0v7DPvv/SYr9KUGDo4SjwkxFUN3b54V+vy6YW8iIazbZiS4HDgE8Y0kYXa6vw8+jy93uj0ql20UPe0QRiOMeRlw8LnvR4/0YHMImP/9QLsHBPdOvD0=; Received: from hairball.dairiki.org ([2001:470:e812:8001:2e0:4cff:feb4:ed1d]) by postal.dairiki.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1PQ1Qp-0000JC-RQ for bug-gnu-emacs@gnu.org; Tue, 07 Dec 2010 09:34:27 -0800 Received: from dairiki by hairball.dairiki.org with local (Exim 4.69) (envelope-from ) id 1PQ1Qo-0007dP-Vf for bug-gnu-emacs@gnu.org; Tue, 07 Dec 2010 09:34:26 -0800 Date: Tue, 7 Dec 2010 09:34:26 -0800 From: Jeff Dairiki To: bug-gnu-emacs@gnu.org Subject: whitespace.el: whitespace-cleanup does not clean spaces before tabs Message-ID: <20101207173424.GA28668@dairiki.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Debbugs-CC: Vinicius Jose Latorre X-Face: {6O1D\TdUe"<&\;kXTT"~btYrzQQZV?7\]{h7Ga|uEB#/:2[5)~l3X2EV<.L]*}a6?Fc svg j2p(pk7A(&qf^bg!d6qc-Bu$Plb/ko!93KtAVhoX,RwYdgPBmd},TJOG%>.XgXYe[LO] =s9K^c#/q User-Agent: Mutt/1.5.18 (2008-05-17) X-Virus-Scanned: pass (message is clean) scanner=clamav; receiver=postal.dairiki.org X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 07 Dec 2010 12:29:28 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.0 (----) `whitespace-cleanup-region' in whitespace.el (version 13.1) does not clean up spaces before tabs if either: - `space-before-tab' is in `whitespace-style' and `indent-tabs-mode' non-nil - `space-before-tab::tab' is in `whitespace-style'. Here's a patch (on whitespace.el version 13.1) which fixes the problem for me. diff --git a/site-lisp/whitespace.el b/site-lisp/whitespace.el index a9fec09..5f5e822 100644 --- a/site-lisp/whitespace.el +++ b/site-lisp/whitespace.el @@ -1700,12 +1700,12 @@ documentation." (whitespace-replace-action (if whitespace-indent-tabs-mode 'tabify 'untabify) rstart rend whitespace-space-before-tab-regexp - (if whitespace-indent-tabs-mode 1 2))) + (if whitespace-indent-tabs-mode 0 2))) ;; ACTION: replace SPACEs before TAB by TABs. ((memq 'space-before-tab::tab whitespace-style) (whitespace-replace-action 'tabify rstart rend - whitespace-space-before-tab-regexp 1)) + whitespace-space-before-tab-regexp 0)) ;; ACTION: replace TABs by SPACEs. ((memq 'space-before-tab::space whitespace-style) (whitespace-replace-action Thanks for everything! Jeff From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 08 14:26:17 2010 Received: (at 7582) by debbugs.gnu.org; 8 Dec 2010 19:26:17 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PQPeb-0001bd-Df for submit@debbugs.gnu.org; Wed, 08 Dec 2010 14:26:17 -0500 Received: from mail-gw0-f44.google.com ([74.125.83.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PQPeZ-0001bQ-Dy for 7582@debbugs.gnu.org; Wed, 08 Dec 2010 14:26:15 -0500 Received: by gwj17 with SMTP id 17so1142528gwj.17 for <7582@debbugs.gnu.org>; Wed, 08 Dec 2010 11:32:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=ATGmLyaPKvm2tl1Np0Hjow67Fq5N9t5NAqSp8EiWCO0=; b=PKgAJtntXF+cG4pj63QMEdGn+fN7JHY6SscAiVtKT8AsYn06pO8GKspooVyW4DAM4q vdXtUiqhxX9wUlprIn7ztw/8fMr9IA+SvhQHb5MRIdqeuzs8vpRpusq3pIBv/gvEFV82 japqPyiif3FY9QvZSAVg59wofS7p3128IvhNA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=rEr7aG5rTFxKiZllQwHpjGK+1E8QKeV+UxYMDj2Y3p0spk5lJZmSET5xS/m0Rhq8om lRxyZ6ooUzLwm1kOWKG0a7Y4coTSj8RTZch7XEV9bu+Bj34dDUPk82Jml+HENcrf3OQS Xn23lJDaXo8SsffFWCEPSkUTFcSnVMUKuLYuM= Received: by 10.150.140.1 with SMTP id n1mr242814ybd.412.1291836733155; Wed, 08 Dec 2010 11:32:13 -0800 (PST) Received: from [192.168.0.101] ([201.82.135.226]) by mx.google.com with ESMTPS id u5sm1095620yba.22.2010.12.08.11.32.09 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 08 Dec 2010 11:32:11 -0800 (PST) Message-ID: <4CFFDDEE.8020501@ig.com.br> Date: Wed, 08 Dec 2010 17:35:10 -0200 From: Vinicius Jose Latorre User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.15) Gecko/20101027 SeaMonkey/2.0.10 MIME-Version: 1.0 To: Jeff Dairiki Subject: Re: bug#7582: whitespace.el: whitespace-cleanup does not clean spaces before tabs References: <20101207173424.GA28668@dairiki.org> In-Reply-To: <20101207173424.GA28668@dairiki.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: 7582 Cc: 7582@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) I've just updated the BZR Emacs and EmacsWiki. Thanks for your patch, Vinicius Jeff Dairiki wrote: > `whitespace-cleanup-region' in whitespace.el (version 13.1) does not > clean up spaces before tabs if either: > > - `space-before-tab' is in `whitespace-style' and `indent-tabs-mode' > non-nil > > - `space-before-tab::tab' is in `whitespace-style'. > > > Here's a patch (on whitespace.el version 13.1) which fixes the problem > for me. > > diff --git a/site-lisp/whitespace.el b/site-lisp/whitespace.el > index a9fec09..5f5e822 100644 > --- a/site-lisp/whitespace.el > +++ b/site-lisp/whitespace.el > @@ -1700,12 +1700,12 @@ documentation." > (whitespace-replace-action > (if whitespace-indent-tabs-mode 'tabify 'untabify) > rstart rend whitespace-space-before-tab-regexp > - (if whitespace-indent-tabs-mode 1 2))) > + (if whitespace-indent-tabs-mode 0 2))) > ;; ACTION: replace SPACEs before TAB by TABs. > ((memq 'space-before-tab::tab whitespace-style) > (whitespace-replace-action > 'tabify rstart rend > - whitespace-space-before-tab-regexp 1)) > + whitespace-space-before-tab-regexp 0)) > ;; ACTION: replace TABs by SPACEs. > ((memq 'space-before-tab::space whitespace-style) > (whitespace-replace-action > > > Thanks for everything! > > Jeff From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 09 15:21:42 2010 Received: (at control) by debbugs.gnu.org; 9 Dec 2010 20:21:43 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PQmzm-0005F8-Dq for submit@debbugs.gnu.org; Thu, 09 Dec 2010 15:21:42 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PQmzl-0005Ey-HD for control@debbugs.gnu.org; Thu, 09 Dec 2010 15:21:41 -0500 Received: from localhost ([127.0.0.1]:44178) by fencepost.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PQn5Y-0002LN-3X; Thu, 09 Dec 2010 15:27:40 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19713.15291.568121.244808@fencepost.gnu.org> Date: Thu, 9 Dec 2010 15:27:39 -0500 From: Glenn Morris To: control Subject: emacs X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: magenta X-Ran: CGy;,^!+2?kHGN@.Z[fDp)x#8LR/=`rAB$t{KX9O{VoHCjud*B0dD~w/KDJIt%@%PHe;Jf X-Debbugs-No-Ack: yes X-Spam-Score: -4.7 (----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.7 (----) close 7557 23.3 close 7582 24.1 From unknown Fri Jun 20 07:12:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 07 Jan 2011 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator