GNU bug report logs - #7582
whitespace.el: whitespace-cleanup does not clean spaces before tabs

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 7582 in the body.
You can then email your comments to 7582 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jeff Dairiki <dairiki <at> dairiki.org>
To: bug-gnu-emacs <at> gnu.org
Subject: whitespace.el: whitespace-cleanup does not clean spaces before tabs
Date: Tue, 7 Dec 2010 09:34:26 -0800

`whitespace-cleanup-region' in whitespace.el (version 13.1) does not
clean up spaces before tabs if either:

 - `space-before-tab' is in `whitespace-style' and `indent-tabs-mode'
   non-nil

 - `space-before-tab::tab' is in `whitespace-style'.


Here's a patch (on whitespace.el version 13.1) which fixes the problem
for me.

diff --git a/site-lisp/whitespace.el b/site-lisp/whitespace.el
index a9fec09..5f5e822 100644
--- a/site-lisp/whitespace.el
+++ b/site-lisp/whitespace.el
@@ -1700,12 +1700,12 @@ documentation."
            (whitespace-replace-action
             (if whitespace-indent-tabs-mode 'tabify 'untabify)
             rstart rend whitespace-space-before-tab-regexp
-            (if whitespace-indent-tabs-mode 1 2)))
+            (if whitespace-indent-tabs-mode 0 2)))
           ;; ACTION: replace SPACEs before TAB by TABs.
           ((memq 'space-before-tab::tab whitespace-style)
            (whitespace-replace-action
             'tabify rstart rend
-            whitespace-space-before-tab-regexp 1))
+            whitespace-space-before-tab-regexp 0))
           ;; ACTION: replace TABs by SPACEs.
           ((memq 'space-before-tab::space whitespace-style)
            (whitespace-replace-action


Thanks for everything!

Jeff

Message #8 received at 7582 <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Jose Latorre <viniciusjl <at> ig.com.br>
To: Jeff Dairiki <dairiki <at> dairiki.org>
Cc: 7582 <at> debbugs.gnu.org
Subject: Re: bug#7582: whitespace.el: whitespace-cleanup does not clean spaces
	before tabs
Date: Wed, 08 Dec 2010 17:35:10 -0200

I've just updated the BZR Emacs and EmacsWiki.

Thanks for your patch,

Vinicius


Jeff Dairiki wrote:
> `whitespace-cleanup-region' in whitespace.el (version 13.1) does not
> clean up spaces before tabs if either:
>
>   - `space-before-tab' is in `whitespace-style' and `indent-tabs-mode'
>     non-nil
>
>   - `space-before-tab::tab' is in `whitespace-style'.
>
>
> Here's a patch (on whitespace.el version 13.1) which fixes the problem
> for me.
>
> diff --git a/site-lisp/whitespace.el b/site-lisp/whitespace.el
> index a9fec09..5f5e822 100644
> --- a/site-lisp/whitespace.el
> +++ b/site-lisp/whitespace.el
> @@ -1700,12 +1700,12 @@ documentation."
>              (whitespace-replace-action
>               (if whitespace-indent-tabs-mode 'tabify 'untabify)
>               rstart rend whitespace-space-before-tab-regexp
> -            (if whitespace-indent-tabs-mode 1 2)))
> +            (if whitespace-indent-tabs-mode 0 2)))
>             ;; ACTION: replace SPACEs before TAB by TABs.
>             ((memq 'space-before-tab::tab whitespace-style)
>              (whitespace-replace-action
>               'tabify rstart rend
> -            whitespace-space-before-tab-regexp 1))
> +            whitespace-space-before-tab-regexp 0))
>             ;; ACTION: replace TABs by SPACEs.
>             ((memq 'space-before-tab::space whitespace-style)
>              (whitespace-replace-action
>
>
> Thanks for everything!
>
> Jeff

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.