GNU bug report logs - #75819
[PATCH 0/3] Fix sending emails from mcron

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 75819 in the body.
You can then email your comments to 75819 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tomas Volf <~@wolfsden.cz>
To: guix-patches <at> gnu.org
Cc: Tomas Volf <~@wolfsden.cz>
Subject: [PATCH 0/3] Fix sending emails from mcron
Date: Sat, 25 Jan 2025 00:44:28 +0100

I originally just wanted to fix sending emails from mcron, but then did minor
style changes to the package definition as well.  Only first patch is
required, second and third are optional.

Tomas Volf (3):
  gnu: mcron: Use correct sendmail.
  gnu: mcron: Apply guix style to (source).
  gnu: mcron: Re-indent (arguments).

 gnu/packages/guile-xyz.scm | 52 ++++++++++++++++++++------------------
 1 file changed, 28 insertions(+), 24 deletions(-)

--
2.47.1

Message #8 received at 75819 <at> debbugs.gnu.org (full text, mbox):

From: Tomas Volf <~@wolfsden.cz>
To: 75819 <at> debbugs.gnu.org
Cc: Tomas Volf <~@wolfsden.cz>
Subject: [PATCH 3/3] gnu: mcron: Re-indent (arguments).
Date: Sat, 25 Jan 2025 00:46:38 +0100

The more common formatting style for arguments seems to be to align the value
under the keyword.  This commit adjusts the definition to match that style.

* gnu/packages/guile-xyz.scm (mcron)[arguments]: Re-indent.

Change-Id: I5d3be19e41828db43af70207cb28b14c35d13419
---
 gnu/packages/guile-xyz.scm | 31 ++++++++++++++++---------------
 1 file changed, 16 insertions(+), 15 deletions(-)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index e9bdf18812..a34c1c7734 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -3291,21 +3291,22 @@ (define-public mcron
       #:configure-flags
       #~(list
          "--with-sendmail=/run/privileged/bin/sendmail -t")
-      #:phases #~(modify-phases %standard-phases
-                   (add-before 'check 'adjust-tests
-                     (lambda _
-                       (substitute* "tests/job-specifier.scm"
-                         ;; (getpw) fails with "entry not found" in the build
-                         ;; environment, so pass an argument.
-                         (("\\(getpw\\)")
-                          "(getpwnam (getuid))")
-                         ;; The build environment lacks an entry for root in
-                         ;; /etc/passwd.
-                         (("\\(getpw 0\\)")
-                          "(getpwnam \"nobody\")")
-                         ;; FIXME: Skip the 4 faulty tests (see above).
-                         (("\\(test-equal \"next-year\"" all)
-                          (string-append "(test-skip 4)\n" all))))))))
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-before 'check 'adjust-tests
+            (lambda _
+              (substitute* "tests/job-specifier.scm"
+                ;; (getpw) fails with "entry not found" in the build
+                ;; environment, so pass an argument.
+                (("\\(getpw\\)")
+                 "(getpwnam (getuid))")
+                ;; The build environment lacks an entry for root in
+                ;; /etc/passwd.
+                (("\\(getpw 0\\)")
+                 "(getpwnam \"nobody\")")
+                ;; FIXME: Skip the 4 faulty tests (see above).
+                (("\\(test-equal \"next-year\"" all)
+                 (string-append "(test-skip 4)\n" all))))))))
     (native-inputs (list autoconf
                          automake
                          guile-3.0    ;for 'guild compile'
-- 
2.47.1

Message #11 received at 75819 <at> debbugs.gnu.org (full text, mbox):

From: Tomas Volf <~@wolfsden.cz>
To: 75819 <at> debbugs.gnu.org
Cc: Tomas Volf <~@wolfsden.cz>
Subject: [PATCH 1/3] gnu: mcron: Use correct sendmail.
Date: Sat, 25 Jan 2025 00:46:36 +0100

When the crons are running, /run/privileged/bin is not in the $PATH, hence the
default of "sendmail -t" does not work.

* gnu/packages/guile-xyz.scm (mcron)[arguments]<#:configure-flags>: Set
sendmail path.

Change-Id: I86ffa5ddf26209acd8f706394ac13e63dcf4e0ec
---
 gnu/packages/guile-xyz.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index b59d19e9d8..79bd80135b 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -3288,6 +3288,9 @@ (define-public mcron
     (build-system gnu-build-system)
     (arguments
      (list
+      #:configure-flags
+      #~(list
+         "--with-sendmail=/run/privileged/bin/sendmail -t")
       #:phases #~(modify-phases %standard-phases
                    (add-before 'check 'adjust-tests
                      (lambda _
-- 
2.47.1

Message #14 received at 75819 <at> debbugs.gnu.org (full text, mbox):

From: Tomas Volf <~@wolfsden.cz>
To: 75819 <at> debbugs.gnu.org
Cc: Tomas Volf <~@wolfsden.cz>
Subject: [PATCH 2/3] gnu: mcron: Apply guix style to (source).
Date: Sat, 25 Jan 2025 00:46:37 +0100

* gnu/packages/guile-xyz.scm (mcron)[source]: Apply guix style.

Change-Id: I37c91a764625d6582d63755baa29ce1e78878324
---
 gnu/packages/guile-xyz.scm | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 79bd80135b..e9bdf18812 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -3276,15 +3276,15 @@ (define-public mcron
   (package
     (name "mcron")
     (version "1.2.3")
-    (source (origin
-              (method git-fetch)
-              (uri (git-reference
-                    (url "https://git.savannah.gnu.org/git/mcron.git")
-                    (commit (string-append "v" version))))
-              (file-name (git-file-name name version))
-              (sha256
-               (base32
-                "07gqwbjfsgf16ff624hkav0qhl10dv579y10fxas2kbjavqm4yx5"))))
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://git.savannah.gnu.org/git/mcron.git")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "07gqwbjfsgf16ff624hkav0qhl10dv579y10fxas2kbjavqm4yx5"))))
     (build-system gnu-build-system)
     (arguments
      (list
-- 
2.47.1

Message #19 received at 75819-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tomas Volf <~@wolfsden.cz>
Cc: 75819-done <at> debbugs.gnu.org
Subject: Re: [bug#75819] [PATCH 0/3] Fix sending emails from mcron
Date: Sun, 09 Feb 2025 18:03:56 +0100

Hi Tomas,

Tomas Volf <~@wolfsden.cz> skribis:

>   gnu: mcron: Use correct sendmail.
>   gnu: mcron: Apply guix style to (source).
>   gnu: mcron: Re-indent (arguments).

Applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.