Subject: Re: [PATCH] gnu: Add pa-notify

From: Noé Lopez <[email-masked]>
Date: Fri, 07 Feb 2025 23:13:45 +0100

Hi Junker,

Thanks for the patch! It looks great overall, builds and works on my
machine.

Just two comments:

> * gnu/packages/audio.scm (pa-notify): New variable.
> 
> Change-Id: Ib738b80e545958347101066f1e33b518869992bd
> ---
>  gnu/packages/audio.scm | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
> index 76b16bc0fd..1f0978cbe7 100644
> --- a/gnu/packages/audio.scm
> +++ b/gnu/packages/audio.scm
> @@ -50,6 +50,7 @@
>  ;;; Copyright © 2024 mio <[email-masked]>
>  ;;; Copyright © 2024 Nikita Domnitskii <[email-masked]>
>  ;;; Copyright © 2024 Roman Scherer <[email-masked]>
> +;;; Copyright © 2025 Junker <[email-masked]>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -3598,6 +3599,31 @@ (define-public alure
>  streaming.")
>      (license license:expat)))
>  
> +(define-public pa-notify
> +  (package
> +    (name "pa-notify")
> +    (version "1.5.0")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/ikrivosheev/pa-notify")
> +             (commit (string-append "v" version))))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "04wq0bdnb3r27l5wlf8c1ijq18ffywqmdv584l6hbi3i5k0sm7nz"))))
> +    (build-system cmake-build-system)
> +    (arguments '(#:tests? #f)) ; no check target

There should be no space between the semicolon and the comment when it
is aside like this.

> +    (inputs (list glib
> +                  libnotify
> +                  pulseaudio))
> +    (native-inputs (list pkg-config))
> +    (home-page "https://github.com/ikrivosheev/pa-notify")
> +    (synopsis "PulseAudio or PipeWire volume notification")
> +    (description "This package provides PulseAudio or PipeWire volume
> +notification daemon")

The description should end with a dot, and have a more complete
description of what the package offers. For example it could be:

pa-notify is a daemon that send a notification about the current volume
of PulseAudio or PipeWire using libnotify.

> +    (license license:expat)))
> +
>  (define-public patchage
>    (package
>      (name "patchage")
> 
> base-commit: ea7a6fa8c66ef3cfd0ccdec6c0a7a3e7ab3dfc9c
> -- 
> 2.48.1

Could you send a third version?

Thanks,
Noé