GNU bug report logs - #75816
[PATCH] gnu: Add pa-notify

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 75816 in the body.
You can then email your comments to 75816 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Junker <dk <at> junkeria.club>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add pa-notify
Date: Sat, 25 Jan 2025 01:04:21 +0300

Change-Id: I1afdff7e7f26f8b0468c993adc855b23677d4c06
---
 gnu/packages/audio.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 76b16bc0fd..1f0978cbe7 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -50,6 +50,7 @@
 ;;; Copyright © 2024 mio <stigma <at> disroot.org>
 ;;; Copyright © 2024 Nikita Domnitskii <nikita <at> domnitskii.me>
 ;;; Copyright © 2024 Roman Scherer <roman <at> burningswell.com>
+;;; Copyright © 2025 Junker <dk <at> junkeria.club>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -3598,6 +3599,31 @@ (define-public alure
 streaming.")
     (license license:expat)))
 
+(define-public pa-notify
+  (package
+    (name "pa-notify")
+    (version "1.5.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/ikrivosheev/pa-notify")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "04wq0bdnb3r27l5wlf8c1ijq18ffywqmdv584l6hbi3i5k0sm7nz"))))
+    (build-system cmake-build-system)
+    (arguments '(#:tests? #f)) ; no check target
+    (inputs (list glib
+                  libnotify
+                  pulseaudio))
+    (native-inputs (list pkg-config))
+    (home-page "https://github.com/ikrivosheev/pa-notify")
+    (synopsis "PulseAudio or PipeWire volume notification")
+    (description "This package provides PulseAudio or PipeWire volume
+notification daemon")
+    (license license:expat)))
+
 (define-public patchage
   (package
     (name "patchage")

base-commit: ea7a6fa8c66ef3cfd0ccdec6c0a7a3e7ab3dfc9c
prerequisite-patch-id: 88a949b9b0889acaebde2c5843fecda95c3e2c50
-- 
2.47.1

Message #8 received at 75816 <at> debbugs.gnu.org (full text, mbox):

From: Junker <dk <at> junkeria.club>
To: 75816 <at> debbugs.gnu.org
Subject: [PATCH v2] gnu: Add pa-notify.
Date: Fri, 31 Jan 2025 02:30:57 +0300

* gnu/packages/audio.scm (pa-notify): New variable.

Change-Id: Ib738b80e545958347101066f1e33b518869992bd
---
 gnu/packages/audio.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 76b16bc0fd..1f0978cbe7 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -50,6 +50,7 @@
 ;;; Copyright © 2024 mio <stigma <at> disroot.org>
 ;;; Copyright © 2024 Nikita Domnitskii <nikita <at> domnitskii.me>
 ;;; Copyright © 2024 Roman Scherer <roman <at> burningswell.com>
+;;; Copyright © 2025 Junker <dk <at> junkeria.club>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -3598,6 +3599,31 @@ (define-public alure
 streaming.")
     (license license:expat)))
 
+(define-public pa-notify
+  (package
+    (name "pa-notify")
+    (version "1.5.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/ikrivosheev/pa-notify")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "04wq0bdnb3r27l5wlf8c1ijq18ffywqmdv584l6hbi3i5k0sm7nz"))))
+    (build-system cmake-build-system)
+    (arguments '(#:tests? #f)) ; no check target
+    (inputs (list glib
+                  libnotify
+                  pulseaudio))
+    (native-inputs (list pkg-config))
+    (home-page "https://github.com/ikrivosheev/pa-notify")
+    (synopsis "PulseAudio or PipeWire volume notification")
+    (description "This package provides PulseAudio or PipeWire volume
+notification daemon")
+    (license license:expat)))
+
 (define-public patchage
   (package
     (name "patchage")

base-commit: ea7a6fa8c66ef3cfd0ccdec6c0a7a3e7ab3dfc9c
-- 
2.48.1

Message #11 received at 75816 <at> debbugs.gnu.org (full text, mbox):

From: Noé Lopez <noe <at> xn--no-cja.eu>
To: 75816 <at> debbugs.gnu.org
Cc: Junker <dk <at> junkeria.club>
Subject: Re: [PATCH] gnu: Add pa-notify
Date: Fri, 07 Feb 2025 23:13:45 +0100

Hi Junker,

Thanks for the patch! It looks great overall, builds and works on my
machine.

Just two comments:

> * gnu/packages/audio.scm (pa-notify): New variable.
> 
> Change-Id: Ib738b80e545958347101066f1e33b518869992bd
> ---
>  gnu/packages/audio.scm | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
> index 76b16bc0fd..1f0978cbe7 100644
> --- a/gnu/packages/audio.scm
> +++ b/gnu/packages/audio.scm
> @@ -50,6 +50,7 @@
>  ;;; Copyright © 2024 mio <stigma <at> disroot.org>
>  ;;; Copyright © 2024 Nikita Domnitskii <nikita <at> domnitskii.me>
>  ;;; Copyright © 2024 Roman Scherer <roman <at> burningswell.com>
> +;;; Copyright © 2025 Junker <dk <at> junkeria.club>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -3598,6 +3599,31 @@ (define-public alure
>  streaming.")
>      (license license:expat)))
>  
> +(define-public pa-notify
> +  (package
> +    (name "pa-notify")
> +    (version "1.5.0")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/ikrivosheev/pa-notify")
> +             (commit (string-append "v" version))))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "04wq0bdnb3r27l5wlf8c1ijq18ffywqmdv584l6hbi3i5k0sm7nz"))))
> +    (build-system cmake-build-system)
> +    (arguments '(#:tests? #f)) ; no check target

There should be no space between the semicolon and the comment when it
is aside like this.

> +    (inputs (list glib
> +                  libnotify
> +                  pulseaudio))
> +    (native-inputs (list pkg-config))
> +    (home-page "https://github.com/ikrivosheev/pa-notify")
> +    (synopsis "PulseAudio or PipeWire volume notification")
> +    (description "This package provides PulseAudio or PipeWire volume
> +notification daemon")

The description should end with a dot, and have a more complete
description of what the package offers. For example it could be:

pa-notify is a daemon that send a notification about the current volume
of PulseAudio or PipeWire using libnotify.

> +    (license license:expat)))
> +
>  (define-public patchage
>    (package
>      (name "patchage")
> 
> base-commit: ea7a6fa8c66ef3cfd0ccdec6c0a7a3e7ab3dfc9c
> -- 
> 2.48.1

Could you send a third version?

Thanks,
Noé

Message #14 received at 75816 <at> debbugs.gnu.org (full text, mbox):

From: Junker <dk <at> junkeria.club>
To: 75816 <at> debbugs.gnu.org
Subject: [PATCH v3] gnu: Add pa-notify.
Date: Tue, 11 Feb 2025 13:36:59 +0300

* gnu/packages/audio.scm (pa-notify): New variable.

Change-Id: If10916edb945911da2f1ec85aa43fc119722a029
---
 gnu/packages/audio.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 76b16bc0fd..bcd00ca581 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -50,6 +50,7 @@
 ;;; Copyright © 2024 mio <stigma <at> disroot.org>
 ;;; Copyright © 2024 Nikita Domnitskii <nikita <at> domnitskii.me>
 ;;; Copyright © 2024 Roman Scherer <roman <at> burningswell.com>
+;;; Copyright © 2025 Junker <dk <at> junkeria.club>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -3598,6 +3599,31 @@ (define-public alure
 streaming.")
     (license license:expat)))
 
+(define-public pa-notify
+  (package
+    (name "pa-notify")
+    (version "1.5.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/ikrivosheev/pa-notify")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "04wq0bdnb3r27l5wlf8c1ijq18ffywqmdv584l6hbi3i5k0sm7nz"))))
+    (build-system cmake-build-system)
+    (arguments '(#:tests? #f)) ;no check target
+    (inputs (list glib
+                  libnotify
+                  pulseaudio))
+    (native-inputs (list pkg-config))
+    (home-page "https://github.com/ikrivosheev/pa-notify")
+    (synopsis "PulseAudio or PipeWire volume notification")
+    (description "pa-notify is a daemon that sends notifications about
+the current volume level of PulseAudio or PipeWire using libnotify.")
+    (license license:expat)))
+
 (define-public patchage
   (package
     (name "patchage")

base-commit: ea7a6fa8c66ef3cfd0ccdec6c0a7a3e7ab3dfc9c
-- 
2.48.1

Message #17 received at 75816 <at> debbugs.gnu.org (full text, mbox):

From: Noé Lopez <noe <at> xn--no-cja.eu>
To: control <at> debbugs.gnu.org,75816 <at> debbugs.gnu.org
Subject: QA review for 75816
Date: Sun, 16 Feb 2025 14:09:16 +0100

user guix
usertag 75816 + reviewed-looks-good
thanks

Guix QA review form submission:
Builds and works well, thanks!

Items marked as checked: Lint warnings, Package builds, Commit messages, New package licenses, New package synopsis and descriptions

Message #22 received at 75816-done <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: 75816-done <at> debbugs.gnu.org
Subject: Close
Date: Mon, 17 Feb 2025 13:40:15 +0100

Pushed, with a tiny change to the description:
I am uncomfortable starting a sentence with a lower-case package name,
so I modified it to move the package name.

Thanks to the two of you for the patch and the review!

Andreas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.