GNU bug report logs - #75809
Hard-coded version code is unsuitable for automated F-Droid Android package builds

Previous Next

Full log

Message #29 received at 75809-done <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: Peter Oliver <p.d.oliver <at> mavit.org.uk>, 75809-done <at> debbugs.gnu.org
Subject: Re: bug#75809: Hard-coded version code is unsuitable for automated
 F-Droid Android package builds
Date: Wed, 05 Mar 2025 14:59:58 +0800

Stefan Kangas <stefankangas <at> gmail.com> writes:

> Peter Oliver <p.d.oliver <at> mavit.org.uk> writes:
>
>> On Thu, 20 Feb 2025, Stefan Kangas wrote:
>>
>>> Po Lu <luangruo <at> yahoo.com> writes:
>>>
>>>> Peter Oliver <p.d.oliver <at> mavit.org.uk> writes:
>>>>
>>>>> Further to the discussion on emacs-devel, here is an updated patch.
>>>>
>>>> My apologies for having overlooked this for so long.  Is there any
>>>> chance the file name could be shorter?  Or even a comment in
>>>> java/AndroidManifest.xml-in?
>>>
>>> Peter, what are your thought on the above?
>>
>> Anything that can be matched with a regular expression is fine, so a comment
>> would work.  Creating a new file for this purpose seems neater and potentially
>> less fragile to me, but I’m happy to do whatever you think best.
>>
>>> If it can't be put in a comment, instead of "incrementing-version-code",
>>> how about "android-version"?
>>
>> We can call the file whatever we think makes most sense.  We just have to update
>> the patch we send to F-Droid
>> (https://gitlab.com/fdroid/fdroiddata/-/merge_requests/19018/diffs) to contain
>> whatever filename we choose.
>
> Po Lu, could you please install Peter's patch amended to use the file
> and/or comment that you think is suitable here?  Thanks in advance.

Now done.

Closing, and please notify the F-Droid packagers of the fact.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.