GNU bug report logs - #75809
Hard-coded version code is unsuitable for automated F-Droid Android package builds

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Po Lu <luangruo <at> yahoo.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#75809: closed (Hard-coded version code is unsuitable for
 automated F-Droid Android package builds)
Date: Wed, 05 Mar 2025 07:01:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 05 Mar 2025 14:59:58 +0800
with message-id <877c54gdxt.fsf <at> yahoo.com>
and subject line Re: bug#75809: Hard-coded version code is unsuitable for automated F-Droid Android package builds
has caused the debbugs.gnu.org bug report #75809,
regarding Hard-coded version code is unsuitable for automated F-Droid Android package builds
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
75809: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=75809
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Peter Oliver <p.d.oliver <at> mavit.org.uk>
To: bug-gnu-emacs <at> debbugs.gnu.org
Cc: Po Lu <luangruo <at> yahoo.com>
Subject: Hard-coded version code is unsuitable for automated F-Droid Android
 package builds
Date: Fri, 24 Jan 2025 17:13:10 +0000 (GMT)

[Message part 3 (text/plain, inline)]

On Sun, 19 Jan 2025, Peter Oliver wrote:

> I notice that F-Droid is able to automatically build packages when a new Git 
> tag is made.  However, in order to do that, it needs to be given an integer 
> version number (called a version code; 
> https://developer.android.com/studio/publish/versioning#versioningsettings). 
> It can look for that either in the name of a Git tag, by searching in a file 
> within Git, or by fetching some data over HTTP 
> (https://f-droid.org/en/docs/Build_Metadata_Reference/#UpdateCheckData).
>
> Currently, this is hard-coded to 30 in java/AndroidManifest.xml.in, but 
> something like 300093000 would be needed (for 30.0.93).  Could we set that 
> for them?

Attached are two patches addressing this.

-- 
Peter Oliver

[0001-Note-that-.apk-packages-for-Android-can-be-installed.patch (text/plain, attachment)]

[0002-Set-android-versionCode-as-an-integer-derived-from-t.patch (text/plain, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Po Lu <luangruo <at> yahoo.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: Peter Oliver <p.d.oliver <at> mavit.org.uk>, 75809-done <at> debbugs.gnu.org
Subject: Re: bug#75809: Hard-coded version code is unsuitable for automated
 F-Droid Android package builds
Date: Wed, 05 Mar 2025 14:59:58 +0800

Stefan Kangas <stefankangas <at> gmail.com> writes:

> Peter Oliver <p.d.oliver <at> mavit.org.uk> writes:
>
>> On Thu, 20 Feb 2025, Stefan Kangas wrote:
>>
>>> Po Lu <luangruo <at> yahoo.com> writes:
>>>
>>>> Peter Oliver <p.d.oliver <at> mavit.org.uk> writes:
>>>>
>>>>> Further to the discussion on emacs-devel, here is an updated patch.
>>>>
>>>> My apologies for having overlooked this for so long.  Is there any
>>>> chance the file name could be shorter?  Or even a comment in
>>>> java/AndroidManifest.xml-in?
>>>
>>> Peter, what are your thought on the above?
>>
>> Anything that can be matched with a regular expression is fine, so a comment
>> would work.  Creating a new file for this purpose seems neater and potentially
>> less fragile to me, but I’m happy to do whatever you think best.
>>
>>> If it can't be put in a comment, instead of "incrementing-version-code",
>>> how about "android-version"?
>>
>> We can call the file whatever we think makes most sense.  We just have to update
>> the patch we send to F-Droid
>> (https://gitlab.com/fdroid/fdroiddata/-/merge_requests/19018/diffs) to contain
>> whatever filename we choose.
>
> Po Lu, could you please install Peter's patch amended to use the file
> and/or comment that you think is suitable here?  Thanks in advance.

Now done.

Closing, and please notify the F-Droid packagers of the fact.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.