Subject: Re: bug#75809: Hard-coded version code is unsuitable for automated F-Droid Android package builds

From: Peter Oliver <[email-masked]>
Date: Tue, 25 Feb 2025 13:12:35 +0000 (GMT)

On Thu, 20 Feb 2025, Stefan Kangas wrote:

> Po Lu <[email-masked]> writes:
>
>> Peter Oliver <[email-masked]> writes:
>>
>>> Further to the discussion on emacs-devel, here is an updated patch.
>>
>> My apologies for having overlooked this for so long.  Is there any
>> chance the file name could be shorter?  Or even a comment in
>> java/AndroidManifest.xml-in?
>
> Peter, what are your thought on the above?

Anything that can be matched with a regular expression is fine, so a comment would work.  Creating a new file for this purpose seems neater and potentially less fragile to me, but I’m happy to do whatever you think best.

> If it can't be put in a comment, instead of "incrementing-version-code",
> how about "android-version"?

We can call the file whatever we think makes most sense.  We just have to update the patch we send to F-Droid (https://gitlab.com/fdroid/fdroiddata/-/merge_requests/19018/diffs) to contain whatever filename we choose.

-- 
Peter Oliver