GNU bug report logs - #7580
[PATCH] cc-mode bitfield fontification bug

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 7580 in the body.
You can then email your comments to 7580 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Daniel Colascione <dan.colascione <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] cc-mode bitfield fontification bug
Date: Tue, 07 Dec 2010 04:34:54 -0800

[Message part 1 (text/plain, inline)]

struct test
{
   /* Both should be fontified as bitfields; currently, only the former
is */
   int bf1:5;
   unsigned bf2:5;
};


@@ -5575,7 +5656,9 @@
 		  ;; a valid label.  Otherwise the last one probably is the
 		  ;; declared identifier and we should back up to the previous
 		  ;; type, providing it isn't a cast.
-		  (if (eq (char-after) ?:)
+		  (if (and (eq (char-after) ?:)
+                           (not (and (eq backup-at-type 'prefix)
+                                     (eq at-type 'maybe))))
 		      ;; If we've found a specifier keyword then it's a
 		      ;; declaration regardless.
 		      (throw 'at-decl-or-cast (eq at-decl-or-cast t))

[signature.asc (application/pgp-signature, attachment)]

Message #8 received at 7580 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Alan Mackenzie  <acm <at> muc.de>
Cc: Daniel Colascione <dan.colascione <at> gmail.com>, 7580 <at> debbugs.gnu.org
Subject: Re: bug#7580: [PATCH] cc-mode bitfield fontification bug
Date: Fri, 21 Jan 2011 22:06:26 -0500

Hi Alan,

Could you please review this patch?  Thanks!


Daniel Colascione <dan.colascione <at> gmail.com> writes:

> struct test
> {
>    /* Both should be fontified as bitfields; currently, only the former
> is */
>    int bf1:5;
>    unsigned bf2:5;
> };
>
>
> @@ -5575,7 +5656,9 @@
>  		  ;; a valid label.  Otherwise the last one probably is the
>  		  ;; declared identifier and we should back up to the previous
>  		  ;; type, providing it isn't a cast.
> -		  (if (eq (char-after) ?:)
> +		  (if (and (eq (char-after) ?:)
> +                           (not (and (eq backup-at-type 'prefix)
> +                                     (eq at-type 'maybe))))
>  		      ;; If we've found a specifier keyword then it's a
>  		      ;; declaration regardless.
>  		      (throw 'at-decl-or-cast (eq at-decl-or-cast t))

Message #13 received at 7580-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 7580-done <at> debbugs.gnu.org
Subject: Re: bug#7580: [PATCH] cc-mode bitfield fontification bug
Date: Mon, 03 Oct 2011 16:35:10 -0400

Version: 24.1

I see this in 23.3 but not in the current trunk, so it seems to have
been fixed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.