GNU bug report logs - #75794
[PATCH] feat(icomplete): markers and vertical alignment

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Rahul Martim Juliato <rahuljuliato <at> gmail.com>
Subject: bug#75794: closed (Re: bug#75794: [PATCH] feat(icomplete):
 markers and vertical alignment)
Date: Sat, 29 Mar 2025 16:50:01 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#75794: [PATCH] feat(icomplete): markers and vertical alignment

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 75794 <at> debbugs.gnu.org.

-- 
75794: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=75794
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Rahul Martim Juliato <rahuljuliato <at> gmail.com>
Cc: 75794-done <at> debbugs.gnu.org, jixiuf <at> qq.com
Subject: Re: bug#75794: [PATCH] feat(icomplete): markers and vertical alignment
Date: Sat, 29 Mar 2025 19:48:24 +0300

> From: Rahul Martim Juliato <rahuljuliato <at> gmail.com>
> Cc: Rahul Martim Juliato <rahuljuliato <at> gmail.com>,  jixiuf <at> qq.com,
>   75794 <at> debbugs.gnu.org
> Date: Sat, 29 Mar 2025 13:01:51 -0300
> 
> >   In icomplete--render-vertical:
> >   icomplete.el:1015:11: Warning: Unused lexical variable `comp'
> >   icomplete.el:1019:10: Warning: Unused lexical variable `comp'
> >
> > Can you fix this, please?
> 
> Fixed.
> 
> > These entries should be under "Changes in Specialized Modes and
> > Packages in Emacs 31.1", in a new sub-section "Icomplete".
> >
> 
> Moved to the right section.
> 
> > We use the US English spelling: "behavior".
> 
> Oops, fixed.
> 
> --
> 
> Please find attached the newest version of this patch.

Thanks, installed on the master branch, and closing the bug.

[Message part 3 (message/rfc822, inline)]

From: Rahul Martim Juliato <rahuljuliato <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] feat(icomplete): markers and vertical alignment
Date: Thu, 23 Jan 2025 23:51:06 -0300

[Message part 4 (text/plain, inline)]

Tags: patch

Tags: patch

Dear GNU Emacs Maintainers,

I hope this message finds you well.

I am submitting a patch for icomplete-mode that introduces two
enhancements aimed at improving the user experience with completion
candidates:

Vertical Alignment: When using icomplete-vertical-mode for in-buffer
completion, the candidates will now align vertically with the column
where the cursor was when completion started. This provides a cleaner,
more intuitive visual experience when scrolling through completion
suggestions.

Customizable Markers: I’ve introduced two customizable markers for
icomplete-vertical-mode. The first marker will be applied to the
selected candidate, and the second will apply to the rest of the
list. Both markers are customizable via Emacs faces, allowing users to
tailor the appearance to their preferences.

These enhancements are intended to improve the usability and flexibility
of the icomplete interface. The ability to align the completion
candidates and customize the markers will make the completion process
smoother, especially in environments where visual clarity is essential.

In case you would like to explore the context further, I’ve written two
blog posts discussing in-buffer icomplete and these enhancements:


In-Buffer icomplete
[1] https://www.rahuljuliato.com/posts/in-buffer-icomplete

This post provides an introduction to the improvements made to icomplete
and the reasoning behind the changes.


In-Buffer icomplete – A Follow-up
[2] https://www.rahuljuliato.com/posts/in-buffer-icomplete-2

This second post elaborates on the specific features introduced in the
patch, with images illustrating the differences in the user interface.

The blog posts contain references to the changes and visual examples
that may help clarify the intent of the patch. I believe this will
provide a more comprehensive understanding of the features and their
potential impact.


The patch is attached for review. The modifications have been tested,
and I’m happy to make any adjustments or answer any questions regarding
the implementation.

Thank you for considering this patch, and I look forward to your
feedback.

Best regards,
Rahul Martim Juliato
[rahul.juliato <at> gmail.com]


In GNU Emacs 30.0.91 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.38, cairo version 1.16.0) of 2024-09-26 built on debian
Repository revision: 9a1c76bf7ff49d886cc8e1a3f360d71e62544802
Repository branch: HEAD
Windowing system distributor 'The X.Org Foundation', version 11.0.12101007
System Description: Debian GNU/Linux 12 (bookworm)

[0001-feat-icomplete-markers-and-vertical-alignment.patch (text/patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.