GNU bug report logs - #75794
[PATCH] feat(icomplete): markers and vertical alignment

Previous Next

Full log

Message #64 received at 75794 <at> debbugs.gnu.org (full text, mbox):

From: Rahul Martim Juliato <rahuljuliato <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Rahul Martim Juliato <rahuljuliato <at> gmail.com>, jixiuf <at> qq.com,
 75794 <at> debbugs.gnu.org
Subject: Re: bug#75794: [PATCH] feat(icomplete): markers and vertical alignment
Date: Wed, 26 Mar 2025 23:29:36 -0300

[Message part 1 (text/plain, inline)]

>
> Please format the commit log message according to our conventions.
> Specifically:
>
>   . lines not longer than 63 characters
>   . changes described with their file names, not separately
>   . Each change description a complete sentence ending in a period
>

I think I did it right this time, if you could please check if this is
nice enough :)

>
> Please format NEWS entries according to our conventions (it's a
> derivative of Outline mode, using "*" for heading line indentations).
>
> Also, since you haven't updated any manuals, the NEWS entries should
> not be marked with "+++".
>

Removed the +++, tried to follow examples from other NEWS.

>> +  "Face used for the prefix set by `icomplete-vertical-unselected-prefix-indicator'."
>
> This doc string is too long.  Please keep the lines in doc strings
> below 80 characters.
>

Done.

>> +(defcustom icomplete-vertical-render-prefix-indicator nil
>> +  "Control whether a indicator is added as a prefix to each candidate.
>                       ^^^^^^^^^^^
> "an indicator"
>

Done.

>> +If this is t and `icomplete-vertical-mode' is activated, a indicator,
>                                                             ^^^^^^^^^^^
> Likewise.
>

Done

>
> Is it wise to default to a non_ASCII character without checking first
> that it's supported by the display?
>

Agreed.  In this version I changed the
`icomplete-vertical-selected-prefix-indicator' default to first check if
the » is displayable, suggesting > otherwise.

> Regardless of the default value, the options should include an ASCII
> and a non-ASCII strings.

Done as state above.

--

Please find attached the latest version of this patch:
`0001-Enhance-icomplete-vertical-mode-2025-03-26.patch'

Sorry for the delayed response.

-- 

Rahul Martim Juliato

[0001-Enhance-icomplete-vertical-mode-2025-03-26.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.