GNU bug report logs - #75785
30.0.93: grouped type declarations fail to indent in go-ts-mode

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#75785: closed (30.0.93: grouped type declarations fail to
 indent in go-ts-mode)
Date: Thu, 23 Jan 2025 17:36:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 23 Jan 2025 19:35:06 +0200
with message-id <86sep9zb5h.fsf <at> gnu.org>
and subject line Re: bug#75785: 30.0.93: grouped type declarations fail to indent in go-ts-mode
has caused the debbugs.gnu.org bug report #75785,
regarding 30.0.93: grouped type declarations fail to indent in go-ts-mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
75785: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=75785
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Gerard Vermeulen <gerard.vermeulen <at> posteo.net>
To: Bug gnu emacs <bug-gnu-emacs <at> gnu.org>
Subject: 30.0.93: grouped type declarations fail to indent in go-ts-mode
Date: Thu, 23 Jan 2025 13:09:45 +0000

Hi,

Automatic indenting when typing works in go-ts-mode for grouped
var declarations like:

var (
        a = 1
        b = 2
)

but not for type declarations (taken from
https://github.com/uber-go/guide/blob/master/style.md#group-similar-declarations
) like:

type (
Area float64
Volume float64
)

where I have to add the tabs (or spaces) myself.
I tried to change "type_spec" to "type_spec_list" in the defvar
go-ts-mode--indent-rules expression, but that did not fix it.

I am using a recent 30.0.93 git checkout.

Can it be fixed?

Best regards -- Gerard

[Message part 3 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Gerard Vermeulen <gerard.vermeulen <at> posteo.net>
Cc: dev <at> rjt.dev, casouri <at> gmail.com, 75785-done <at> debbugs.gnu.org
Subject: Re: bug#75785: 30.0.93: grouped type declarations fail to indent in
 go-ts-mode
Date: Thu, 23 Jan 2025 19:35:06 +0200

> Date: Thu, 23 Jan 2025 16:42:07 +0000
> From: Gerard Vermeulen <gerard.vermeulen <at> posteo.net>
> Cc: Eli Zaretskii <eliz <at> gnu.org>, Yuan Fu <casouri <at> gmail.com>,
>  75785 <at> debbugs.gnu.org
> 
> 
> 
> On 23.01.2025 17:22, Randy Taylor wrote:
> > On Thursday, January 23rd, 2025 at 09:56, Eli Zaretskii <eliz <at> gnu.org> 
> > wrote:
> >> 
> >> 
> >> > Date: Thu, 23 Jan 2025 13:09:45 +0000
> >> 
> >> > From: Gerard Vermeulen gerard.vermeulen <at> posteo.net
> >> >
> >> > Hi,
> >> >
> >> > Automatic indenting when typing works in go-ts-mode for grouped
> >> > var declarations like:
> >> >
> >> > var (
> >> > a = 1
> >> > b = 2
> >> > )
> >> >
> >> > but not for type declarations (taken from
> >> > https://github.com/uber-go/guide/blob/master/style.md#group-similar-declarations
> >> > ) like:
> >> >
> >> > type (
> >> > Area float64
> >> > Volume float64
> >> > )
> >> >
> >> > where I have to add the tabs (or spaces) myself.
> >> > I tried to change "type_spec" to "type_spec_list" in the defvar
> >> > go-ts-mode--indent-rules expression, but that did not fix it.
> >> >
> >> > I am using a recent 30.0.93 git checkout.
> >> >
> >> > Can it be fixed?
> >> 
> >> 
> >> Randy and Yuan, could you please look into this?
> > 
> > Thanks for the report.
> > 
> > The attached patch fixes it for me.
> 
> For me too. Thanks.

Thanks, so I'm now closing this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.