From unknown Tue Jun 17 22:20:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#75785: 30.0.93: grouped type declarations fail to indent in go-ts-mode Resent-From: Gerard Vermeulen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Jan 2025 13:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 75785 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 75785@debbugs.gnu.org X-Debbugs-Original-To: Bug gnu emacs Received: via spool by submit@debbugs.gnu.org id=B.173763780912193 (code B ref -1); Thu, 23 Jan 2025 13:11:02 +0000 Received: (at submit) by debbugs.gnu.org; 23 Jan 2025 13:10:09 +0000 Received: from localhost ([127.0.0.1]:39841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tawyH-0003Ab-8V for submit@debbugs.gnu.org; Thu, 23 Jan 2025 08:10:09 -0500 Received: from lists.gnu.org ([2001:470:142::17]:43740) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tawyD-00039v-5t for submit@debbugs.gnu.org; Thu, 23 Jan 2025 08:10:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tawy4-0007B8-9s for bug-gnu-emacs@gnu.org; Thu, 23 Jan 2025 08:09:56 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tawy1-0000EO-3t for bug-gnu-emacs@gnu.org; Thu, 23 Jan 2025 08:09:55 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 0C27C240101 for ; Thu, 23 Jan 2025 14:09:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1737637786; bh=WEeFHvG1QCuizflWsVsc8FR9Fj5gQG1VSAsiQucYHBo=; h=MIME-Version:Date:From:To:Subject:Message-ID:Content-Type: Content-Transfer-Encoding:From; b=Ra7ttxmpzScaUPxxoFXIVVgBCaHdgls1heSQRvFSN3R9GnYB7X4Hbt2kJ6P2UmP8/ 1ehnyqIdE5wxBpwtzUCCsFT2KNl9+NYo32P+Vd3EBs/vgzqHubDzPtKZf1dPUzPh4S 0BWNJxZOSg4lSjuWGcvEzpvwXTux4fGuYAnZbDwddtId7QOP8ihrvx6YZIc89gtX+q j81yd+S1XXR02Rpsh08iOqJx1+3SU8Jhiz2tQyQN/V3ohYdeSQlF4GzRR+dXB/xYNI y7J2bfW/FwYZvla3H35bkdAvV1Sa6pHMTUxjrfb7KwtgnyQMkUr3xBpkHp0Iuce1CX 7Bkox6CfgRCDQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Yf1WF4JVWz9rxL for ; Thu, 23 Jan 2025 14:09:45 +0100 (CET) MIME-Version: 1.0 Date: Thu, 23 Jan 2025 13:09:45 +0000 From: Gerard Vermeulen Message-ID: <8c3691b709e7919322299afc7552d9d7@posteo.net> Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=185.67.36.66; envelope-from=gerard.vermeulen@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi, Automatic indenting when typing works in go-ts-mode for grouped var declarations like: var ( a = 1 b = 2 ) but not for type declarations (taken from https://github.com/uber-go/guide/blob/master/style.md#group-similar-declarations ) like: type ( Area float64 Volume float64 ) where I have to add the tabs (or spaces) myself. I tried to change "type_spec" to "type_spec_list" in the defvar go-ts-mode--indent-rules expression, but that did not fix it. I am using a recent 30.0.93 git checkout. Can it be fixed? Best regards -- Gerard From unknown Tue Jun 17 22:20:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#75785: 30.0.93: grouped type declarations fail to indent in go-ts-mode Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Jan 2025 14:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75785 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Gerard Vermeulen , Randy Taylor , Yuan Fu Cc: 75785@debbugs.gnu.org Received: via spool by 75785-submit@debbugs.gnu.org id=B75785.173764424512843 (code B ref 75785); Thu, 23 Jan 2025 14:58:02 +0000 Received: (at 75785) by debbugs.gnu.org; 23 Jan 2025 14:57:25 +0000 Received: from localhost ([127.0.0.1]:41797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1taye5-0003L5-45 for submit@debbugs.gnu.org; Thu, 23 Jan 2025 09:57:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34468) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1taye0-0003Ku-Ot for 75785@debbugs.gnu.org; Thu, 23 Jan 2025 09:57:22 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1taydt-0003wQ-9i; Thu, 23 Jan 2025 09:57:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=wTbEoXKkG5T+wdqbjyCHhcSyHJs00mbwQFCYLTX8L4w=; b=Iq4KjbSc0J4m FtLp2psva+mIukX9gOk2dclmOW09tLk14X4gT1RfQy3Ue11IpK0pZDI32CC39SwfWIfFXDWdQdC0e u3QkJhbsPSSp+8bWTf1eZ19+9dA50NoqoVospFkoX6Roylo/QArMz5Kmq2wG4uMk9vCzVuE5205bH 0mGcEkE/SdVQuyGkzm8TIF0tv+RNJjgjnCm1xed8s/PZlVjXYdvGmDT7GnooWgJDf9D2N3UeVuLtz T9KuGt+CamTwcFjHMZwgBophd6wXsG1xzIT5fDzQ3MPmV1FBsyeolt/ec+teNya5cy+F1yflX8vX/ 7wLKcxfmqYhLmYXZJE7hpw==; Date: Thu, 23 Jan 2025 16:56:45 +0200 Message-Id: <867c6l1suq.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <8c3691b709e7919322299afc7552d9d7@posteo.net> (message from Gerard Vermeulen on Thu, 23 Jan 2025 13:09:45 +0000) References: <8c3691b709e7919322299afc7552d9d7@posteo.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 23 Jan 2025 13:09:45 +0000 > From: Gerard Vermeulen > > Hi, > > Automatic indenting when typing works in go-ts-mode for grouped > var declarations like: > > var ( > a = 1 > b = 2 > ) > > but not for type declarations (taken from > https://github.com/uber-go/guide/blob/master/style.md#group-similar-declarations > ) like: > > type ( > Area float64 > Volume float64 > ) > > where I have to add the tabs (or spaces) myself. > I tried to change "type_spec" to "type_spec_list" in the defvar > go-ts-mode--indent-rules expression, but that did not fix it. > > I am using a recent 30.0.93 git checkout. > > Can it be fixed? Randy and Yuan, could you please look into this? From unknown Tue Jun 17 22:20:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#75785: 30.0.93: grouped type declarations fail to indent in go-ts-mode Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Jan 2025 16:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75785 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: Gerard Vermeulen , Yuan Fu , 75785@debbugs.gnu.org Received: via spool by 75785-submit@debbugs.gnu.org id=B75785.173764937429537 (code B ref 75785); Thu, 23 Jan 2025 16:23:02 +0000 Received: (at 75785) by debbugs.gnu.org; 23 Jan 2025 16:22:54 +0000 Received: from localhost ([127.0.0.1]:42013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tazyn-0007gL-IK for submit@debbugs.gnu.org; Thu, 23 Jan 2025 11:22:53 -0500 Received: from mail-4323.proton.ch ([185.70.43.23]:33951) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tazyj-0007fw-KK for 75785@debbugs.gnu.org; Thu, 23 Jan 2025 11:22:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail3; t=1737649362; x=1737908562; bh=nmkltpw4auZaJRds4yvlYImhiEWaiZCFXr4qCUlg+ao=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=QKkWaIeyz1vDkyj9ACT7cjUR4BogBW3yUZOr50eUloYm8Qcy2r48+hnwH98aM2jpG FdjRnxRIKM9Atd4XOK6P9xcQEoteCNP8E4N7sY6+C/NVhQSakHmOIXM9KKrtAMeAs0 BRwKkruJ+8vS3wOeIRA4vTit/gQQFNM91K72s7oYwSPRJymmQK3Efw33uG+3PEuQ8h D548ZQKQt0K0hlpmBCiGUjJ9DR2C/9IWe4MjWPBhXo8As3nzWOM6HjdpPuFmOPq3zw syXVh6syfAr8JPmxwSxqmSNLwYlW6OaJe+23buWB3Pp+1p2eYtd57y4AZdQF4QZ4IA 3yxOqkmNqnvBQ== Date: Thu, 23 Jan 2025 16:22:37 +0000 From: Randy Taylor Message-ID: <8M0L9-M-GTFHsSye9mnZiHp2NY0Td-Q-f-zkTZmOel6CTSQl5HnpiGPqxHuD8IgE-6dX2NRLez59lu6qCVDl-EWvGSKxMZls31kJmofBInw=@rjt.dev> In-Reply-To: <867c6l1suq.fsf@gnu.org> References: <8c3691b709e7919322299afc7552d9d7@posteo.net> <867c6l1suq.fsf@gnu.org> Feedback-ID: 44397038:user:proton X-Pm-Message-ID: b41a2f48587126d75c388bae7ffb7276d5e0deca MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1=_XqVTmbCIYrWhqBFCVCKCIllsLg8S781wtkk40gKsH9Q" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --b1=_XqVTmbCIYrWhqBFCVCKCIllsLg8S781wtkk40gKsH9Q Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Thursday, January 23rd, 2025 at 09:56, Eli Zaretskii wrot= e: >=20 >=20 > > Date: Thu, 23 Jan 2025 13:09:45 +0000 >=20 > > From: Gerard Vermeulen gerard.vermeulen@posteo.net > >=20 > > Hi, > >=20 > > Automatic indenting when typing works in go-ts-mode for grouped > > var declarations like: > >=20 > > var ( > > a =3D 1 > > b =3D 2 > > ) > >=20 > > but not for type declarations (taken from > > https://github.com/uber-go/guide/blob/master/style.md#group-similar-dec= larations > > ) like: > >=20 > > type ( > > Area float64 > > Volume float64 > > ) > >=20 > > where I have to add the tabs (or spaces) myself. > > I tried to change "type_spec" to "type_spec_list" in the defvar > > go-ts-mode--indent-rules expression, but that did not fix it. > >=20 > > I am using a recent 30.0.93 git checkout. > >=20 > > Can it be fixed? >=20 >=20 > Randy and Yuan, could you please look into this? Thanks for the report. The attached patch fixes it for me. --b1=_XqVTmbCIYrWhqBFCVCKCIllsLg8S781wtkk40gKsH9Q Content-Type: text/x-patch; name=0001-Fix-go-ts-mode-type-declaration-indentation-Bug-7578.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-Fix-go-ts-mode-type-declaration-indentation-Bug-7578.patch RnJvbSA4ZjI1ZjI2NzhmMDgzN2Y3YTY3YWU2MDg1MmUyODljYzNjZmZkYzBlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSYW5keSBUYXlsb3IgPGRldkByanQuZGV2PgpEYXRlOiBUaHUs IDIzIEphbiAyMDI1IDExOjE2OjM0IC0wNTAwClN1YmplY3Q6IFtQQVRDSF0gRml4IGdvLXRzLW1v ZGUgdHlwZSBkZWNsYXJhdGlvbiBpbmRlbnRhdGlvbiAoQnVnIzc1Nzg1KQoKKiBsaXNwL3Byb2dt b2Rlcy9nby10cy1tb2RlLmVsIChnby10cy1tb2RlLS1pbmRlbnQtcnVsZXMpOgpBZGQgcnVsZSBm b3IgdHlwZV9kZWNsYXJhdGlvbi4KLS0tCiBsaXNwL3Byb2dtb2Rlcy9nby10cy1tb2RlLmVsIHwg MSArCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKykKCmRpZmYgLS1naXQgYS9saXNwL3By b2dtb2Rlcy9nby10cy1tb2RlLmVsIGIvbGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9kZS5lbAppbmRl eCBjY2ZkY2I5MDllNS4uZWYyYWYzY2Q1YWYgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL2dv LXRzLW1vZGUuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9kZS5lbApAQCAtMTAzLDYg KzEwMyw3IEBAIGdvLXRzLW1vZGUtLWluZGVudC1ydWxlcwogICAgICAoKHBhcmVudC1pcyAicGFy YW1ldGVyX2xpc3QiKSBwYXJlbnQtYm9sIGdvLXRzLW1vZGUtaW5kZW50LW9mZnNldCkKICAgICAg KChwYXJlbnQtaXMgInNlbGVjdF9zdGF0ZW1lbnQiKSBwYXJlbnQtYm9sIDApCiAgICAgICgocGFy ZW50LWlzICJ0eXBlX2Nhc2UiKSBwYXJlbnQtYm9sIGdvLXRzLW1vZGUtaW5kZW50LW9mZnNldCkK KyAgICAgKChwYXJlbnQtaXMgInR5cGVfZGVjbGFyYXRpb24iKSBwYXJlbnQtYm9sIGdvLXRzLW1v ZGUtaW5kZW50LW9mZnNldCkKICAgICAgKChwYXJlbnQtaXMgInR5cGVfc3BlYyIpIHBhcmVudC1i b2wgZ28tdHMtbW9kZS1pbmRlbnQtb2Zmc2V0KQogICAgICAoKHBhcmVudC1pcyAidHlwZV9zd2l0 Y2hfc3RhdGVtZW50IikgcGFyZW50LWJvbCAwKQogICAgICAoKHBhcmVudC1pcyAidmFyX2RlY2xh cmF0aW9uIikgcGFyZW50LWJvbCBnby10cy1tb2RlLWluZGVudC1vZmZzZXQpCi0tIAoyLjQ4LjEK Cg== --b1=_XqVTmbCIYrWhqBFCVCKCIllsLg8S781wtkk40gKsH9Q-- From unknown Tue Jun 17 22:20:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#75785: 30.0.93: grouped type declarations fail to indent in go-ts-mode Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Jan 2025 16:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75785 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Randy Taylor Cc: gerard.vermeulen@posteo.net, casouri@gmail.com, 75785@debbugs.gnu.org Received: via spool by 75785-submit@debbugs.gnu.org id=B75785.17376505371133 (code B ref 75785); Thu, 23 Jan 2025 16:43:01 +0000 Received: (at 75785) by debbugs.gnu.org; 23 Jan 2025 16:42:17 +0000 Received: from localhost ([127.0.0.1]:42074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tb0HY-0000ID-Gc for submit@debbugs.gnu.org; Thu, 23 Jan 2025 11:42:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53114) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tb0HW-0000Hp-AB for 75785@debbugs.gnu.org; Thu, 23 Jan 2025 11:42:15 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tb0HO-0006ma-QR; Thu, 23 Jan 2025 11:42:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+dTkE7euRFxaIJVE2v9/koNa+uQGDGv+y0lgfRz+qU0=; b=pVkCDrrXIge2 X9rGgGcWaiLGMeR9dIrgkUrJpu1VX75ER7PTMZpP0zMagxs8MlxlRcPtn8BjxF3oQxJEzf9nsfp3t 8WN/qic/ZT6nlTxDgFrTVy6cKr16Jibc6IIJZ5SpCck6R+yLJipXyT77J9UYt7XeKEdLuU+NGLRxv a3G0I1awWjiqn42bHHFo/dSzmI2WrG+5oX0Esw0EkxnYuZ7i9rKeazQHJt43yPDmqt1/U+lp0XEk1 8LdroAkcXSLqdoEvFdrs+1XYTeLGDsl9K4Cad35T62a7PSoE8ak8z2p0pbRZpYW6O+PGooGirLi6w ThRK/JI6MIyL+QmKxDqJuw==; Date: Thu, 23 Jan 2025 18:42:05 +0200 Message-Id: <86tt9pzdlu.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <8M0L9-M-GTFHsSye9mnZiHp2NY0Td-Q-f-zkTZmOel6CTSQl5HnpiGPqxHuD8IgE-6dX2NRLez59lu6qCVDl-EWvGSKxMZls31kJmofBInw=@rjt.dev> (message from Randy Taylor on Thu, 23 Jan 2025 16:22:37 +0000) References: <8c3691b709e7919322299afc7552d9d7@posteo.net> <867c6l1suq.fsf@gnu.org> <8M0L9-M-GTFHsSye9mnZiHp2NY0Td-Q-f-zkTZmOel6CTSQl5HnpiGPqxHuD8IgE-6dX2NRLez59lu6qCVDl-EWvGSKxMZls31kJmofBInw=@rjt.dev> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 23 Jan 2025 16:22:37 +0000 > From: Randy Taylor > Cc: Gerard Vermeulen , Yuan Fu , 75785@debbugs.gnu.org > > On Thursday, January 23rd, 2025 at 09:56, Eli Zaretskii wrote: > > > > > > > Date: Thu, 23 Jan 2025 13:09:45 +0000 > > > > > From: Gerard Vermeulen gerard.vermeulen@posteo.net > > > > > > Hi, > > > > > > Automatic indenting when typing works in go-ts-mode for grouped > > > var declarations like: > > > > > > var ( > > > a = 1 > > > b = 2 > > > ) > > > > > > but not for type declarations (taken from > > > https://github.com/uber-go/guide/blob/master/style.md#group-similar-declarations > > > ) like: > > > > > > type ( > > > Area float64 > > > Volume float64 > > > ) > > > > > > where I have to add the tabs (or spaces) myself. > > > I tried to change "type_spec" to "type_spec_list" in the defvar > > > go-ts-mode--indent-rules expression, but that did not fix it. > > > > > > I am using a recent 30.0.93 git checkout. > > > > > > Can it be fixed? > > > > > > Randy and Yuan, could you please look into this? > > Thanks for the report. > > The attached patch fixes it for me. Thanks, installed on the emacs-30 release branch. From unknown Tue Jun 17 22:20:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#75785: 30.0.93: grouped type declarations fail to indent in go-ts-mode Resent-From: Gerard Vermeulen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Jan 2025 16:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75785 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Randy Taylor Cc: Eli Zaretskii , Yuan Fu , 75785@debbugs.gnu.org Received: via spool by 75785-submit@debbugs.gnu.org id=B75785.17376505441152 (code B ref 75785); Thu, 23 Jan 2025 16:43:02 +0000 Received: (at 75785) by debbugs.gnu.org; 23 Jan 2025 16:42:24 +0000 Received: from localhost ([127.0.0.1]:42076 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tb0Hf-0000IU-Pc for submit@debbugs.gnu.org; Thu, 23 Jan 2025 11:42:24 -0500 Received: from mout02.posteo.de ([185.67.36.66]:55317) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tb0HX-0000Hq-9R for 75785@debbugs.gnu.org; Thu, 23 Jan 2025 11:42:16 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 03743240101 for <75785@debbugs.gnu.org>; Thu, 23 Jan 2025 17:42:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1737650529; bh=C+kru2+4Gk7hBZftUIW1Z+IYH6P503Oc6t3yo+tjgzA=; h=MIME-Version:Date:From:To:Cc:Subject:Message-ID:Content-Type: Content-Transfer-Encoding:From; b=JdHq0DOZtea3o8Kpaov09/qs6xLWeVRA8/w81iQt85kaAEPfx2lYJnSNCg4BMCT86 pI0hTYgXl9LMIA4z5nKLYOTrqm9xfItePrc/Egl/8nfCpoaTtDMkY+1Oo89KSUdK6P BQKDEtzUQjLggenFsNUEkRIIGs4RfRB/VQ4uej/zhdsZ+giD7A6e2UAMakvxFXyZLb K65mB0Z+Wl7k89g16MJAiONdnZTUK8X/duN9U5xEzUk9fJ7+ORs535Li4MK6+pTeEn WM0JH/NV2+ZlyYISr2hr3LNxfdGAGqOkkJRBjf8LHB63zabxeO7WNdQ6c0g5gnvP+Z brMZp/JcVTHPQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Yf6DH2G4rz6twF; Thu, 23 Jan 2025 17:42:07 +0100 (CET) MIME-Version: 1.0 Date: Thu, 23 Jan 2025 16:42:07 +0000 From: Gerard Vermeulen In-Reply-To: <8M0L9-M-GTFHsSye9mnZiHp2NY0Td-Q-f-zkTZmOel6CTSQl5HnpiGPqxHuD8IgE-6dX2NRLez59lu6qCVDl-EWvGSKxMZls31kJmofBInw=@rjt.dev> References: <8c3691b709e7919322299afc7552d9d7@posteo.net> <867c6l1suq.fsf@gnu.org> <8M0L9-M-GTFHsSye9mnZiHp2NY0Td-Q-f-zkTZmOel6CTSQl5HnpiGPqxHuD8IgE-6dX2NRLez59lu6qCVDl-EWvGSKxMZls31kJmofBInw=@rjt.dev> Message-ID: Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 23.01.2025 17:22, Randy Taylor wrote: > On Thursday, January 23rd, 2025 at 09:56, Eli Zaretskii > wrote: >> >> >> > Date: Thu, 23 Jan 2025 13:09:45 +0000 >> >> > From: Gerard Vermeulen gerard.vermeulen@posteo.net >> > >> > Hi, >> > >> > Automatic indenting when typing works in go-ts-mode for grouped >> > var declarations like: >> > >> > var ( >> > a = 1 >> > b = 2 >> > ) >> > >> > but not for type declarations (taken from >> > https://github.com/uber-go/guide/blob/master/style.md#group-similar-declarations >> > ) like: >> > >> > type ( >> > Area float64 >> > Volume float64 >> > ) >> > >> > where I have to add the tabs (or spaces) myself. >> > I tried to change "type_spec" to "type_spec_list" in the defvar >> > go-ts-mode--indent-rules expression, but that did not fix it. >> > >> > I am using a recent 30.0.93 git checkout. >> > >> > Can it be fixed? >> >> >> Randy and Yuan, could you please look into this? > > Thanks for the report. > > The attached patch fixes it for me. For me too. Thanks. From unknown Tue Jun 17 22:20:19 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Gerard Vermeulen Subject: bug#75785: closed (Re: bug#75785: 30.0.93: grouped type declarations fail to indent in go-ts-mode) Message-ID: References: <86sep9zb5h.fsf@gnu.org> <8c3691b709e7919322299afc7552d9d7@posteo.net> X-Gnu-PR-Message: they-closed 75785 X-Gnu-PR-Package: emacs Reply-To: 75785@debbugs.gnu.org Date: Thu, 23 Jan 2025 17:36:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1737653762-11107-1" This is a multi-part message in MIME format... ------------=_1737653762-11107-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #75785: 30.0.93: grouped type declarations fail to indent in go-ts-mode which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 75785@debbugs.gnu.org. --=20 75785: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D75785 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1737653762-11107-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 75785-done) by debbugs.gnu.org; 23 Jan 2025 17:35:20 +0000 Received: from localhost ([127.0.0.1]:42181 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tb16u-0002rw-1r for submit@debbugs.gnu.org; Thu, 23 Jan 2025 12:35:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46732) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tb16r-0002mR-So for 75785-done@debbugs.gnu.org; Thu, 23 Jan 2025 12:35:18 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tb16k-0007Je-UB; Thu, 23 Jan 2025 12:35:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=OimoB+ZKSRfxZE3z8fNpUB6ZK059YCoqx50J//SO9eo=; b=IXDr60PtnzfJ lxu1GqIewgRX7bgco1jk40fARNfw52RinFc6RGPNxvDD63LtpRbyW4BFR6VBddnFipMElJkl5vHKf b1O3RrR/EYsbacQyWEFuxXCzeNomD0Bwrele3T5pzttPYZxp3QYlsIbxNE66AZjole/QR+cV74V+3 AKSwq6D2/VW6HSH48WEtUI65Qyj7E+mciY+ClLKqdEVCDPOIvsuIPK6b41LDN1Rqc8aeUxClTvk6x fETwavD2/9K1fNJwZt3FFZT0JpG7nFLIcocTrrFO6io1Zc5FgflWgdwfEVZiIgbKipd4FOt+/Qrw5 flVDeGiXdS4t1UvE86ufAw==; Date: Thu, 23 Jan 2025 19:35:06 +0200 Message-Id: <86sep9zb5h.fsf@gnu.org> From: Eli Zaretskii To: Gerard Vermeulen In-Reply-To: (message from Gerard Vermeulen on Thu, 23 Jan 2025 16:42:07 +0000) Subject: Re: bug#75785: 30.0.93: grouped type declarations fail to indent in go-ts-mode References: <8c3691b709e7919322299afc7552d9d7@posteo.net> <867c6l1suq.fsf@gnu.org> <8M0L9-M-GTFHsSye9mnZiHp2NY0Td-Q-f-zkTZmOel6CTSQl5HnpiGPqxHuD8IgE-6dX2NRLez59lu6qCVDl-EWvGSKxMZls31kJmofBInw=@rjt.dev> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75785-done Cc: dev@rjt.dev, casouri@gmail.com, 75785-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 23 Jan 2025 16:42:07 +0000 > From: Gerard Vermeulen > Cc: Eli Zaretskii , Yuan Fu , > 75785@debbugs.gnu.org > > > > On 23.01.2025 17:22, Randy Taylor wrote: > > On Thursday, January 23rd, 2025 at 09:56, Eli Zaretskii > > wrote: > >> > >> > >> > Date: Thu, 23 Jan 2025 13:09:45 +0000 > >> > >> > From: Gerard Vermeulen gerard.vermeulen@posteo.net > >> > > >> > Hi, > >> > > >> > Automatic indenting when typing works in go-ts-mode for grouped > >> > var declarations like: > >> > > >> > var ( > >> > a = 1 > >> > b = 2 > >> > ) > >> > > >> > but not for type declarations (taken from > >> > https://github.com/uber-go/guide/blob/master/style.md#group-similar-declarations > >> > ) like: > >> > > >> > type ( > >> > Area float64 > >> > Volume float64 > >> > ) > >> > > >> > where I have to add the tabs (or spaces) myself. > >> > I tried to change "type_spec" to "type_spec_list" in the defvar > >> > go-ts-mode--indent-rules expression, but that did not fix it. > >> > > >> > I am using a recent 30.0.93 git checkout. > >> > > >> > Can it be fixed? > >> > >> > >> Randy and Yuan, could you please look into this? > > > > Thanks for the report. > > > > The attached patch fixes it for me. > > For me too. Thanks. Thanks, so I'm now closing this bug. ------------=_1737653762-11107-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 23 Jan 2025 13:10:09 +0000 Received: from localhost ([127.0.0.1]:39841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tawyH-0003Ab-8V for submit@debbugs.gnu.org; Thu, 23 Jan 2025 08:10:09 -0500 Received: from lists.gnu.org ([2001:470:142::17]:43740) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tawyD-00039v-5t for submit@debbugs.gnu.org; Thu, 23 Jan 2025 08:10:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tawy4-0007B8-9s for bug-gnu-emacs@gnu.org; Thu, 23 Jan 2025 08:09:56 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tawy1-0000EO-3t for bug-gnu-emacs@gnu.org; Thu, 23 Jan 2025 08:09:55 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 0C27C240101 for ; Thu, 23 Jan 2025 14:09:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1737637786; bh=WEeFHvG1QCuizflWsVsc8FR9Fj5gQG1VSAsiQucYHBo=; h=MIME-Version:Date:From:To:Subject:Message-ID:Content-Type: Content-Transfer-Encoding:From; b=Ra7ttxmpzScaUPxxoFXIVVgBCaHdgls1heSQRvFSN3R9GnYB7X4Hbt2kJ6P2UmP8/ 1ehnyqIdE5wxBpwtzUCCsFT2KNl9+NYo32P+Vd3EBs/vgzqHubDzPtKZf1dPUzPh4S 0BWNJxZOSg4lSjuWGcvEzpvwXTux4fGuYAnZbDwddtId7QOP8ihrvx6YZIc89gtX+q j81yd+S1XXR02Rpsh08iOqJx1+3SU8Jhiz2tQyQN/V3ohYdeSQlF4GzRR+dXB/xYNI y7J2bfW/FwYZvla3H35bkdAvV1Sa6pHMTUxjrfb7KwtgnyQMkUr3xBpkHp0Iuce1CX 7Bkox6CfgRCDQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Yf1WF4JVWz9rxL for ; Thu, 23 Jan 2025 14:09:45 +0100 (CET) MIME-Version: 1.0 Date: Thu, 23 Jan 2025 13:09:45 +0000 From: Gerard Vermeulen To: Bug gnu emacs Subject: 30.0.93: grouped type declarations fail to indent in go-ts-mode Message-ID: <8c3691b709e7919322299afc7552d9d7@posteo.net> Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=185.67.36.66; envelope-from=gerard.vermeulen@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi, Automatic indenting when typing works in go-ts-mode for grouped var declarations like: var ( a = 1 b = 2 ) but not for type declarations (taken from https://github.com/uber-go/guide/blob/master/style.md#group-similar-declarations ) like: type ( Area float64 Volume float64 ) where I have to add the tabs (or spaces) myself. I tried to change "type_spec" to "type_spec_list" in the defvar go-ts-mode--indent-rules expression, but that did not fix it. I am using a recent 30.0.93 git checkout. Can it be fixed? Best regards -- Gerard ------------=_1737653762-11107-1--