GNU bug report logs - #7578
23.2.90; [PATCH] Move ESHELL directory inside .emacs.d

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 7578 in the body.
You can then email your comments to 7578 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.2.90; [PATCH] Move ESHELL directory inside .emacs.d
Date: Tue, 07 Dec 2010 10:26:28 +0000

It seems better for emacs not to litter the user's HOME.

commit 3a9f8163e6eeefd00fc6fe5a531049c22c7acf79 (HEAD, refs/heads/leo-main)
Date:   Tue Dec 7 10:21:18 2010 +0000

    Tweak eshell-directory-name

	Modified lisp/eshell/eshell.el
diff --git a/lisp/eshell/eshell.el b/lisp/eshell/eshell.el
index 74f65d2..f8cf9dc 100644
--- a/lisp/eshell/eshell.el
+++ b/lisp/eshell/eshell.el
@@ -285,7 +285,8 @@ shells such as bash, zsh, rc, 4dos."
   "`eshell-buffer-name' is a member of `same-window-buffer-names'"
   (member eshell-buffer-name same-window-buffer-names))
 
-(defcustom eshell-directory-name (convert-standard-filename "~/.eshell/")
+(defcustom eshell-directory-name
+  (locate-user-emacs-file "eshell/" ".eshell/")
   "The directory where Eshell control files should be kept."
   :type 'directory
   :group 'eshell)

Message #8 received at 7578 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Leo <sdl.web <at> gmail.com>
Cc: 7578 <at> debbugs.gnu.org
Subject: Re: bug#7578: 23.2.90; [PATCH] Move ESHELL directory inside .emacs.d
Date: Mon, 13 Dec 2010 11:58:39 -0500

> 	Modified lisp/eshell/eshell.el
> diff --git a/lisp/eshell/eshell.el b/lisp/eshell/eshell.el
> index 74f65d2..f8cf9dc 100644
> --- a/lisp/eshell/eshell.el
> +++ b/lisp/eshell/eshell.el
> @@ -285,7 +285,8 @@ shells such as bash, zsh, rc, 4dos."
>    "`eshell-buffer-name' is a member of `same-window-buffer-names'"
>    (member eshell-buffer-name same-window-buffer-names))
 
> -(defcustom eshell-directory-name (convert-standard-filename "~/.eshell/")
> +(defcustom eshell-directory-name
> +  (locate-user-emacs-file "eshell/" ".eshell/")
>    "The directory where Eshell control files should be kept."
>    :type 'directory
>    :group 'eshell)

That's a good change, yes.  Feel free to install it.


        Stefan

Message #11 received at 7578 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Leo <sdl.web <at> gmail.com>
Cc: 7578 <at> debbugs.gnu.org
Subject: Re: bug#7578: 23.2.90; [PATCH] Move ESHELL directory inside .emacs.d
Date: Thu, 16 Dec 2010 10:28:27 +0800

Leo <sdl.web <at> gmail.com> writes:

> It seems better for emacs not to litter the user's HOME.

Thanks, committed to the trunk.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.