GNU bug report logs - #75775
30.0.93; [PATCH] Restore the old behavior of `bookmark-write-file'

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#75775: closed (30.0.93; [PATCH] Restore the old behavior of
 `bookmark-write-file')
Date: Sat, 25 Jan 2025 14:00:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 25 Jan 2025 15:59:13 +0200
with message-id <86zfjft2oe.fsf <at> gnu.org>
and subject line Re: bug#75775: 30.0.93; [PATCH] Restore the old behavior of `bookmark-write-file'
has caused the debbugs.gnu.org bug report #75775,
regarding 30.0.93; [PATCH] Restore the old behavior of `bookmark-write-file'
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
75775: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=75775
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Zhengyi Fu  <i <at> fuzy.me>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.93; [PATCH] Restore the old behavior of `bookmark-write-file'
Date: Thu, 23 Jan 2025 13:45:11 +0800

[Message part 3 (text/plain, inline)]

`pp' now defaults to fill the code to fit in `fill-column', which is
great.  However, this changed the bookmark format and made it less
human-readable and unfriendly to version control.   This small patch
restores the old behavior of `bookmark-write-file'.

[0001-Restore-the-old-behavior-of-bookmark-write-file.patch (text/x-diff, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: i <at> fuzy.me, 75775-done <at> debbugs.gnu.org
Subject: Re: bug#75775: 30.0.93; [PATCH] Restore the old behavior of
 `bookmark-write-file'
Date: Sat, 25 Jan 2025 15:59:13 +0200

> From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Cc: Zhengyi Fu <i <at> fuzy.me>,  75775 <at> debbugs.gnu.org
> Date: Sat, 25 Jan 2025 07:18:43 -0500
> 
> > I'm not sure we should use such kludges just because the new default
> > changes the whitespace.  But if we do make any changes, we should do
> > it ASAP, since the change in pp's behavior was introduced in Emacs 30.
> >
> > Stefan, WDYT?
> 
> No specific opinion.  My understanding is that we should introduce some
> kind of `pp-fast` function, but in the mean time hacks like this patch
> seem fine to me.

Thanks, installed on the emacs-30 branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.