GNU bug report logs - #75764
30.0.50; [PATCH] java-ts-mode: Constant highlighting no longer captures Java annotations.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Vincenzo Pupillo <v.pupillo <at> gmail.com>
Subject: bug#75764: closed (Re: bug#75764: 30.0.50; [PATCH] java-ts-mode:
 Constant highlighting no longer captures Java annotations.)
Date: Sun, 23 Feb 2025 19:50:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#75764: 30.0.50; [PATCH] java-ts-mode: Constant highlighting no longer captures Java annotations.

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 75764 <at> debbugs.gnu.org.

-- 
75764: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=75764
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Yuan Fu <casouri <at> gmail.com>, v.pupillo <at> gmail.com, theo <at> thornhill.no,
 75764-done <at> debbugs.gnu.org
Subject: Re: bug#75764: 30.0.50; [PATCH] java-ts-mode: Constant highlighting
 no longer captures Java annotations.
Date: Sun, 23 Feb 2025 19:49:01 +0000

Version: 30.2

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Yuan Fu <casouri <at> gmail.com>
>> Date: Mon, 27 Jan 2025 17:35:30 -0800
>> Cc: Vincenzo Pupillo <v.pupillo <at> gmail.com>,
>>  Theodor Thornhill <theo <at> thornhill.no>,
>>  75764 <at> debbugs.gnu.org
>>
>> Seems reasonable to me. Tree-sitter’s query doesn’t support negation match, so
>> we can’t match constants that are not annotations. But I don’t want these
>> fixes to delay emacs 30 (they will keep coming), so perhaps we can apply this
>> to emacs-30 after release, WDYT, Eli?
>
> Fine by me, thanks.

Since Emacs 30.1 is now released, I have pushed this to emacs-30 as
commit 563b6f94511.

I'm therefore closing this bug report.

[Message part 3 (message/rfc822, inline)]

From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50;
 [PATCH] java-ts-mode: Constant highlighting no longer captures Java
 annotations.
Date: Wed, 22 Jan 2025 16:38:20 +0100

[Message part 4 (text/plain, inline)]

Ciao,
the attached patch fixes a problem with highlighting constants in java-ts 
mode. Annotations such as @GET were previously being captured by the regular 
expression used for constants. 
The patch can be safely applied to Emacs 31.

Thanks.

Vincenzo

[0001-Constant-highlighting-no-longer-captures-Java-annota.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.