GNU bug report logs - #75755
feature/igc: Missing IGC_CHECK_RES?

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Pip Cet <pipcet <at> protonmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#75755: closed (feature/igc: Missing IGC_CHECK_RES?)
Date: Thu, 06 Feb 2025 00:27:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 06 Feb 2025 00:25:47 +0000
with message-id <87seorhqby.fsf <at> protonmail.com>
and subject line Re: bug#75755: feature/igc: Missing IGC_CHECK_RES?
has caused the debbugs.gnu.org bug report #75755,
regarding feature/igc: Missing IGC_CHECK_RES?
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
75755: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=75755
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Stefan Kangas <stefankangas <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: feature/igc: Missing IGC_CHECK_RES?
Date: Wed, 22 Jan 2025 04:27:35 -0600

Gerd, do you remember why you didn't add CHECK_RES here?  Was there a
reason for that or just an oversight?

diff --git a/src/igc.c b/src/igc.c
index 257e7dc53f7..b6d42c9fbe1 100644
--- a/src/igc.c
+++ b/src/igc.c
@@ -3129,9 +3129,11 @@ create_thread_aps (struct igc_thread *t)
   res = mps_ap_create_k (&t->immovable_ap, gc->immovable_pool, mps_args_none);
   IGC_CHECK_RES (res);
   res = create_weak_ap (&t->weak_strong_ap, t, false);
+  IGC_CHECK_RES (res);
   res = create_weak_hash_ap (&t->weak_hash_strong_ap, t, false);
   IGC_CHECK_RES (res);
   res = create_weak_ap (&t->weak_weak_ap, t, true);
+  IGC_CHECK_RES (res);
   res = create_weak_hash_ap (&t->weak_hash_weak_ap, t, true);
   IGC_CHECK_RES (res);
 }

[Message part 3 (message/rfc822, inline)]

From: Pip Cet <pipcet <at> protonmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: gerd <at> gnu.org, eller.helmut <at> gmail.com, gerd.moellmann <at> gmail.com,
 75755-done <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>, acorallo <at> gnu.org
Subject: Re: bug#75755: feature/igc: Missing IGC_CHECK_RES?
Date: Thu, 06 Feb 2025 00:25:47 +0000

"Stefan Kangas" <stefankangas <at> gmail.com> writes:

> Eli Zaretskii <eliz <at> gnu.org> writes:
>
>>> From: Stefan Kangas <stefankangas <at> gmail.com>
>>> Date: Thu, 23 Jan 2025 15:32:16 -0600
>>> Cc: pipcet <at> protonmail.com, gerd.moellmann <at> gmail.com, 75755 <at> debbugs.gnu.org,
>>> 	gerd <at> gnu.org, eller.helmut <at> gmail.com, acorallo <at> gnu.org
>>>
>>> >> Please let me know what you think of my most recent patch.  If you want
>>> >> something different, may I ask that you send a patch?  I don't think
>>> >> I understand if your idea is different from what I posted.  Thanks.
>>> >
>>> > Your patch still uses _mps_RES_ENUM, which is a macro that's not
>>> > supposed to be used outside of MPS.  Isn't that so?  I thought all
>>> > this discussion was how to avoid using that macro, wasn't it?
>>>
>>> AFAIU, the patch I proposed removes that macro.  I just now grepped for
>>> _mps_RES_ENUM after applying it, and couldn't find any matches in my
>>> tree.  Are you seeing something different?
>>
>> Yes, I was looking at a stale igc.c, so I didn't see that
>> mps_res_to_string was modified exactly as I suggested to do.
>
> No problem, and thanks.  Installed on feature/igc as commit 2ce718a5274.

I'm closing this, because I think the original issue, and the enum
followup discussions, have both been resolved :-)

Pip

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.