GNU bug report logs - #75755
feature/igc: Missing IGC_CHECK_RES?

Previous Next

Package: emacs;

Reported by: Stefan Kangas <stefankangas <at> gmail.com>

Date: Wed, 22 Jan 2025 10:28:02 UTC

Severity: normal

Done: Pip Cet <pipcet <at> protonmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 75755 <at> debbugs.gnu.org, gerd <at> gnu.org
Subject: bug#75755: feature/igc: Missing IGC_CHECK_RES?
Date: Wed, 22 Jan 2025 11:59:08 +0100

Stefan Kangas <stefankangas <at> gmail.com> writes:

> Gerd, do you remember why you didn't add CHECK_RES here?  Was there a
> reason for that or just an oversight?
>
> diff --git a/src/igc.c b/src/igc.c
> index 257e7dc53f7..b6d42c9fbe1 100644
> --- a/src/igc.c
> +++ b/src/igc.c
> @@ -3129,9 +3129,11 @@ create_thread_aps (struct igc_thread *t)
>    res = mps_ap_create_k (&t->immovable_ap, gc->immovable_pool, mps_args_none);
>    IGC_CHECK_RES (res);
>    res = create_weak_ap (&t->weak_strong_ap, t, false);
> +  IGC_CHECK_RES (res);
>    res = create_weak_hash_ap (&t->weak_hash_strong_ap, t, false);
>    IGC_CHECK_RES (res);
>    res = create_weak_ap (&t->weak_weak_ap, t, true);
> +  IGC_CHECK_RES (res);
>    res = create_weak_hash_ap (&t->weak_hash_weak_ap, t, true);
>    IGC_CHECK_RES (res);
>  }

Looks like Pip added new APs in 9c9b7a293f27eab3382c434b29eb9c97cb673432
and forgot the checks.
This bug report was last modified 163 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.