GNU bug report logs - #75716
[PATCH 1/2] gnu: go-1.23: Skip time variant tests

Previous Next

Package: guix-patches;

Reported by: Ryan Sundberg <ryan <at> arctype.co>

Date: Tue, 21 Jan 2025 00:08:01 UTC

Severity: normal

Tags: patch

Done: Sharlatan Hellseher <sharlatanus <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #11 received at 75716 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 75716 <at> debbugs.gnu.org
Subject: [PATCH 1/2] gnu: go-1.23: Skip time variant tests
Date: Tue, 21 Jan 2025 23:55:40 +0000
[Message part 1 (text/plain, inline)]
Hi,

Thanks for picking this up.

The issue is currently resolved on go-team branch with this change:

--8<---------------cut here---------------start------------->8---
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index cfe9784e8b..267681f551 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -841,6 +841,24 @@ in the style of communicating sequential processes (@dfn{CSP}).")
         #~(modify-phases #$phases
             (delete 'skip-TestGoPathShlibGccgo-tests)
             (delete 'patch-source)
+            ;; Time bomb in TLS tests: "Most of the test certificates
+            ;; (e.g. testRSACertificate, testRSACertificateIssuer,
+            ;; testRSA2048CertificateIssuer) have a not after of Jan 1
+            ;; 00:00:00 2025 GMT."
+            ;; https://github.com/golang/go/issues/71077
+            ;; https://github.com/golang/go/issues/71103
+            ;; https://github.com/golang/go/issues/71104
+            (add-after 'unpack 'skip-crypto-tls-tests
+              (lambda _
+                (substitute* (list "src/crypto/tls/handshake_client_test.go"
+                                   "src/crypto/tls/handshake_server_test.go")
+                  (("TestVerifyConnection.*" all)
+                   (string-append all "\n        t.Skip(\"golang.org/issue/71077\")\n"))
+                  (("TestResumptionKeepsOCSPAndSCT.*" all)
+                   (string-append all "\n        t.Skip(\"golang.org/issue/71077\")\n"))
+                  (("TestCrossVersionResume.*" all)
+                   (string-append all "\n        t.Skip(\"golang.org/issue/71077\")\n")))))
--8<---------------cut here---------------end--------------->8---

The branch is on it's way to master https://issues.guix.gnu.org/75467

--
Thanks,
Oleg
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 119 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.