From unknown Sun Jun 22 07:54:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#75716] [PATCH 1/2] gnu: go-1.23: Skip time variant tests Resent-From: Ryan Sundberg Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 21 Jan 2025 00:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 75716 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 75716@debbugs.gnu.org Cc: Ryan Sundberg X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.173741803710974 (code B ref -1); Tue, 21 Jan 2025 00:08:01 +0000 Received: (at submit) by debbugs.gnu.org; 21 Jan 2025 00:07:17 +0000 Received: from localhost ([127.0.0.1]:52323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ta1nY-0002qw-Kh for submit@debbugs.gnu.org; Mon, 20 Jan 2025 19:07:17 -0500 Received: from lists.gnu.org ([2001:470:142::17]:46078) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ta1nW-0002qf-AD for submit@debbugs.gnu.org; Mon, 20 Jan 2025 19:07:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ta1nQ-0000uD-Nu for guix-patches@gnu.org; Mon, 20 Jan 2025 19:07:08 -0500 Received: from mail.arctype.co ([138.68.9.245]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ta1nJ-0005XD-TV for guix-patches@gnu.org; Mon, 20 Jan 2025 19:07:08 -0500 Received: from authenticated-user (mail.arctype.co [138.68.9.245]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by mail.arctype.co (Postfix) with ESMTPSA id 4633813B0EB; Tue, 21 Jan 2025 00:06:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=arctype.co; s=mail; t=1737417990; bh=lkxsq458/CNu1vh8jJx/mcOps/6qkFVBxAUa4dfbPQg=; h=From:To:Cc:Subject:Date:From; b=jfmBpYDLiNpL3H0nbTIkFOXeeQPyna+Npl+hdFqtmAjFkMViTJhRS1wswIOKR0dUy OOGsp8cY68sSiEJSps95nKG2K9uWz0CzwRLuhLiG9HweL+fyOPXZLEfMNeXrhw5mbX PSKbvaJnUg6Qxjjg84pFhW+G+vGyZx6vDrYuUzpa9RdhRzqACiaIJXqFQuL71x+poX fvau9jF+M9VhYG31vCmoZE0ICKSIFQ96sEvDyNYVvA6CSn5opWnV4C36K9nZoh0+M+ 3+7HwdjPdSZY+NJSSi39Cj/28CjJ7ZekYg53lzYJbe/ibCCdqaTeM2AOLcSqV78olK AKq6Xay7iSu/g== From: Ryan Sundberg Date: Mon, 20 Jan 2025 16:06:04 -0800 Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=138.68.9.245; envelope-from=ryan@arctype.co; helo=mail.arctype.co X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Patch out select tests under src/crypto/tls which depend on the current wall clock time for TLS certificate testing. Specifically, the following failing test cases are skipped: ``` Change-Id: I2f1519bc1c951e15db3a1c9320148206674c7bdf --- FAIL: TestVerifyConnection (0.00s) --- FAIL: TestVerifyConnection/TLSv12 (0.00s) handshake_client_test.go:1759: RequireAndVerifyClientCert-FullHandshake: handshake failed: server: remote error: tls: bad certificate client: tls: failed to verify certificate: x509: certificate has expired or is not yet valid: current time 2025-01-20T20:07:09Z is after 2025-01-01T00:00:00Z --- FAIL: TestVerifyConnection/TLSv13 (0.00s) handshake_client_test.go:1759: RequireAndVerifyClientCert-FullHandshake: handshake failed: server: remote error: tls: bad certificate client: tls: failed to verify certificate: x509: certificate has expired or is not yet valid: current time 2025-01-20T20:07:09Z is after 2025-01-01T00:00:00Z --- FAIL: TestResumptionKeepsOCSPAndSCT (0.00s) --- FAIL: TestResumptionKeepsOCSPAndSCT/TLSv12 (0.00s) handshake_client_test.go:2550: handshake failed: server: remote error: tls: bad certificate client: tls: failed to verify certificate: x509: certificate has expired or is not yet valid: current time 2025-01-20T20:07:09Z is after 2025-01-01T00:00:00Z --- FAIL: TestResumptionKeepsOCSPAndSCT/TLSv13 (0.00s) handshake_client_test.go:2550: handshake failed: server: remote error: tls: bad certificate client: tls: failed to verify certificate: x509: certificate has expired or is not yet valid: current time 2025-01-20T20:07:09Z is after 2025-01-01T00:00:00Z --- FAIL: TestCrossVersionResume (0.01s) --- FAIL: TestCrossVersionResume/TLSv12 (0.00s) handshake_server_test.go:526: handshake did not resume at the same version --- FAIL: TestCrossVersionResume/TLSv13 (0.00s) handshake_server_test.go:526: handshake did not resume at the same version FAIL FAIL crypto/tls 0.423s ``` * gnu/packages/golang (go-1.23): Include patchset * gnu/packages/patches/go-skip-tls-tests.patch: New patch file --- gnu/packages/golang.scm | 16 +++++- gnu/packages/patches/go-skip-tls-tests.patch | 56 ++++++++++++++++++++ 2 files changed, 71 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/go-skip-tls-tests.patch diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index b1ea9e5a28..d39e50e982 100644 --- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -1001,7 +1001,21 @@ (define-public go-1.23 (commit (string-append "go" version)))) (file-name (git-file-name name version)) (sha256 - (base32 "0v8j43yqkhp5i5649nbxsq7lc9bjjn39gqqvlnz0d9c47qz9h7y7")))))) + (base32 "0v8j43yqkhp5i5649nbxsq7lc9bjjn39gqqvlnz0d9c47qz9h7y7")))) + (arguments + (substitute-keyword-arguments (package-arguments go-1.22) + ((#:phases phases) + #~(modify-phases #$phases + (add-after 'unpack 'apply-skip-test-patch + (lambda* (#:key inputs #:allow-other-keys) + ;; Having the patch in the 'patches' field of breaks + ;; the 'TestServeContent' test due to the fact that timestamps + ;; are reset. Thus, apply it from here. + (invoke "patch" "-p1" "--force" "-i" + (assoc-ref inputs "go-skip-tls-tests.patch")))))))) + (native-inputs + `(("go-skip-tls-tests.patch" ,(search-patch "go-skip-tls-tests.patch")) + ,@(package-native-inputs go-1.22))))) ;; ;; Default Golang version used in guix/build-system/go.scm to build packages. diff --git a/gnu/packages/patches/go-skip-tls-tests.patch b/gnu/packages/patches/go-skip-tls-tests.patch new file mode 100644 index 0000000000..92e0a31a86 --- /dev/null +++ b/gnu/packages/patches/go-skip-tls-tests.patch @@ -0,0 +1,56 @@ +From 0b0cb6aa447cef0e4f631e43db05195d0d25329a Mon Sep 17 00:00:00 2001 +From: Ryan Sundberg +Date: Mon, 20 Jan 2025 15:17:39 -0800 +Subject: [PATCH] crypto/tls: Disable test cases which are time variant + +These test cases depend on the current date relative to the TLS +certificates under test. Skip them for repeatability. +--- + src/crypto/tls/handshake_client_test.go | 8 ++++---- + src/crypto/tls/handshake_server_test.go | 4 ++-- + 2 files changed, 6 insertions(+), 6 deletions(-) + +diff --git a/src/crypto/tls/handshake_client_test.go b/src/crypto/tls/handshake_client_test.go +index 3c87916bcf..fa2a494a6b 100644 +--- a/src/crypto/tls/handshake_client_test.go ++++ b/src/crypto/tls/handshake_client_test.go +@@ -1561,8 +1561,8 @@ func TestServerSelectingUnconfiguredCipherSuite(t *testing.T) { + } + + func TestVerifyConnection(t *testing.T) { +- t.Run("TLSv12", func(t *testing.T) { testVerifyConnection(t, VersionTLS12) }) +- t.Run("TLSv13", func(t *testing.T) { testVerifyConnection(t, VersionTLS13) }) ++ // t.Run("TLSv12", func(t *testing.T) { testVerifyConnection(t, VersionTLS12) }) ++ // t.Run("TLSv13", func(t *testing.T) { testVerifyConnection(t, VersionTLS13) }) + } + + func testVerifyConnection(t *testing.T, version uint16) { +@@ -2528,8 +2528,8 @@ func TestDowngradeCanary(t *testing.T) { + } + + func TestResumptionKeepsOCSPAndSCT(t *testing.T) { +- t.Run("TLSv12", func(t *testing.T) { testResumptionKeepsOCSPAndSCT(t, VersionTLS12) }) +- t.Run("TLSv13", func(t *testing.T) { testResumptionKeepsOCSPAndSCT(t, VersionTLS13) }) ++ //t.Run("TLSv12", func(t *testing.T) { testResumptionKeepsOCSPAndSCT(t, VersionTLS12) }) ++ //t.Run("TLSv13", func(t *testing.T) { testResumptionKeepsOCSPAndSCT(t, VersionTLS13) }) + } + + func testResumptionKeepsOCSPAndSCT(t *testing.T, ver uint16) { +diff --git a/src/crypto/tls/handshake_server_test.go b/src/crypto/tls/handshake_server_test.go +index bbfe44bd97..4347c40a6d 100644 +--- a/src/crypto/tls/handshake_server_test.go ++++ b/src/crypto/tls/handshake_server_test.go +@@ -493,8 +493,8 @@ func testSCTHandshake(t *testing.T, version uint16) { + } + + func TestCrossVersionResume(t *testing.T) { +- t.Run("TLSv12", func(t *testing.T) { testCrossVersionResume(t, VersionTLS12) }) +- t.Run("TLSv13", func(t *testing.T) { testCrossVersionResume(t, VersionTLS13) }) ++ //t.Run("TLSv12", func(t *testing.T) { testCrossVersionResume(t, VersionTLS12) }) ++ //t.Run("TLSv13", func(t *testing.T) { testCrossVersionResume(t, VersionTLS13) }) + } + + func testCrossVersionResume(t *testing.T, version uint16) { +-- +2.41.0 + base-commit: 91b18baa4274a025d28f06133682a9269217730d -- 2.41.0 From unknown Sun Jun 22 07:54:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#75716] [PATCH 1/2] gnu: go-1.23: Skip time variant tests References: In-Reply-To: Resent-From: Sharlatan Hellseher Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 21 Jan 2025 23:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75716 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 75716@debbugs.gnu.org Cc: Ryan Sundberg Received: via spool by 75716-submit@debbugs.gnu.org id=B75716.173750316627517 (code B ref 75716); Tue, 21 Jan 2025 23:47:01 +0000 Received: (at 75716) by debbugs.gnu.org; 21 Jan 2025 23:46:06 +0000 Received: from localhost ([127.0.0.1]:58141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1taNwc-00079i-Ad for submit@debbugs.gnu.org; Tue, 21 Jan 2025 18:46:06 -0500 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]:43187) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1taNwT-000795-Io for 75716@debbugs.gnu.org; Tue, 21 Jan 2025 18:46:02 -0500 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4363dc916ceso1892975e9.0 for <75716@debbugs.gnu.org>; Tue, 21 Jan 2025 15:45:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737503151; x=1738107951; darn=debbugs.gnu.org; h=mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=iXhmJTD/CYGrSMajaQaMcYb4F/6VwACsBKRBTw78F8Q=; b=OD19KKJur9bGANTXx4xFbJD2p3UPZeBdfkN0+wCxVBe9yYqSlNO0R1p9u23iLZjDgJ dDvoZpLkEhslfEYjy1d+u+Vc1adrAxD1l0V88IdSj3k6402HvYAKUlaOxDBzpaPSwdoS gvxh05jZgt8bYDk3G2Z3CbSSO+N1yXJZa3vmnZe1t8SnRZXL/hvIIxB9UztwT3ailzOy se2hfOJ/OVyuODl6CE/QoGtnKVAqbZ2+nIqDrjkwQdsu9i/2hEFlf7rdI1WBwOT+ypiL 8ngy7/pnIGP0Tma5k6KDdxUGq9mHHp6dw2DdjwBrIiGYM4CiOZHUm7MQHYHRRwCR7zvo oz0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737503151; x=1738107951; h=mime-version:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=iXhmJTD/CYGrSMajaQaMcYb4F/6VwACsBKRBTw78F8Q=; b=nLmzhFsRwUaKu1u2TPufB6JB0rXzNLMtQanSzD8/9e93yc0g6TfI9YMq0Ym4zcTVQY O3bIAGx6uSwMKxuDmgykTIGgd0Gxmqy0oslg9KsGgil0xgzlossDYIRDwDP6h5c/tauR D7Kq88Qxtic/5csvM/oyGOwc4Xf9MKyAG/u+k8rx8g+jzwAkovifkCjsr9xqRFv9NJ86 dUjUxAjP1Z219epcrh9wKZA22hFSdwakVgzq3eAIiLeoyN5iMQcyOkhY25Db3rNsxsar pSUfdqU+n3Tzrx8XKdXxjD8/9RQRhZgEB/ZTsHqTtKhLkKcMG4CejMZJQY20pK5VHYVd LdKg== X-Gm-Message-State: AOJu0YxNNuLW8TeAD9xnTpLYgK3aKH37ARKI+eQpA8d0xaLh4Cj9PX1n lq9WvEuuLs/Hl/nvVSUJhsc+mrhY3KPy/UAo7b1YzwTiYh0WOdOIhbVlyxmm X-Gm-Gg: ASbGncscOqYgmpqV+v34BEboaVpD2shdClz7Gc93efvF5BirfDgmfVlI7nhl2St02QK paU2K2G1a6HJpYOED5BC8pP31xRTgDDF60Dli2X/r7OkemxiQbm3kA93kq8Ht4P3NhAXxUdYrjI +7vY+iHNHWLfKbG3rVHJ3lq5hqxVYgQ3Ib3TTh8G5LUShB6ZL1dTi+y5L5/2lPCyI5lKfVVpTGs qZsdtWfkvDv/FLU3wAvVli3cmsNz8wDoe/uUwsoXBGUCsQ+T5M2tVPBKSAHbafnZbwF9o9s3+gX T4G9OjEqf11WLmIU8X96AAA1qT5v8d7cNMn+NtE7BigEnQ== X-Google-Smtp-Source: AGHT+IE44nts+kInOc1TJhd8S/NjtlVXuaNHmclr34avRojTr6kV0WnUIxfXUJVD59UpgusghcuCAw== X-Received: by 2002:a05:6000:1fa5:b0:38a:88d0:1c9c with SMTP id ffacd0b85a97d-38bf5aeb3bfmr16881911f8f.17.1737503150790; Tue, 21 Jan 2025 15:45:50 -0800 (PST) Received: from guxtil (cpc100684-bagu15-2-0-cust967.1-3.cable.virginm.net. [86.8.111.200]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf322a506sm14430242f8f.41.2025.01.21.15.45.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2025 15:45:50 -0800 (PST) From: Sharlatan Hellseher Date: Tue, 21 Jan 2025 23:45:46 +0000 Message-ID: <87ikq7ivdh.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/encrypted; boundary="=-=-="; protocol="application/pgp-encrypted" X-Spam-Score: -1.0 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) --=-=-= Content-Type: application/pgp-encrypted Version: 1 --=-=-= Content-Type: application/octet-stream -----BEGIN PGP MESSAGE----- hQIMA7MNkAS4N2gGARAAipVx+ljlbB5gLFJGTm+pWNu8ODHb4xsQ2et0w2gX2J6i BJZOEo7D1E4+K9NHgBPkPr7Bc1jZvqIyfW57D6ztPcF/W/3WMVWFDGWGsEKdzthe sq5jhYKx+c+NrUr/MOvKxzc5GLN6saaRz7gJf2djc/q5VbkWOqCLnB494bvdPfHJ W7uHJ5nyj104SpWBWieT1jZZJEswXAhC/RVLRHcxo0N2G9zQi0vaeITr6p/+z4h8 8XEE02A9ITNefEnPlRD+kfQ2T98WnibZFiSbA+Hhxtyp1GMNVQltbO72nRXvG0Z3 DrmdKmdqCfvUi+8/vyI9ltOuC1V8MQN3hAjA97uyH2DfEa29sBA3ZmWy1IIyJj/e S7BeSqU4tnLlYGtGqVnYY1TrTKM4OcDeylyJIl1yAR3ejtmBctOEs8AXCn4UcI0f JbeLFkA8k5IGLPRgYcjbfFCs1bYJzoGhjzun/8YiOHB9JBMl0fmZ4ldJDxdpUHOx gu8c+SexWfCYtGzwYX3qU4NUmUuD8ecrn8+YKIOlzTaYz9ZymjQLBRry5hEduw2J Hti7nzEBdbJaF5i/UoBkSyhS119rwDWiGo+XidAyPhhh17ay0T13pbnvY1wo6Dwk BfRsbCqnXROhutO9QCpBj8XKN8sxG8amUScDp5BI691N5oRMiVoGqQXdkdyrOSvS 6QGDoGHR2JsUxYEap8wRFZWpaJJcZ2/HrbdWSabvfbjlsA56URdHspwM7Kaq/0sX GNnoQ3RtxAXqiScC6bG2FmR8nui2UMG6b8YHuzcP/bzpd1IgamrTuf6ELVaAZS1m pwyWPH1fVxuZRBfyHhVQPsBzWJILF5C7rJXi3nrT///LaCSqi4S3kLzLVH/0qxfI Us2y3daKLuvfZyAwsRgJ/ekRp4zHMfmgnCBNx1E/fYRM2rcfs9ZxRJxJDrPJZz0U +APp10ZMklFecrLvUWK9vCM1WFL1wtL/AcDEnSD72TIAiuMHPop2PvjOgIaRNUrn 0blj+21MdQDLUxI+CTpUiQixLiKOVrqAmxKc1lpeZDXaAzAdCC7Epmf6uV4koJzW XmCGdTQxdPscwD76imtJBZhVeP0UxfcbFRcCrep902AuGd9LwFXiJ3rl+WVSP7a+ iw6Op2+UetwfJkxvLzGxHKlgdgU+Q3EtE385J/EE4nBlxP93N6cH9refCUoBMZrk eqM1EE2TorVzS/r0yUrlhH8TfdU/f+0iWrJOKPgPTSogNGzG6XkPdUxBAZvCR5YI YesIO/ps1llB/GkF8YX7m0pn7RAA6XfR3/ti6qYMWbNmar2UxT0Z3gXajB3fRKrp Towpid0n89u/x0HAujExv8fXLhGV7MoWqXfU3NCW8frUwGnVlCSnVCBsF+mWgF06 RPGOc+98awxVxEkIU0P+AwjdVrV+WjsZqb2AotS9wjJi9D5dQJQpWhZ7XnxrmgdU B2Svx3W3AdtQ+1GL3ZZJs4GuRwt38rbbc3QPt+tugMlWH9CCswU0VWIKuNLVLnLQ NiOT2RXcLuJxTP2e+tA5uaY0YYcMFIpTkacTAO4VUh2qsQ9Xvv7cvLMcPJOSEW8+ BfHAZCifxl7G8Qy+jGqJckpXKpe1OLX4g6qWu36tALNfkS7aDNw8cv1JGjF1o6Uo 3/oP/356LSpxbXf7vKIsxtQlxf4NGevaI1AnBwJpaDFkX1+a80W85zdk3/zB9JTj yGzGopSlbvm0jFNHAmmPEe0KBl/XjDeFDqFyc7Rd6aSiCNsbvyiSi5Lna+U= =J+5/ -----END PGP MESSAGE----- --=-=-=-- From unknown Sun Jun 22 07:54:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#75716] [PATCH 1/2] gnu: go-1.23: Skip time variant tests References: In-Reply-To: Resent-From: Sharlatan Hellseher Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 21 Jan 2025 23:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75716 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 75716@debbugs.gnu.org Received: via spool by 75716-submit@debbugs.gnu.org id=B75716.173750376029466 (code B ref 75716); Tue, 21 Jan 2025 23:56:01 +0000 Received: (at 75716) by debbugs.gnu.org; 21 Jan 2025 23:56:00 +0000 Received: from localhost ([127.0.0.1]:58174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1taO68-0007f8-Av for submit@debbugs.gnu.org; Tue, 21 Jan 2025 18:55:59 -0500 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:61891) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1taO61-0007ej-7c for 75716@debbugs.gnu.org; Tue, 21 Jan 2025 18:55:53 -0500 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-3862a921123so4418821f8f.3 for <75716@debbugs.gnu.org>; Tue, 21 Jan 2025 15:55:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737503742; x=1738108542; darn=debbugs.gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=lEAr6f3KO0wmc0XrdkzysJkzCe6B+LkY6RUYnJOaTXo=; b=K6bbczZJqPT1vzhHWSdCMKdyPA/vyzKCN5iU1kfVUrixMXjG8AJ7oTmirrBJ+y8lzi RSMJr2mnQhfp4jNuDLVCYlifUrJsYC/W5fdUpMFo+UI2TMkvl8J0G0zfsehllYPVLgly 3734CzaYNqtKV+0+2edYzIHz2dCqtGHRcaLTtcGWPJesZst9M55Hso/UbbqB1I0HhWU6 mGxM/n5ACZ4E5YyaqHogPJdMUjhGa0lCx9do/OKLSTI4dW5k5TH7dtzR78KbsTS25sEq v/t9qTUyS2QWHBdr95WZNPz5+w2ayR1OUieEspMDisdW0mN4DXJn6jVcKG+6c0YQPCoZ GHiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737503742; x=1738108542; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=lEAr6f3KO0wmc0XrdkzysJkzCe6B+LkY6RUYnJOaTXo=; b=r+0E5O42ejWsRFvEMRM5HqcfJZL+qmL0bmJkJE4mWNNo12TLuM+H42sb3DwYnR3BRM bgYmUvHH00HLCmAt79MEVpovF/SDPYy6c9U5myeMZ3hhrSCKVCiALeavRwFgs8DXh0Ho rWYIow0GShZA3K57LFG0m0Q8JHfwTfyad7SCPBwSpBxQeUp53FUG92GqMAsJDlR+A4s1 MSL7jWu7YnUo/B7q3XK6+2h1MuvQDSJWuoqyGnlYKGJqBKkdDD7hdk6SQflUlwdQeuCb bWr8Ntm3GvZ1jGlGhe1dvcJqfSPKd83JgB1eh49HyEZtF+MQQGML3x9SqOXywr+EB6qb jm3g== X-Gm-Message-State: AOJu0YysCgsLZCRr0GMxZ2dTQxUWotUtA2U+12SgKO7m/aZROzpZ5ivP fjtLOO6H7vVb7DqjvJNW8SdV3xnMKuk4BJ/mWbV1SlONjFxS/D3+dnv8JD1o X-Gm-Gg: ASbGnctM7Rl/aIxxR0kClO7UBmH32LMKayWGMd8Liw2y3kz48I9xR74GgfqGUXspNx+ x40F0z/jcB7S5jSUmDXcRUolcBpMqTBS827uovqIFPwuaFETFThjHP9DX/3P3SKP3RL9XYc0xm6 HEvxJPmMhYXAZU3IkYbdPYeNEaOoe1AQp30cGevFfLPlX4h4hS05bJjQoy0X7F608hgRvcVNVDO W5wx9t00bENYSzfL/4ld5lJ22+tfuXSzeguIpfD/5rwKhAyBV0NFaSdZ3OswURc4ERWhMG+6CCf QUD8ai/ueAU2GcEgctuuey857Bwl8kFCkzdVaZx4dgPYFw== X-Google-Smtp-Source: AGHT+IETtEFhjojfpxvFbqqLeo/Zb+bZ6pXTAkapd36Y2KItRv1Y4eEYD81qnySu4AZ00JH4x+nf4Q== X-Received: by 2002:a5d:47c9:0:b0:386:416b:9c69 with SMTP id ffacd0b85a97d-38bf5662912mr18764275f8f.16.1737503742086; Tue, 21 Jan 2025 15:55:42 -0800 (PST) Received: from guxtil (cpc100684-bagu15-2-0-cust967.1-3.cable.virginm.net. [86.8.111.200]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438b31c7816sm2440565e9.34.2025.01.21.15.55.40 for <75716@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2025 15:55:41 -0800 (PST) From: Sharlatan Hellseher Date: Tue, 21 Jan 2025 23:55:40 +0000 Message-ID: <87frlbiuwz.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hi, Thanks for picking this up. The issue is currently resolved on go-team branch with this change: --8<---------------cut here---------------start------------->8--- diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index cfe9784e8b..267681f551 100644 --- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -841,6 +841,24 @@ in the style of communicating sequential processes (@dfn{CSP}).") #~(modify-phases #$phases (delete 'skip-TestGoPathShlibGccgo-tests) (delete 'patch-source) + ;; Time bomb in TLS tests: "Most of the test certificates + ;; (e.g. testRSACertificate, testRSACertificateIssuer, + ;; testRSA2048CertificateIssuer) have a not after of Jan 1 + ;; 00:00:00 2025 GMT." + ;; https://github.com/golang/go/issues/71077 + ;; https://github.com/golang/go/issues/71103 + ;; https://github.com/golang/go/issues/71104 + (add-after 'unpack 'skip-crypto-tls-tests + (lambda _ + (substitute* (list "src/crypto/tls/handshake_client_test.go" + "src/crypto/tls/handshake_server_test.go") + (("TestVerifyConnection.*" all) + (string-append all "\n t.Skip(\"golang.org/issue/71077\")\n")) + (("TestResumptionKeepsOCSPAndSCT.*" all) + (string-append all "\n t.Skip(\"golang.org/issue/71077\")\n")) + (("TestCrossVersionResume.*" all) + (string-append all "\n t.Skip(\"golang.org/issue/71077\")\n"))))) --8<---------------cut here---------------end--------------->8--- The branch is on it's way to master https://issues.guix.gnu.org/75467 -- Thanks, Oleg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEmEeB3micIcJkGAhndtcnv/Ys0rUFAmeQM/wACgkQdtcnv/Ys 0rUpBg/8CI0t/qAfa2DilP4W3Yd2L2LDcTFzVqr7nhfFheovzXRJVNrBINRir9S3 oSs2vSSdYjmDsRhRLXdZa5dC2xSN00IU1nm5ppJgc6G8hdKWxzvm1Juz2sLUqpat k5utqcWa5oMt+9YyKazosdSu0eSfgldusc9PUUv+T0SWKNLusIYnU9QjwdBb6GGw z4UM3Ea5ZJbrzI8DhJ87xbitop56OkXnk4sWfeB2SZXOvA7dBv4mKBwt3Cp5+hmO bE43K/0whrrl2sBtIUBLXLTjBCJ5SiLkbwlSuMiFvG/zPZzkLkqFDWlIANn5RDci j9t90yUgGWHf0xtmiHfM+H8jCP9AAz3qxTRb0imbyw2F/IjCiJf4F4rvyc2035fO iralZvl5IEakBIr+opmyrsAdAMquqfCH+biL+uW1WFHafrLJxX8xssDk3nAwS8Gx rAi0tfrqy3jeLLPMFsEEKeN2Aegrapa2Sz2m9yhzzShj5FuMoJot2DFaJTgLi9GQ 39gmMNiPQruAZmLw1d/+I4SMPLfUwS6evrP6fWWG8h8eBagD0egBT2pNMGC4E0Hw xV78yLWaLH5iRwNjEmfR+wN5mrd4q+BIlWAeDIvQMohBNT6mZGe46c0kfLKpC9LH 7/FPM3l0yM801o3H+IeI+ezdUo31ucAGg25NKiPXl70iQYYcOgo= =tUKL -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Jun 22 07:54:00 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Ryan Sundberg Subject: bug#75716: closed ([PATCH 1/2] gnu: go-1.23: Skip time variant tests) Message-ID: References: <87jzakgyh7.fsf@gmail.com> X-Gnu-PR-Message: they-closed 75716 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 75716@debbugs.gnu.org Date: Fri, 24 Jan 2025 12:59:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1737723542-26432-1" This is a multi-part message in MIME format... ------------=_1737723542-26432-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #75716: [PATCH 1/2] gnu: go-1.23: Skip time variant tests which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 75716@debbugs.gnu.org. --=20 75716: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D75716 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1737723542-26432-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 75716-done) by debbugs.gnu.org; 24 Jan 2025 12:58:38 +0000 Received: from localhost ([127.0.0.1]:44101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tbJGf-0006rh-SC for submit@debbugs.gnu.org; Fri, 24 Jan 2025 07:58:38 -0500 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]:42372) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tbJGe-0006rM-Hp for 75716-done@debbugs.gnu.org; Fri, 24 Jan 2025 07:58:36 -0500 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-4361b6f9faeso13556305e9.1 for <75716-done@debbugs.gnu.org>; Fri, 24 Jan 2025 04:58:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737723510; x=1738328310; darn=debbugs.gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=Q+E63CgDJSDLtNp/4+KBD0ul6TxCTCFYrqTKAfvJHwg=; b=cVyZBfS+C7pbw9pGc5cdtGhbrWto0FZtiAhdvVI8115Dy0k/vUfe3ZSvDiuns9Er3i Oe5/57SiOZf7uC7NYgH3/DdQ5X2Zq3kBzZpbJ6rr2afS6tMerW3JsB/UZUeAO3lVW1B3 fuTOoKGxAoGy8TdtZP2ZY2OdcfBCqfi9FKn/1QBqlQ8OzApaWpI/6okGrM/ZzdUtkVQH TvTjpeWgZwsl9qRUeMgGvnHrFcM1rjqA//xZKUW2guUm3VvdDZHc617LAnHJgE5G7/vo LY8lDIi95tYkU4wCXTtPHLem0oebgRYhlu4L8zZBcPTpUZYA0lyJAFZXSYpTWF1vP+SF 455A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737723510; x=1738328310; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Q+E63CgDJSDLtNp/4+KBD0ul6TxCTCFYrqTKAfvJHwg=; b=Tek/uou0vfgHe2uv+41Z/G7LYW7jLQz4QwVGVpcGfxF3/w9KZX0swP2cwPV+eiMell PWXQtcH7hng4uB3MC4rsqnMsW/le38728XBoVorguPmjG9sRby5BDmfHYx3nyA9/3PO/ /4q7+asG+GH2b5ROrt+BaEVHYd/UM/C06W3aFJyTplwbbYV4Za3FCvEKo86QOxTNPx/G IPLyHWlVjxEIsotsyhYxIkiXNDX5Vvpg6Lpdc1GNmTcgpr7jMHi2uf9SbBUti6CFG8Jp kUOLz81A3cieOVtIDGIABXZEAZSKbEue4GQAhioE77fhD0mWv7C7G6g48LjUDfQEP3sw aySQ== X-Gm-Message-State: AOJu0YyrWUGIBa4INKUGpkqP4+qcIfgW2smW/wuqcEriT0iaCQu+pCE3 iyTdRsJ4t5J7qtlIkvqRNK33dtNDvOVrandtDiT1MOHTKwV1bxSXw5blGfsodP4= X-Gm-Gg: ASbGncsI/U9H5v6YHFvVvcp6zG7ha47fCoPs3RB6lV0OpZUdaIEff0kNxxUx+xPwpdt wXHo4MAKE3vSchHwyWXEPFQHi/FA8sFgxW2M/zxBNFZmwNe6R4nlh1LxIxRlYlufAstP7q7WAbb sIurPCHio2JCg6l1Tbblzdw/vBgXYE2ahgYZfQj3mc6Uv4TqF+mZcHB5oMsaJ4RqIYdA+/7CzId h4IBNl34HtQ0+1qiNzXpdvwe0R3q8tabFjlsPjxzfkusTkSyozBgFtzy3/hDzKaMG4KlAlcEEw6 Vx0YGQPCfXFyRh32Y3rD1ijfBaTW8g5ZNuwi/wqcaXXJr2WIMM0Ez1Wc X-Google-Smtp-Source: AGHT+IFDvi2rnPAm0FKgZC0GLzzJzgw4o3VuUZ0Xj7JDnNRzKkRku0TSqCWKFXbKJdThIrXSsqZBHA== X-Received: by 2002:a05:600c:1e0d:b0:434:f2af:6e74 with SMTP id 5b1f17b1804b1-438b886097emr70190405e9.15.1737723510180; Fri, 24 Jan 2025 04:58:30 -0800 (PST) Received: from guxtil (cpc100684-bagu15-2-0-cust967.1-3.cable.virginm.net. [86.8.111.200]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438bd4fa463sm25766745e9.8.2025.01.24.04.58.29 for <75716-done@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jan 2025 04:58:29 -0800 (PST) From: Sharlatan Hellseher To: 75716-done@debbugs.gnu.org Subject: [PATCH 1/2] gnu: go-1.23: Skip time variant tests Date: Fri, 24 Jan 2025 12:58:28 +0000 Message-ID: <87jzakgyh7.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75716-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Closing as it's fixed on go-team branch for all Go compilers starting from go-1.17. =2D- Thanks, Oleg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEmEeB3micIcJkGAhndtcnv/Ys0rUFAmeTjnQACgkQdtcnv/Ys 0rXbtA//RV5FADUiGoS0bUfAMDBqmWjAXaJRKPOFf0Sl/96FvZ/h5nxlV1hYsAz1 44+ksfXuabu+lPM6ohaOFYzaAJ/+iF8yxxB5YYkZrg0SA4YOUMEL1PG5UdBMLqBK z06vhFvu+0k5x8S5sH1yMFhlN6qWFrmBLfIL9TvIrcTR+9OH7OmwkugIMhUt7B+E RcWcuJ55kiTBCjexir78L12BS035HYxvg0m1sJYRj+yhbPVMRkh0GIZUz0IuK+W7 +E9yLSGoRW6M+cm09KLRw3vw8mUb2URjGflo2FJ6XJxe4apgPwmqUqOC5NSB4tCj CZ0F7WnhaUgWILoeNPi/9NpIPoOAqqjTKLWPJRchdEGfUTYEC/GZnf9C6IbaP4o6 ph56u9/cxLcwXKm8aosszJ9UUgEr59F1M3CWiSM27jTCul0bsLj+boFZqc8mF43R iUwXIHpkuT2gAZ2ax37vR73051Ndl0bvOEYDsblcsx1u4qqEaDFLay2yMZPruIa+ GfRI78ygrTlip8VrXqWyjj+S0PZpevNwINdPCtz32Su0UInRhnZvWvj4rFR1jqNh P0ZL39k0J6HWoMlkQGgJVnqZndUhvyly1SNbUZpB+kY9ZwTDRwQZnvVyFPyUm30R A0UbnctGJ+K0SvVkMXqtQ3yoehprJjY45ULgtKdl0Y3wOykhGNc= =L4Xt -----END PGP SIGNATURE----- --=-=-=-- ------------=_1737723542-26432-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 21 Jan 2025 00:07:17 +0000 Received: from localhost ([127.0.0.1]:52323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ta1nY-0002qw-Kh for submit@debbugs.gnu.org; Mon, 20 Jan 2025 19:07:17 -0500 Received: from lists.gnu.org ([2001:470:142::17]:46078) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ta1nW-0002qf-AD for submit@debbugs.gnu.org; Mon, 20 Jan 2025 19:07:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ta1nQ-0000uD-Nu for guix-patches@gnu.org; Mon, 20 Jan 2025 19:07:08 -0500 Received: from mail.arctype.co ([138.68.9.245]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ta1nJ-0005XD-TV for guix-patches@gnu.org; Mon, 20 Jan 2025 19:07:08 -0500 Received: from authenticated-user (mail.arctype.co [138.68.9.245]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by mail.arctype.co (Postfix) with ESMTPSA id 4633813B0EB; Tue, 21 Jan 2025 00:06:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=arctype.co; s=mail; t=1737417990; bh=lkxsq458/CNu1vh8jJx/mcOps/6qkFVBxAUa4dfbPQg=; h=From:To:Cc:Subject:Date:From; b=jfmBpYDLiNpL3H0nbTIkFOXeeQPyna+Npl+hdFqtmAjFkMViTJhRS1wswIOKR0dUy OOGsp8cY68sSiEJSps95nKG2K9uWz0CzwRLuhLiG9HweL+fyOPXZLEfMNeXrhw5mbX PSKbvaJnUg6Qxjjg84pFhW+G+vGyZx6vDrYuUzpa9RdhRzqACiaIJXqFQuL71x+poX fvau9jF+M9VhYG31vCmoZE0ICKSIFQ96sEvDyNYVvA6CSn5opWnV4C36K9nZoh0+M+ 3+7HwdjPdSZY+NJSSi39Cj/28CjJ7ZekYg53lzYJbe/ibCCdqaTeM2AOLcSqV78olK AKq6Xay7iSu/g== From: Ryan Sundberg To: guix-patches@gnu.org Subject: [PATCH 1/2] gnu: go-1.23: Skip time variant tests Date: Mon, 20 Jan 2025 16:06:04 -0800 Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=138.68.9.245; envelope-from=ryan@arctype.co; helo=mail.arctype.co X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: Ryan Sundberg X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Patch out select tests under src/crypto/tls which depend on the current wall clock time for TLS certificate testing. Specifically, the following failing test cases are skipped: ``` Change-Id: I2f1519bc1c951e15db3a1c9320148206674c7bdf --- FAIL: TestVerifyConnection (0.00s) --- FAIL: TestVerifyConnection/TLSv12 (0.00s) handshake_client_test.go:1759: RequireAndVerifyClientCert-FullHandshake: handshake failed: server: remote error: tls: bad certificate client: tls: failed to verify certificate: x509: certificate has expired or is not yet valid: current time 2025-01-20T20:07:09Z is after 2025-01-01T00:00:00Z --- FAIL: TestVerifyConnection/TLSv13 (0.00s) handshake_client_test.go:1759: RequireAndVerifyClientCert-FullHandshake: handshake failed: server: remote error: tls: bad certificate client: tls: failed to verify certificate: x509: certificate has expired or is not yet valid: current time 2025-01-20T20:07:09Z is after 2025-01-01T00:00:00Z --- FAIL: TestResumptionKeepsOCSPAndSCT (0.00s) --- FAIL: TestResumptionKeepsOCSPAndSCT/TLSv12 (0.00s) handshake_client_test.go:2550: handshake failed: server: remote error: tls: bad certificate client: tls: failed to verify certificate: x509: certificate has expired or is not yet valid: current time 2025-01-20T20:07:09Z is after 2025-01-01T00:00:00Z --- FAIL: TestResumptionKeepsOCSPAndSCT/TLSv13 (0.00s) handshake_client_test.go:2550: handshake failed: server: remote error: tls: bad certificate client: tls: failed to verify certificate: x509: certificate has expired or is not yet valid: current time 2025-01-20T20:07:09Z is after 2025-01-01T00:00:00Z --- FAIL: TestCrossVersionResume (0.01s) --- FAIL: TestCrossVersionResume/TLSv12 (0.00s) handshake_server_test.go:526: handshake did not resume at the same version --- FAIL: TestCrossVersionResume/TLSv13 (0.00s) handshake_server_test.go:526: handshake did not resume at the same version FAIL FAIL crypto/tls 0.423s ``` * gnu/packages/golang (go-1.23): Include patchset * gnu/packages/patches/go-skip-tls-tests.patch: New patch file --- gnu/packages/golang.scm | 16 +++++- gnu/packages/patches/go-skip-tls-tests.patch | 56 ++++++++++++++++++++ 2 files changed, 71 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/go-skip-tls-tests.patch diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index b1ea9e5a28..d39e50e982 100644 --- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -1001,7 +1001,21 @@ (define-public go-1.23 (commit (string-append "go" version)))) (file-name (git-file-name name version)) (sha256 - (base32 "0v8j43yqkhp5i5649nbxsq7lc9bjjn39gqqvlnz0d9c47qz9h7y7")))))) + (base32 "0v8j43yqkhp5i5649nbxsq7lc9bjjn39gqqvlnz0d9c47qz9h7y7")))) + (arguments + (substitute-keyword-arguments (package-arguments go-1.22) + ((#:phases phases) + #~(modify-phases #$phases + (add-after 'unpack 'apply-skip-test-patch + (lambda* (#:key inputs #:allow-other-keys) + ;; Having the patch in the 'patches' field of breaks + ;; the 'TestServeContent' test due to the fact that timestamps + ;; are reset. Thus, apply it from here. + (invoke "patch" "-p1" "--force" "-i" + (assoc-ref inputs "go-skip-tls-tests.patch")))))))) + (native-inputs + `(("go-skip-tls-tests.patch" ,(search-patch "go-skip-tls-tests.patch")) + ,@(package-native-inputs go-1.22))))) ;; ;; Default Golang version used in guix/build-system/go.scm to build packages. diff --git a/gnu/packages/patches/go-skip-tls-tests.patch b/gnu/packages/patches/go-skip-tls-tests.patch new file mode 100644 index 0000000000..92e0a31a86 --- /dev/null +++ b/gnu/packages/patches/go-skip-tls-tests.patch @@ -0,0 +1,56 @@ +From 0b0cb6aa447cef0e4f631e43db05195d0d25329a Mon Sep 17 00:00:00 2001 +From: Ryan Sundberg +Date: Mon, 20 Jan 2025 15:17:39 -0800 +Subject: [PATCH] crypto/tls: Disable test cases which are time variant + +These test cases depend on the current date relative to the TLS +certificates under test. Skip them for repeatability. +--- + src/crypto/tls/handshake_client_test.go | 8 ++++---- + src/crypto/tls/handshake_server_test.go | 4 ++-- + 2 files changed, 6 insertions(+), 6 deletions(-) + +diff --git a/src/crypto/tls/handshake_client_test.go b/src/crypto/tls/handshake_client_test.go +index 3c87916bcf..fa2a494a6b 100644 +--- a/src/crypto/tls/handshake_client_test.go ++++ b/src/crypto/tls/handshake_client_test.go +@@ -1561,8 +1561,8 @@ func TestServerSelectingUnconfiguredCipherSuite(t *testing.T) { + } + + func TestVerifyConnection(t *testing.T) { +- t.Run("TLSv12", func(t *testing.T) { testVerifyConnection(t, VersionTLS12) }) +- t.Run("TLSv13", func(t *testing.T) { testVerifyConnection(t, VersionTLS13) }) ++ // t.Run("TLSv12", func(t *testing.T) { testVerifyConnection(t, VersionTLS12) }) ++ // t.Run("TLSv13", func(t *testing.T) { testVerifyConnection(t, VersionTLS13) }) + } + + func testVerifyConnection(t *testing.T, version uint16) { +@@ -2528,8 +2528,8 @@ func TestDowngradeCanary(t *testing.T) { + } + + func TestResumptionKeepsOCSPAndSCT(t *testing.T) { +- t.Run("TLSv12", func(t *testing.T) { testResumptionKeepsOCSPAndSCT(t, VersionTLS12) }) +- t.Run("TLSv13", func(t *testing.T) { testResumptionKeepsOCSPAndSCT(t, VersionTLS13) }) ++ //t.Run("TLSv12", func(t *testing.T) { testResumptionKeepsOCSPAndSCT(t, VersionTLS12) }) ++ //t.Run("TLSv13", func(t *testing.T) { testResumptionKeepsOCSPAndSCT(t, VersionTLS13) }) + } + + func testResumptionKeepsOCSPAndSCT(t *testing.T, ver uint16) { +diff --git a/src/crypto/tls/handshake_server_test.go b/src/crypto/tls/handshake_server_test.go +index bbfe44bd97..4347c40a6d 100644 +--- a/src/crypto/tls/handshake_server_test.go ++++ b/src/crypto/tls/handshake_server_test.go +@@ -493,8 +493,8 @@ func testSCTHandshake(t *testing.T, version uint16) { + } + + func TestCrossVersionResume(t *testing.T) { +- t.Run("TLSv12", func(t *testing.T) { testCrossVersionResume(t, VersionTLS12) }) +- t.Run("TLSv13", func(t *testing.T) { testCrossVersionResume(t, VersionTLS13) }) ++ //t.Run("TLSv12", func(t *testing.T) { testCrossVersionResume(t, VersionTLS12) }) ++ //t.Run("TLSv13", func(t *testing.T) { testCrossVersionResume(t, VersionTLS13) }) + } + + func testCrossVersionResume(t *testing.T, version uint16) { +-- +2.41.0 + base-commit: 91b18baa4274a025d28f06133682a9269217730d -- 2.41.0 ------------=_1737723542-26432-1--