GNU bug report logs - #75712
HAVE_RSVG: svg_css_length_to_pixels doesn't handle RSVG_UNIT_CH

Previous Next

Full log

Message #31 received at 75712 <at> debbugs.gnu.org (full text, mbox):

From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
To: 75712 <at> debbugs.gnu.org
Cc: pipcet <at> protonmail.com, stefankangas <at> gmail.com
Subject: Re: bug#75712: HAVE_RSVG: svg_css_length_to_pixels doesn't handle
 RSVG_UNIT_CH
Date: Tue, 21 Jan 2025 20:24:05 +0100

Pip Cet via "Bug reports for GNU Emacs, the Swiss army knife of text
editors" <bug-gnu-emacs <at> gnu.org> writes:

> "Stefan Kangas" <stefankangas <at> gmail.com> writes:
>
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>>
>>>> Date: Tue, 21 Jan 2025 15:04:33 +0000
>>>> From: Pip Cet <pipcet <at> protonmail.com>
>>>> Cc: Stefan Kangas <stefankangas <at> gmail.com>, 75712 <at> debbugs.gnu.org
>>>>
>>>> Here's a proposed patch which:
>>>> 1. prints a warning about this situation (in case the library changes)
>>>> 2. omits the default label so GCC also warns, even without -Wswitch-enum
>>>> (in case the headers change)
>>>> 3. includes too much commentary rather than too little.
>>>
>>> LGTM, thanks.  But please wait for Stefan to comment.
>>
>> LGTM, please install.
>
> Pushed, closing.  Minor change compared to the patch I posted:
>
> PSA: image_error takes Lisp_Object arguments, not integers.  Something
> for your (ever-growing, no doubt) TODO list, maybe?
>
> Pip

Maybe something --enable-check-lisp-object-type would be good for.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.