GNU bug report logs - #75712
HAVE_RSVG: svg_css_length_to_pixels doesn't handle RSVG_UNIT_CH

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Kangas <stefankangas <at> gmail.com>
Subject: bug#75712: closed (Re: bug#75712: HAVE_RSVG: svg_css_length_to_pixels
 doesn't handle RSVG_UNIT_CH)
Date: Tue, 21 Jan 2025 19:13:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#75712: HAVE_RSVG: svg_css_length_to_pixels doesn't handle RSVG_UNIT_CH

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 75712 <at> debbugs.gnu.org.

-- 
75712: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=75712
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Pip Cet <pipcet <at> protonmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 75712-done <at> debbugs.gnu.org
Subject: Re: bug#75712: HAVE_RSVG: svg_css_length_to_pixels doesn't handle
 RSVG_UNIT_CH
Date: Tue, 21 Jan 2025 19:12:40 +0000

"Stefan Kangas" <stefankangas <at> gmail.com> writes:

> Eli Zaretskii <eliz <at> gnu.org> writes:
>
>>> Date: Tue, 21 Jan 2025 15:04:33 +0000
>>> From: Pip Cet <pipcet <at> protonmail.com>
>>> Cc: Stefan Kangas <stefankangas <at> gmail.com>, 75712 <at> debbugs.gnu.org
>>>
>>> Here's a proposed patch which:
>>> 1. prints a warning about this situation (in case the library changes)
>>> 2. omits the default label so GCC also warns, even without -Wswitch-enum
>>> (in case the headers change)
>>> 3. includes too much commentary rather than too little.
>>
>> LGTM, thanks.  But please wait for Stefan to comment.
>
> LGTM, please install.

Pushed, closing.  Minor change compared to the patch I posted:

PSA: image_error takes Lisp_Object arguments, not integers.  Something
for your (ever-growing, no doubt) TODO list, maybe?

Pip

[Message part 3 (message/rfc822, inline)]

From: Stefan Kangas <stefankangas <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: HAVE_RSVG: svg_css_length_to_pixels doesn't handle RSVG_UNIT_CH
Date: Mon, 20 Jan 2025 14:26:22 -0600

In Bug#75451, Pip Cet <pipcet <at> protonmail.com> writes:

> svg_css_length_to_pixels doesn't handle the RSVG_UNIT_CH case.  I don't
> know at which version rsvg started to offer this unit; it's not
> indicated in the header file.

It seems to have been added in 2.58:

https://gnome.pages.gitlab.gnome.org/librsvg/Rsvg-2.0/enum.Unit.html

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.