GNU bug report logs - #75712
HAVE_RSVG: svg_css_length_to_pixels doesn't handle RSVG_UNIT_CH

Previous Next

Package: emacs;

Reported by: Stefan Kangas <stefankangas <at> gmail.com>

Date: Tue, 21 Jan 2025 00:00:02 UTC

Severity: normal

Done: Pip Cet <pipcet <at> protonmail.com>

Bug is archived. No further changes may be made.

Full log

Message #23 received at 75712 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>, Pip Cet <pipcet <at> protonmail.com>
Cc: 75712 <at> debbugs.gnu.org
Subject: Re: bug#75712: HAVE_RSVG: svg_css_length_to_pixels doesn't handle
 RSVG_UNIT_CH
Date: Tue, 21 Jan 2025 10:29:39 -0800

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Date: Tue, 21 Jan 2025 15:04:33 +0000
>> From: Pip Cet <pipcet <at> protonmail.com>
>> Cc: Stefan Kangas <stefankangas <at> gmail.com>, 75712 <at> debbugs.gnu.org
>>
>> Here's a proposed patch which:
>> 1. prints a warning about this situation (in case the library changes)
>> 2. omits the default label so GCC also warns, even without -Wswitch-enum
>> (in case the headers change)
>> 3. includes too much commentary rather than too little.
>
> LGTM, thanks.  But please wait for Stefan to comment.

LGTM, please install.
This bug report was last modified 118 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.