Subject: bug#75712: closed (Re: bug#75712: HAVE_RSVG: svg_css_length_to_pixels doesn't handle RSVG_UNIT_CH)

From: [email-masked] (GNU bug Tracking System)
Date: Tue, 21 Jan 2025 19:13:02 +0000

Your bug report

#75712: HAVE_RSVG: svg_css_length_to_pixels doesn't handle RSVG_UNIT_CH

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
75712: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=75712
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#75712: HAVE_RSVG: svg_css_length_to_pixels doesn't handle RSVG_UNIT_CH
From: Pip Cet <[email-masked]>
To: Stefan Kangas <[email-masked]>
Cc: Eli Zaretskii <[email-masked]>, [email-masked]
Date: Tue, 21 Jan 2025 19:12:40 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

"Stefan Kangas" <[email-masked]> writes:

> Eli Zaretskii <[email-masked]> writes:
>
>>> Date: Tue, 21 Jan 2025 15:04:33 +0000
>>> From: Pip Cet <[email-masked]>
>>> Cc: Stefan Kangas <[email-masked]>, [email-masked]
>>>
>>> Here's a proposed patch which:
>>> 1. prints a warning about this situation (in case the library changes)
>>> 2. omits the default label so GCC also warns, even without -Wswitch-enum
>>> (in case the headers change)
>>> 3. includes too much commentary rather than too little.
>>
>> LGTM, thanks.  But please wait for Stefan to comment.
>
> LGTM, please install.

Pushed, closing.  Minor change compared to the patch I posted:

PSA: image_error takes Lisp_Object arguments, not integers.  Something
for your (ever-growing, no doubt) TODO list, maybe?

Pip

Subject: HAVE_RSVG: svg_css_length_to_pixels doesn't handle RSVG_UNIT_CH
From: Stefan Kangas <[email-masked]>
To: [email-masked]
Date: Mon, 20 Jan 2025 14:26:22 -0600
List-Id: <debbugs-submit.debbugs.gnu.org>

In Bug#75451, Pip Cet <[email-masked]> writes:

> svg_css_length_to_pixels doesn't handle the RSVG_UNIT_CH case.  I don't
> know at which version rsvg started to offer this unit; it's not
> indicated in the header file.

It seems to have been added in 2.58:

https://gnome.pages.gitlab.gnome.org/librsvg/Rsvg-2.0/enum.Unit.html