From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 20 18:59:56 2025 Received: (at submit) by debbugs.gnu.org; 20 Jan 2025 23:59:56 +0000 Received: from localhost ([127.0.0.1]:52266 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ta1gR-0002NY-No for submit@debbugs.gnu.org; Mon, 20 Jan 2025 18:59:55 -0500 Received: from lists.gnu.org ([2001:470:142::17]:57480) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ta1gO-0002ND-I7 for submit@debbugs.gnu.org; Mon, 20 Jan 2025 18:59:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tZyLq-0002RB-Hy for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2025 15:26:26 -0500 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tZyLo-00089G-Ti for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2025 15:26:26 -0500 Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-5d647d5df90so8159391a12.2 for ; Mon, 20 Jan 2025 12:26:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737404783; x=1738009583; darn=gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=tgnMx4vEPNwnXrtI/ZsKpC/oVOPjZUto9QcxbnUISmc=; b=B8auvO6VCq0SmlZwj/1TjfKPgmlDxUxIQNlTaU4jzAb9ESuWxHUT5vKHZk6BWVar2i PPzQpQhU/GpquGWrJo/Lkf2ZY3zGT9q+PY5/ikTALhnGoRJMRps0dbx2HiSxTxxSIh7A D4o7Opz3WTNDZCyBmxrm9a+7KToDIsxSyj7SVtFiyExWd6h4exnN2zXQBKaLaUjjvTf9 VYu0GBLf2Wem9SDRFlNe4eBGrKRJEEqIjCvICJ9//GNRhQuogqJEBCkIrBRbspOXac41 MzdwLNy2kOnXLEVElqf+D8hdo+gcFIm7qtmgMVFDJDB0xtqJXHBi2HMC+CZazrn3A2vn fumA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737404783; x=1738009583; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=tgnMx4vEPNwnXrtI/ZsKpC/oVOPjZUto9QcxbnUISmc=; b=OPY2JDIvINwXOdxMzoUes1kjZ4ko7+GFL/z2R6lHU7u19ClCJeXMMVFEcavERUE9kb ORhWDkC/kq9YcNCQu4K7/+k3bjqlYswIRxVPx5SAXSp5nNdjbogiHQNL84D1C2wtFAZR FxehOtpZQ0ADwV3J7SieQYgHddejQQl6rsZvxlSz2fPHNCFuR9EcoDyWn+Qz9kMSxS3U J/gdXJOdIR+oeqYW0+mWpWXIYRsEjYJRuaZHo4+fSFNMtHFZx9nz6h37/+LBPd5fJ9nr UGNlyHW62yF+YqksEJg5U8uGc/rUyizpZldq4ti6JGR3KPCE200Md5bmozEp1sJkZ0M+ 6jvg== X-Gm-Message-State: AOJu0YwecgTEjbVMtG3wR5jJudhxF/+EfeFq93Ck8GBZIy0LKeBMAMgJ EtuCcSX1PPP/A+EhuaqlS7WMr6eojlnR+SbAJWiec876i+2TKoRUsUIFqkeU+XIKrYOzwU5289Y BK+Xf4B7lDeBklorlpB32ca5xdpIPt7zxRLY= X-Gm-Gg: ASbGncu5yYY4idjtX48YA6ITAeBWIXYuqm2eKJbb7xpiljirp/dDFNyp1FGc8gYOe/W L68XNgVbd9fTAVd9/90+fNO6xPvhyAWQad2TqEVEC141XgQ8e42U= X-Google-Smtp-Source: AGHT+IE3SMXnf5yHzDtI49TV09foIhFElb6wCcY6VemIchvhhoHrDPjmIUiBR+CxOVNsAsWjso9Tzet2ANfwkqQ5qXs= X-Received: by 2002:a05:6402:2109:b0:5d3:fc60:a504 with SMTP id 4fb4d7f45d1cf-5db7db0840dmr14135971a12.20.1737404783011; Mon, 20 Jan 2025 12:26:23 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 20 Jan 2025 14:26:22 -0600 From: Stefan Kangas X-Debbugs-CC: Pip Cet MIME-Version: 1.0 Date: Mon, 20 Jan 2025 14:26:22 -0600 X-Gm-Features: AbW1kvbOBDW67SWsJiYTtT48VJPJJ4dfs6OG24fdcHq95p0p4Vs5U26wIznA954 Message-ID: Subject: HAVE_RSVG: svg_css_length_to_pixels doesn't handle RSVG_UNIT_CH To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::532; envelope-from=stefankangas@gmail.com; helo=mail-ed1-x532.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) In Bug#75451, Pip Cet writes: > svg_css_length_to_pixels doesn't handle the RSVG_UNIT_CH case. I don't > know at which version rsvg started to offer this unit; it's not > indicated in the header file. It seems to have been added in 2.58: https://gnome.pages.gitlab.gnome.org/librsvg/Rsvg-2.0/enum.Unit.html From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 20 21:25:37 2025 Received: (at 75712) by debbugs.gnu.org; 21 Jan 2025 02:25:37 +0000 Received: from localhost ([127.0.0.1]:52606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ta3xQ-0004OT-Dz for submit@debbugs.gnu.org; Mon, 20 Jan 2025 21:25:37 -0500 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]:52454) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1ta3xI-0004O7-4k for 75712@debbugs.gnu.org; Mon, 20 Jan 2025 21:25:33 -0500 Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-aa6b4cc7270so796840066b.0 for <75712@debbugs.gnu.org>; Mon, 20 Jan 2025 18:25:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737426321; x=1738031121; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=n9An6Tllw4eU1Dq9ytvRc+xUrMzA1mH4iMWGlHjwiTo=; b=aHTsk9znEWWIs2hH4O/1QFIknQtBat8gybZ77Fka1ZuEsgeLbs80f6C3GhSxCraqe+ bIPg7jgjHBjT9pm3mulsih3DA1L7xuDI1xOGUvUAZu5XdNsrrlM2dntC6pwC+4hfbh6L AuUKqqB3kUm+KyQZlBA112MkQD0cL8j+lIsMAivPXo6UYmYOoyv3kwcUIcfSIZUc5edN Peqlj16Sd29YelY88/z8nrAEhjeuceLbclXz2bsnqugqoKxr/agFpQ8nMKkDp2yin8p5 3wWuDA/cSd2HH5XyITkbL3leSIEtTsjnvdGr/2mGK8C0mxkr5a3Z/vmrPVrb//Y85AuH no5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737426321; x=1738031121; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n9An6Tllw4eU1Dq9ytvRc+xUrMzA1mH4iMWGlHjwiTo=; b=pmVNboHT9dZZBmJgB0m0TH4086Id7Ky13lXEMuVRjfabwdKGasvoQtIClDILkjlzmq XP+a1AarusOW6YNkhE4L+gGafsPMbrW6/GPwaaZ6fXDMz3fsSOezHxMN8d1YcNfVftdJ 3q1CBU7pocW5HdqNnV9DkZWUomGT82Fs5sm9tUh5PcLCjoF9K/5+Ww87u4jZpU9Ws9zu dKBX85gGzDmU1FT9CewYW3aZZIn14O5O/drOM9lRign2g7OIMVaXSJ/j9K0W/dCop0uZ NIyCF5xAX7h3EBQTRdttMGDPrdapuSmb7Sfp1bdtUf52IbVkpiu9QEF4nPtHEX3ypD+6 zlXg== X-Gm-Message-State: AOJu0Yw08FoxlsMD9AX09fWQraJpEk4DI95zz8XBc8oe00GmtsMW4VLJ B8PTPm0UH8tHtn536LR8Ib+qXwHMmrVNlFjluF3jyEMuCFPMGEitqpHGDJKlYvF0v45wNZhQUAO YQnNlKvWfECgwIcrHpScbk6io0Y2G3RWY X-Gm-Gg: ASbGnctPiM5tIuyy4BVUEat0xjq9E93XzzwIWIfs/yRoe8nao3y3AjVDX+sM7z+95ji RqMMHS3QkbZVgDLQ6iiz4jLyadK7WvxBmPutWf7Aq/TsGTeMCh8+esQ== X-Google-Smtp-Source: AGHT+IFgLG76wqZ5EXxpYh5DYtwb9o6TeqzpW75UGDR1ZkI2Y0kf5yU9SJp8LuCP5Gs4H1+zkhT9at/TwyCGRmXwZp4= X-Received: by 2002:a05:6402:2706:b0:5d4:2ef7:1c with SMTP id 4fb4d7f45d1cf-5db7db078c2mr35366403a12.24.1737426320978; Mon, 20 Jan 2025 18:25:20 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 20 Jan 2025 20:25:18 -0600 From: Stefan Kangas In-Reply-To: (Stefan Kangas's message of "Mon, 20 Jan 2025 14:26:22 -0600") References: MIME-Version: 1.0 Date: Mon, 20 Jan 2025 20:25:18 -0600 X-Gm-Features: AbW1kvbFpFslOJCHcCGXy5jO-IcVss0gD7yKzGgJoOBk7BvZdwxhy4pnGjqJ6gc Message-ID: Subject: Re: bug#75712: HAVE_RSVG: svg_css_length_to_pixels doesn't handle RSVG_UNIT_CH To: 75712@debbugs.gnu.org Content-Type: multipart/mixed; boundary="000000000000afa7bc062c2e169f" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75712 Cc: Pip Cet X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000afa7bc062c2e169f Content-Type: text/plain; charset="UTF-8" Stefan Kangas writes: > In Bug#75451, Pip Cet writes: > >> svg_css_length_to_pixels doesn't handle the RSVG_UNIT_CH case. I don't >> know at which version rsvg started to offer this unit; it's not >> indicated in the header file. > > It seems to have been added in 2.58: > > https://gnome.pages.gitlab.gnome.org/librsvg/Rsvg-2.0/enum.Unit.html I came up with the following patch, but it's not ideal. With CSS 3, "the ch unit falls back to 0.5em in the general case, and to 1em when it would be typeset upright". https://www.w3.org/TR/css-values-3/#ch Unfortunately, this patch doesn't take into account the "direction" or "writing-mode" CSS attributes, which is what seems to specify the above. I couldn't find a way to easily get these CSS attributes using librsvg. Instead, I just naively assume that they are set to their default non-vertical value, and thus use 0.5em. That's not always going to work, obviously. While the "ch" attribute seems to be rarely used, it would be nice to get this detail right. I'm just not sure how to do it. Maybe look through the CSS by hand, searching for these strings and then parsing it out? But that's likely to be brittle, ugly, and hard to maintain. Anyone have any good ideas here? It's my first time fiddling with librsvg, so it's quite possible that I'm overlooking something. That said, I guess this could be installed as a stopgap, to have a better result than we have now for the common case. --000000000000afa7bc062c2e169f Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Support-SVG-ch-length-values.patch" Content-Disposition: attachment; filename="0001-Support-SVG-ch-length-values.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: a8492e24481c33d0_0.1 RnJvbSA2M2YwZGMwZTJhYmJkNzdjMWM2YTZiM2U0NDU1OTFkMDAwZTkxY2YxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBUdWUsIDIxIEphbiAyMDI1IDAzOjA0OjQ5ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g U3VwcG9ydCBTVkcgImNoIiBsZW5ndGggdmFsdWVzCgoqIHNyYy9pbWFnZS5jIChzdmdfY3NzX2xl bmd0aF90b19waXhlbHMpOiBTdXBwb3J0IFNWRyAiY2giIGxlbmd0aAp2YWx1ZXMuICAoQnVnIzc1 NzEyKQotLS0KIHNyYy9pbWFnZS5jIHwgMTIgKysrKysrKysrLS0tCiAxIGZpbGUgY2hhbmdlZCwg OSBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9pbWFnZS5j IGIvc3JjL2ltYWdlLmMKaW5kZXggYjg0MDVkODExMTEuLmI2Mjg1N2M3MTBhIDEwMDY0NAotLS0g YS9zcmMvaW1hZ2UuYworKysgYi9zcmMvaW1hZ2UuYwpAQCAtMTIwMDgsOSArMTIwMDgsMTUgQEAg c3ZnX2Nzc19sZW5ndGhfdG9fcGl4ZWxzIChSc3ZnTGVuZ3RoIGxlbmd0aCwgZG91YmxlIGRwaSwg aW50IGZvbnRfc2l6ZSkKIAkgd2hhdCBzaXplIHdlIG1ha2UgdGhlIGltYWdlLiAgKi8KICAgICAg IHZhbHVlID0gMDsKICAgICAgIGJyZWFrOwotICAgIGRlZmF1bHQ6Ci0gICAgICAvKiBXZSBzaG91 bGQgbmV2ZXIgcmVhY2ggdGhpcy4gICovCi0gICAgICB2YWx1ZSA9IDA7CisjaWYgTElCUlNWR19D SEVDS19WRVJTSU9OICgyLCA1OCwgMCkKKyAgICBjYXNlIFJTVkdfVU5JVF9DSDoKKyAgICAgIC8q IEZJWE1FOiBXaXRoIENTUyAzLCAidGhlIGNoIHVuaXQgZmFsbHMgYmFjayB0byAwLjVlbSBpbiB0 aGUKKwkgZ2VuZXJhbCBjYXNlLCBhbmQgdG8gMWVtIHdoZW4gaXQgd291bGQgYmUgdHlwZXNldCB1 cHJpZ2h0Ii4KKwkgSG93ZXZlciwgSSBjb3VsZCBub3QgZmluZCBhIHdheSB0byBlYXNpbHkgZ2V0 IHRoZSByZWxldmFudCBDU1MKKwkgYXR0cmlidXRlcyB1c2luZyBsaWJyc3ZnLiAgVGh1cywgd2Ug c2ltcGx5IHdyb25nbHkgYXNzdW1lIHRoZQorCSBnZW5lcmFsIGNhc2UgaXMgYWx3YXlzIHRydWUg aGVyZS4gIFNlZSBCdWcjNzU3MTIuICAqLworICAgICAgdmFsdWUgPSB2YWx1ZSAqIGZvbnRfc2l6 ZSAvIDIuMDsKKyNlbmRpZgogICAgIH0KIAogICByZXR1cm4gdmFsdWU7Ci0tIAoyLjQ4LjEKCg== --000000000000afa7bc062c2e169f-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 20 22:14:56 2025 Received: (at 75712) by debbugs.gnu.org; 21 Jan 2025 03:14:56 +0000 Received: from localhost ([127.0.0.1]:52768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ta4jA-0004T1-0c for submit@debbugs.gnu.org; Mon, 20 Jan 2025 22:14:56 -0500 Received: from mail-40131.protonmail.ch ([185.70.40.131]:28555) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ta4j7-0004Sl-2F for 75712@debbugs.gnu.org; Mon, 20 Jan 2025 22:14:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1737429285; x=1737688485; bh=VzCKxKyeiuNJyi6UztG2Y33DUWIQpyl7XfWm83QPwBo=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=Sybv+AmyK6+pMDV1qZsRYhvFxuyk33/DyXU2xNRoxcUdwSiu3FBsbvbT4YKTAr5RZ FVTv1lOWXQupzsgUjbLCur5AmBQvbw7tO4vsHzVa2E+fCxjSF/bU8tx1YyuU1tGlcG lFzsuHvgvB/79VLNQ7ZEqQPDzjJgSTvPctrblS4tyEeExpBN9cPYmjtiAC1/2sWemo m/zxGnbvlO0bnbg4Y9vielxJ7lh+pqICSzYfvzljVrcEwBeFjjCtZltWmUkAlBcLBx FeaWV5b6QlLiiF64iwsLB8zy3aXxUojvqc/RLSeNsHFpgdmkDAHlOS/0ooye9tMyAZ tHkjcH0Qp77WQ== Date: Tue, 21 Jan 2025 03:14:41 +0000 To: Stefan Kangas From: Pip Cet Subject: Re: bug#75712: HAVE_RSVG: svg_css_length_to_pixels doesn't handle RSVG_UNIT_CH Message-ID: <87cyggluxw.fsf@protonmail.com> In-Reply-To: References: Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 59f48d48bd73e58f4c6cdf0d73465117cc9c7b5d MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 75712 Cc: 75712@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "Stefan Kangas" writes: > Stefan Kangas writes: > >> In Bug#75451, Pip Cet writes: >> >>> svg_css_length_to_pixels doesn't handle the RSVG_UNIT_CH case. I don't >>> know at which version rsvg started to offer this unit; it's not >>> indicated in the header file. >> >> It seems to have been added in 2.58: >> >> https://gnome.pages.gitlab.gnome.org/librsvg/Rsvg-2.0/enum.Unit.html > > I came up with the following patch, but it's not ideal. I think it will do for the case of that single unit, but I was hoping for an improvement for what used to be the default case: we should probably error in the case of an unknown unit, or at least print a warning. I was assuming RSVG would provide a simple interface to get the string for a unit enum value, so we could print a meaningful message, but it seems an int is all we get. The header comment (which doesn't include the version numbers, thanks for providing a link to those!) reads: * If you test for the values of this enum, please note that librsvg may ad= d other units in the future * as its support for CSS improves. Please make your code handle unknown u= nits gracefully (e.g. with * a `default` case in a `switch()` statement). But I have no idea how to do that given the API defined by that file. As this is a fall-back case of a fall-back case, it may not be worth spending too much time on: set a flag to let the code after the switch statement know we've failed, print the integer value, error. > Unfortunately, this patch doesn't take into account the "direction" or > "writing-mode" CSS attributes, which is what seems to specify the above. > I couldn't find a way to easily get these CSS attributes using librsvg. > > Instead, I just naively assume that they are set to their default > non-vertical value, and thus use 0.5em. That's not always going to > work, obviously. > > While the "ch" attribute seems to be rarely used, it would be nice to > get this detail right. I'm just not sure how to do it. Maybe look > through the CSS by hand, searching for these strings and then parsing it > out? But that's likely to be brittle, ugly, and hard to maintain. I assumed this would be useful for SVG-based fonts, so we should probably make it depend on the Emacs environment rather than trying to derive it from the CSS. > Anyone have any good ideas here? It's my first time fiddling with > librsvg, so it's quite possible that I'm overlooking something. I'm afraid I can't really help. If I'd looked at the context of this bug more closely, maybe I would have ignored it. Pip From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 21 08:59:35 2025 Received: (at 75712) by debbugs.gnu.org; 21 Jan 2025 13:59:35 +0000 Received: from localhost ([127.0.0.1]:53744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1taEn0-0000o4-Mo for submit@debbugs.gnu.org; Tue, 21 Jan 2025 08:59:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53680) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1taEmy-0000np-KA for 75712@debbugs.gnu.org; Tue, 21 Jan 2025 08:59:33 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1taEmt-0007VU-7i; Tue, 21 Jan 2025 08:59:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=HlYRDmq0PIq+AtONDxySR12I9EZm9WUeB5W7MhsWHM0=; b=qbXtxu7S681c lUAISMWPXmLml5RduSUNWmBG3rd5gKkvBA4dnyCa9VXqk3fGt9zcP/ZEISHtqxBrGotZR+CyH/ckH H3zvVSGVSJjl5k2o9BR2kY6oAaW5hdJWBDbhF6qvUwUSa5gvk9TR/xBJH7z1Heyp+Rgq/pqnJX5y6 So7F2DqlDgrWG7rS0SZb6QUAdKhUpb5TGoSC2qH41QjVhQQ/DLEIAc17Jy/L7MpDMWi8KnywUT01I xc8BpSkvlf9qS4BoKKCsmrZ+RLi728UPIvEGFH9us0gEC5UVIk+2NLKk/m/k4sv9fAtWR6XiE/Q8P tGyg/q9tT7LQ6yXez0U8rQ==; Date: Tue, 21 Jan 2025 15:59:16 +0200 Message-Id: <861pww5kuj.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Mon, 20 Jan 2025 20:25:18 -0600) Subject: Re: bug#75712: HAVE_RSVG: svg_css_length_to_pixels doesn't handle RSVG_UNIT_CH References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75712 Cc: 75712@debbugs.gnu.org, pipcet@protonmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Pip Cet > From: Stefan Kangas > Date: Mon, 20 Jan 2025 20:25:18 -0600 > > --- a/src/image.c > +++ b/src/image.c > @@ -12008,9 +12008,15 @@ svg_css_length_to_pixels (RsvgLength length, double dpi, int font_size) > what size we make the image. */ > value = 0; > break; > - default: > - /* We should never reach this. */ > - value = 0; > +#if LIBRSVG_CHECK_VERSION (2, 58, 0) > + case RSVG_UNIT_CH: > + /* FIXME: With CSS 3, "the ch unit falls back to 0.5em in the > + general case, and to 1em when it would be typeset upright". > + However, I could not find a way to easily get the relevant CSS > + attributes using librsvg. Thus, we simply wrongly assume the > + general case is always true here. See Bug#75712. */ > + value = value * font_size / 2.0; > +#endif This makes the code worse for librsvg versions before 2.58. Why not keep the old code for older versions? Also, pointing to bug#75712 is not useful here: this bug had accrued too many completely unrelated messages, so anyone who'd like to have more details about this issue will curse us. How about explaining the main issues here in this very comment instead? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 21 10:04:47 2025 Received: (at 75712) by debbugs.gnu.org; 21 Jan 2025 15:04:47 +0000 Received: from localhost ([127.0.0.1]:55719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1taFo7-0004xZ-6V for submit@debbugs.gnu.org; Tue, 21 Jan 2025 10:04:47 -0500 Received: from mail-4316.protonmail.ch ([185.70.43.16]:48821) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1taFo4-0004xG-Ch for 75712@debbugs.gnu.org; Tue, 21 Jan 2025 10:04:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1737471877; x=1737731077; bh=3ySENA7/qn/0KJanZYpERRUBFahlWeFYrL+nEpaRDQQ=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=WngfkJxXy4RsszZyEVvGyrJ2ChL1+iuPJkcD/ioFg4AY0x/0QYW6oFyE2EXGhGdIX /HdTsmApJlDce4oIGLJjTpQKLEU9EA+kbV7QGPkBmaUpNuqopxZbcex24dG33GJ2Cm v4CA+mD9UjidPPIZbue4pnbH6v9BVMMvF1l2lAMpLtsGZFt97JUwptjvRzeIIy2MXy q4gMp037nXIlktaR/I5bTJX8nkqOd7OMKFWj25924aqy+TAKy2w14MY2bbcROSLe/A MqnPMGNeGkLB+qtr5DrXcoTboqbvZm5QJlFSrmhdK3RsRyuKvrlSLQgZSe95BFFhwo hyPBEnhP8c73w== Date: Tue, 21 Jan 2025 15:04:33 +0000 To: Eli Zaretskii From: Pip Cet Subject: Re: bug#75712: HAVE_RSVG: svg_css_length_to_pixels doesn't handle RSVG_UNIT_CH Message-ID: <87bjw0xl6s.fsf@protonmail.com> In-Reply-To: <861pww5kuj.fsf@gnu.org> References: <861pww5kuj.fsf@gnu.org> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: a954dd01c9c9728c7782e16c7753041f8158d510 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75712 Cc: 75712@debbugs.gnu.org, Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "Eli Zaretskii" writes: >> Cc: Pip Cet >> From: Stefan Kangas >> Date: Mon, 20 Jan 2025 20:25:18 -0600 >> >> --- a/src/image.c >> +++ b/src/image.c >> @@ -12008,9 +12008,15 @@ svg_css_length_to_pixels (RsvgLength length, do= uble dpi, int font_size) >> =09 what size we make the image. */ >> value =3D 0; >> break; >> - default: >> - /* We should never reach this. */ >> - value =3D 0; >> +#if LIBRSVG_CHECK_VERSION (2, 58, 0) >> + case RSVG_UNIT_CH: >> + /* FIXME: With CSS 3, "the ch unit falls back to 0.5em in the >> +=09 general case, and to 1em when it would be typeset upright". >> +=09 However, I could not find a way to easily get the relevant CSS >> +=09 attributes using librsvg. Thus, we simply wrongly assume the >> +=09 general case is always true here. See Bug#75712. */ >> + value =3D value * font_size / 2.0; >> +#endif > > This makes the code worse for librsvg versions before 2.58. Why not > keep the old code for older versions? If the librsvg library and the librsvg headers are both old, this code is never reached. If the headers were old but the library has been updated, I agree that the change in behavior is incorrect. Returning 0 means we can't do anything with the unit, which is true. Here's a proposed patch which: 1. prints a warning about this situation (in case the library changes) 2. omits the default label so GCC also warns, even without -Wswitch-enum (in case the headers change) 3. includes too much commentary rather than too little. diff --git a/src/image.c b/src/image.c index b8405d81111..28d55a575ee 100644 --- a/src/image.c +++ b/src/image.c @@ -11965,34 +11965,27 @@ svg_css_length_to_pixels (RsvgLength length, doub= le dpi, int font_size) { case RSVG_UNIT_PX: /* Already a pixel value. */ - break; + return value; case RSVG_UNIT_CM: /* 2.54 cm in an inch. */ - value =3D dpi * value / 2.54; - break; + return dpi * value / 2.54; case RSVG_UNIT_MM: /* 25.4 mm in an inch. */ - value =3D dpi * value / 25.4; - break; + return dpi * value / 25.4; case RSVG_UNIT_PT: /* 72 points in an inch. */ - value =3D dpi * value / 72; - break; + return dpi * value / 72; case RSVG_UNIT_PC: /* 6 picas in an inch. */ - value =3D dpi * value / 6; - break; + return dpi * value / 6; case RSVG_UNIT_IN: - value *=3D dpi; - break; + return value * dpi; case RSVG_UNIT_EM: - value *=3D font_size; - break; + return value * font_size; case RSVG_UNIT_EX: /* librsvg uses an ex height of half the em height, so we match =09 that here. */ - value =3D value * font_size / 2.0; - break; + return value * font_size / 2.0; case RSVG_UNIT_PERCENT: /* Percent is a ratio of the containing "viewport". We don't =09 have a viewport, as such, as we try to draw the image to it's @@ -12006,14 +11999,27 @@ svg_css_length_to_pixels (RsvgLength length, doub= le dpi, int font_size) =09 spec, this will work out correctly as librsvg will still =09 honor the percentage sizes in its final rendering no matter =09 what size we make the image. */ - value =3D 0; - break; - default: - /* We should never reach this. */ - value =3D 0; - } - - return value; + return 0; +#if LIBRSVG_CHECK_VERSION (2, 58, 0) + case RSVG_UNIT_CH: + /* FIXME: With CSS 3, "the ch unit falls back to 0.5em in the +=09 general case, and to 1em when it would be typeset upright". +=09 However, I could not find a way to easily get the relevant CSS +=09 attributes using librsvg. Thus, we simply wrongly assume the +=09 general case is always true here. See Bug#75712. */ + return value * font_size / 2.0; +#endif + } + + /* The rsvg header files say that more values may be added to this + enum, but there doesn't appear to be a way to get a string + representation of the new enum value. The unfortunate + consequence is that the only thing we can do is to report the + numeric value. */ + image_error ("Unknown RSVG unit, code: %d", (int) length.unit); + /* Return 0; this special value indicates that another method of + obtaining the image size must be used. */ + return 0; } #endif =20 > Also, pointing to bug#75712 is not useful here: this bug had accrued > too many completely unrelated messages, so anyone who'd like to have Wrong bug. This is bug#75712. Pip From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 21 10:18:25 2025 Received: (at 75712) by debbugs.gnu.org; 21 Jan 2025 15:18:25 +0000 Received: from localhost ([127.0.0.1]:55761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1taG1J-0005m3-FJ for submit@debbugs.gnu.org; Tue, 21 Jan 2025 10:18:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35024) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1taG1H-0005lb-BF for 75712@debbugs.gnu.org; Tue, 21 Jan 2025 10:18:23 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1taG1C-00044e-1p; Tue, 21 Jan 2025 10:18:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=LbJJdSsv8cUVc0Rif00uJyd5n4TRqiOi0BEANzBZvZU=; b=f4e0tlRhOWvW ZfdephFpYPu6qezTRw7uIf6mum6+tFrfK7GFCYWcf1Tj2OQKMXkbSizeMV7AVIB3O+zSSAt3vndYM X7yGUoAV6jniJU9fZtpTvHoFMQf+hjSIEPy+nDI5pKXA9/ew011x4EhVDNc2Ns92Ec2zE2QPd50Ts +zWic7BVJcGhrXtXVp0kzAJXbb29toVXHX1a6tMQ6cyudf54Navk43bH5RtriR0sPFvHfGAAHw1r+ aCKcpl6kz7gnja9SBLjqOKE6lJ6rZTKRwp11CuwMHR78JnBfNFKU8zUnzj5DZXBGYT6bn1L0Jnp/y OA3sNW3fVXMfXUr+3wjprQ==; Date: Tue, 21 Jan 2025 17:18:14 +0200 Message-Id: <86ldv442mh.fsf@gnu.org> From: Eli Zaretskii To: Pip Cet In-Reply-To: <87bjw0xl6s.fsf@protonmail.com> (message from Pip Cet on Tue, 21 Jan 2025 15:04:33 +0000) Subject: Re: bug#75712: HAVE_RSVG: svg_css_length_to_pixels doesn't handle RSVG_UNIT_CH References: <861pww5kuj.fsf@gnu.org> <87bjw0xl6s.fsf@protonmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75712 Cc: 75712@debbugs.gnu.org, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Tue, 21 Jan 2025 15:04:33 +0000 > From: Pip Cet > Cc: Stefan Kangas , 75712@debbugs.gnu.org > > Here's a proposed patch which: > 1. prints a warning about this situation (in case the library changes) > 2. omits the default label so GCC also warns, even without -Wswitch-enum > (in case the headers change) > 3. includes too much commentary rather than too little. LGTM, thanks. But please wait for Stefan to comment. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 21 13:30:05 2025 Received: (at 75712) by debbugs.gnu.org; 21 Jan 2025 18:30:05 +0000 Received: from localhost ([127.0.0.1]:56062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1taJ0i-0004wh-W6 for submit@debbugs.gnu.org; Tue, 21 Jan 2025 13:30:05 -0500 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]:47414) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1taJ0f-0004wT-IG for 75712@debbugs.gnu.org; Tue, 21 Jan 2025 13:29:58 -0500 Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-5d3d143376dso9075823a12.3 for <75712@debbugs.gnu.org>; Tue, 21 Jan 2025 10:29:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737484180; x=1738088980; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=tikEtNIII3QfaluchQKqHznxkBZiZeNDwkh94//1t34=; b=lWm01HisfdkOjvsP9MQixaLWBF2b9D3NVPQ76rCR8x3QBNFSqcj4agZaQ+sSo4kZbE pUiEm5FsPias4exYR6+zNXbjJf0Xt0VieZmyslG8w/5gxu9iJulOsXNvXx1yTTZfGYzN 6nI1f5Og6xYVIPYXwx/r/Wzxf7XE2wnLh+2zScgrGQrCPr9HK7yRKCdGz9EFJ5I1Dq/L 4nSzl5HresatRTLFvgEUJCy9q2yUKUYGVg46Jwrq7P1nAZYh/fYyhTfOyCyVcfpgzOvE OlipLZfcm623TR2wwXOjdRuWJ6+6RSFmcZv9Ldlv8Ec0bA4H3xJK6lef9PbYEJ2uB/V6 clNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737484180; x=1738088980; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tikEtNIII3QfaluchQKqHznxkBZiZeNDwkh94//1t34=; b=jaURvkYTsrxH4oUjDO4iQkhS7NjmH7020JIL3HGVgm/e2gR9rQ9sZS5U1klEOUpiiu n/iswiAwhqUEHWIInW+zZVgufJNvF6P6NvKqK51kyMTBT4v8epQDdIn7X+sG5nKd+ujc dULSyEGqs9XaPRf229wGXaVoB7O1DT45fSPcjzg15Q2W4bgXfbqNCBuHKwfem5g2lL2c ZIHg4f6TVOAqO1tZPovD8OnytCrlFNMvX2KssCRKf3SUp/Y7/LtiUZz71TRQzsqjqWxZ M6axobGFXAuY5Af6ytwCifdhzLM7v7EJfuIE7PWby0PuqPFspPMMP+rf/15z47m+Fd51 iaXw== X-Gm-Message-State: AOJu0Yw1moe0iytEnixab7g7u/F5Jmg/B5HUIm/zBCwVVvvBZ5iSNJjD gNpQkh3dj61T1ESdRWi2MznpUkKvj7EI1Ex/vYfA9irZhAQ8Je33gaZXPSQZl0egcPcxIzbplC4 6iPL4lLtWfTnGVu5MueSi8ZfYyZE= X-Gm-Gg: ASbGncvXqjfVKcx0B+Hh52Qd6ApePP0qIV+Qafsqc3kRO0dxa4mwjI4zUTuHeRBD+EY yi0ZYgINAjc3iz+MmPeVA1N8kitG/OnSfdQJuxreb34oA5g2p5JwA X-Google-Smtp-Source: AGHT+IE6xNMIGPA9YDbSVCkxMgSuSZruloXg1u0rtPli1V/LnZf3VEZKFfhBuEt7TzKUvkU5rA5cjOE9yr03nXxSC+U= X-Received: by 2002:a05:6402:35c2:b0:5d9:f21e:ff5 with SMTP id 4fb4d7f45d1cf-5db7d30113fmr16890800a12.16.1737484179866; Tue, 21 Jan 2025 10:29:39 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 21 Jan 2025 10:29:39 -0800 From: Stefan Kangas In-Reply-To: <86ldv442mh.fsf@gnu.org> References: <861pww5kuj.fsf@gnu.org> <87bjw0xl6s.fsf@protonmail.com> <86ldv442mh.fsf@gnu.org> MIME-Version: 1.0 Date: Tue, 21 Jan 2025 10:29:39 -0800 X-Gm-Features: AbW1kvar1wGTedhsIjEUT9R2qE3SG8rlTnog_c-SKyBS9nwOrI1xauEtms5VDO0 Message-ID: Subject: Re: bug#75712: HAVE_RSVG: svg_css_length_to_pixels doesn't handle RSVG_UNIT_CH To: Eli Zaretskii , Pip Cet Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75712 Cc: 75712@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Date: Tue, 21 Jan 2025 15:04:33 +0000 >> From: Pip Cet >> Cc: Stefan Kangas , 75712@debbugs.gnu.org >> >> Here's a proposed patch which: >> 1. prints a warning about this situation (in case the library changes) >> 2. omits the default label so GCC also warns, even without -Wswitch-enum >> (in case the headers change) >> 3. includes too much commentary rather than too little. > > LGTM, thanks. But please wait for Stefan to comment. LGTM, please install. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 21 14:13:01 2025 Received: (at 75712-done) by debbugs.gnu.org; 21 Jan 2025 19:13:01 +0000 Received: from localhost ([127.0.0.1]:56606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1taJgK-0007rd-W8 for submit@debbugs.gnu.org; Tue, 21 Jan 2025 14:13:01 -0500 Received: from mail-4322.protonmail.ch ([185.70.43.22]:11483) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1taJgB-0007rB-SI for 75712-done@debbugs.gnu.org; Tue, 21 Jan 2025 14:12:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1737486764; x=1737745964; bh=eDmhTDBMIp75Jk6oxeYpeQYQ9ooFT9DT+MUEXNmNc08=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=kocFxViAKai2z7AmxPR902+b2sz6M2POMWHsMQ4ac83h/eh87nB62YkuFQDlLVCz2 UNcK105sMsWBZ3I2feliXglAiu2NBy+JpQFh78qxooTVzykaw3MpQrHFV+Wgr7R5r4 8IddvL817XcUgNCch4P9dME786v5F6nnMrdI4USJMXkiRlleaqA6pjfLjXkfs32KNi b8GzdlC6G1pCAFAisY5q6JjNGy568NldGouVbjF7RHesDdcLRoi8PqJy2Pg9s8D8IX 4grgNx9sk6ZTj6wFXHrZ1H2DBTISYC1hbYsdERra0KfCfgR8IfyqdKdo1ilahkG2cR 0arZtMXkn41iA== Date: Tue, 21 Jan 2025 19:12:40 +0000 To: Stefan Kangas From: Pip Cet Subject: Re: bug#75712: HAVE_RSVG: svg_css_length_to_pixels doesn't handle RSVG_UNIT_CH Message-ID: <877c6okmlb.fsf@protonmail.com> In-Reply-To: References: <861pww5kuj.fsf@gnu.org> <87bjw0xl6s.fsf@protonmail.com> <86ldv442mh.fsf@gnu.org> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 48075f2e0f67cefc33b9699778aaa0688dccd031 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: 75712-done Cc: Eli Zaretskii , 75712-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.1 (-) "Stefan Kangas" writes: > Eli Zaretskii writes: > >>> Date: Tue, 21 Jan 2025 15:04:33 +0000 >>> From: Pip Cet >>> Cc: Stefan Kangas , 75712@debbugs.gnu.org >>> >>> Here's a proposed patch which: >>> 1. prints a warning about this situation (in case the library changes) >>> 2. omits the default label so GCC also warns, even without -Wswitch-enu= m >>> (in case the headers change) >>> 3. includes too much commentary rather than too little. >> >> LGTM, thanks. But please wait for Stefan to comment. > > LGTM, please install. Pushed, closing. Minor change compared to the patch I posted: PSA: image_error takes Lisp_Object arguments, not integers. Something for your (ever-growing, no doubt) TODO list, maybe? Pip From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 21 14:24:23 2025 Received: (at 75712) by debbugs.gnu.org; 21 Jan 2025 19:24:24 +0000 Received: from localhost ([127.0.0.1]:56628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1taJrI-0000DG-5f for submit@debbugs.gnu.org; Tue, 21 Jan 2025 14:24:23 -0500 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]:59858) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1taJrC-0000D0-0u for 75712@debbugs.gnu.org; Tue, 21 Jan 2025 14:24:17 -0500 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-3862d161947so3278100f8f.3 for <75712@debbugs.gnu.org>; Tue, 21 Jan 2025 11:24:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737487447; x=1738092247; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=xky/mKMEV9TTdAmUy7Y8cMt/crMhO9cT5OhZXWiIXrc=; b=aWLCVrIDvOs7Y11M6vcs5fMQ+TghoVqoL28IJhuP3IK+jkhixKnP31Vdtxq4O4ne7W ce8YiIGniPc0NpkKnaZwtiZjGu+NRzUkp30dfBlgX3hL6TJeME+cG0gbo3fG6EaeR1TL L5iiYjgb625vzHvQ50Iy2Wb1/mcPgji4Nmo28ZD3jkCdNg1XjcY+/Ia2eKyLCctkdjV/ BW6DWdy2JAPWdUqdAfFqJq17LOQAu8g7wAfl6/kgvlxITORkkUsJtDshdcNySriAZfwM r7CaEx+ykVrEy/lthH3M5+Z+CTIn9DjhxkA5HLs79TpWN4GXvAD7xgDS6fei9I7O7S+e ySEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737487447; x=1738092247; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xky/mKMEV9TTdAmUy7Y8cMt/crMhO9cT5OhZXWiIXrc=; b=Hvo0iNUuTF7k0wCowq8lgf01y8o/M7adri9x7fFiqpJJC/QCYnEosEDQ9zIvUYROqG BsybapxZn5KYiqBbxYIVioSd9yg/7/5RrQtrOIfgcaSTn+LKHvt5tpvDCnlmEKJZHwRx XAeRUQuZ6YAz5HtYqameEFV6JCBrg0rjkn0rHp+6L4foo48z7npsD/3HqN4gnkq+C0WP fCcL4H1Rw9M2glEGY4AIYuFuLSPyObW3PNV9HDb3HTH3qwczP69PQewfxdyJOY/ZfbxG ZzMBRBKjs18pWIQi/uTiyXEZ/2Jj1zagXbyZUTiUJbD7ozSTWYZGlXo9IZ0B7+f5GRds Xzng== X-Gm-Message-State: AOJu0YzzcIdY5gAIVcFO73VipigJ0+i7qY1KMRTAVaiDVsGWTZ89VPl2 i/3gPd5BMRHO0frBBKcngekqesXMGbkALEAlJYo6JpWkj6iDe/5v X-Gm-Gg: ASbGncuPuAybXECL+2Wx1JWHFTa4tS3E6q8shZjSPx8SnBiTfxAmtRr1p4Kg/302hcJ Qt6dR5HVriIzKsl0rBGMa0aiHFf7WGQU0MnY6mrjW4Un3PARvKFQH0Rm/g8L9D/gsnZrTSHnfZ9 fjBNwuJSRCl6jx/Tnjc/WD5rwM3uWrwSL32hrci5SerY02sPRZI+mv9g3kyZd3kEz/kvSeL3tgF IxRCmWFisOV6XLSOVzfAGn6WXWdIcwiltWj7rdtgLvNFDc/5J9ZFiQWEJU21tXh574z8eB7lKzu k2m8mAUbDMrzGvZKCSF8LXgUTUilyQdQaXi27AVeDKDCdae4G7i/aHP/HAntPAQJyYC59QcCWND 2jAs= X-Google-Smtp-Source: AGHT+IGcNZawX41AFV32ef/4mr/MF9bdSzc4bdeh1hwX/I/QrL8ud7xoKC7jDuhQBqaVAk2yAlzpBA== X-Received: by 2002:a5d:52c2:0:b0:386:3b93:6cc6 with SMTP id ffacd0b85a97d-38bf566351emr15912852f8f.15.1737487446899; Tue, 21 Jan 2025 11:24:06 -0800 (PST) Received: from pro2 (p200300e0b7075b00e0ae87c3d1bec7a6.dip0.t-ipconnect.de. [2003:e0:b707:5b00:e0ae:87c3:d1be:c7a6]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf3221b70sm13978496f8f.26.2025.01.21.11.24.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2025 11:24:06 -0800 (PST) From: =?utf-8?Q?Gerd_M=C3=B6llmann?= To: 75712@debbugs.gnu.org Subject: Re: bug#75712: HAVE_RSVG: svg_css_length_to_pixels doesn't handle RSVG_UNIT_CH In-Reply-To: <877c6okmlb.fsf@protonmail.com> (Pip Cet via's message of "Tue, 21 Jan 2025 19:12:40 +0000") References: <861pww5kuj.fsf@gnu.org> <87bjw0xl6s.fsf@protonmail.com> <86ldv442mh.fsf@gnu.org> <877c6okmlb.fsf@protonmail.com> Date: Tue, 21 Jan 2025 20:24:05 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75712 Cc: pipcet@protonmail.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Pip Cet via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > "Stefan Kangas" writes: > >> Eli Zaretskii writes: >> >>>> Date: Tue, 21 Jan 2025 15:04:33 +0000 >>>> From: Pip Cet >>>> Cc: Stefan Kangas , 75712@debbugs.gnu.org >>>> >>>> Here's a proposed patch which: >>>> 1. prints a warning about this situation (in case the library changes) >>>> 2. omits the default label so GCC also warns, even without -Wswitch-enum >>>> (in case the headers change) >>>> 3. includes too much commentary rather than too little. >>> >>> LGTM, thanks. But please wait for Stefan to comment. >> >> LGTM, please install. > > Pushed, closing. Minor change compared to the patch I posted: > > PSA: image_error takes Lisp_Object arguments, not integers. Something > for your (ever-growing, no doubt) TODO list, maybe? > > Pip Maybe something --enable-check-lisp-object-type would be good for. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 21 15:02:52 2025 Received: (at 75712) by debbugs.gnu.org; 21 Jan 2025 20:02:52 +0000 Received: from localhost ([127.0.0.1]:56753 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1taKSa-0002Oy-5y for submit@debbugs.gnu.org; Tue, 21 Jan 2025 15:02:52 -0500 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]:48274) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1taKSX-0002Oa-D6 for 75712@debbugs.gnu.org; Tue, 21 Jan 2025 15:02:50 -0500 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-5d7e3f1fdafso12247024a12.0 for <75712@debbugs.gnu.org>; Tue, 21 Jan 2025 12:02:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737489763; x=1738094563; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=bdUTHEHxjnxHMeLvgVDKaNS7u+mQKsx6xvNRHkvw0HY=; b=azSl24Y2z42z6IaNIfyXAYapBPkIWefEWE1GxXWw2Rp8G+duQXjxfFYU+nYxd0GX+l WNYdT3mkXTECv1mENNKfnDR3+U+hr/O0il7+C70ZE1FbzCRvbO42xwlJI0TmmnlYzkV5 R8Ixc18DYDnGWz472ynfsZqEpTEC+dNEawL6bRzcMi+h2cpbW1FvKA3LE+fCPDgPeA4m 52yR85ORZzhCeBxzvaU3DZKKcdZzILNFxBeU90tQXW4blJXbWPTftfMAhPJkSTeun24j zHXOrpL0dLVIN5Nk75qx3aEJTuKVCVhyIfT8/dvGgQaYeA3HgH41vlReRvp46cDXBXyE 84Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737489763; x=1738094563; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bdUTHEHxjnxHMeLvgVDKaNS7u+mQKsx6xvNRHkvw0HY=; b=LbhYsIjNViF2FeSN3ghRusP0cWsJTMgXFBda/eZI5E/RXkukJqVjzLOd1wp2L8T+BF f54ZfySTy+MHXXbdX2tjIT5msGg6Am6SaaZ30R40WvRl6qGz5COhWX9NS/aZcfrH4t+1 pCuBxr1haAkEj7S2S1/arjJRNR6uc8chHvlQARUONiEzFZ8Ky2WdhFUqwkWrHUPhJJdK HVv/b9qPfXW37OoCLJF+yuIEfA2B6MgQ2pF9h9+CEE6MecjLkMPKij2kKQ3Bgx1CbVFe 9m4kzxmRHMFPKyZM1XApBRU8kzoFaXNUPrMAwO3yClv/iND7iBoSIBDsJ2gyd/+dW0qK AS1g== X-Forwarded-Encrypted: i=1; AJvYcCVSBcBu8yrbjQmrSfZk3/bn+j+Pd2goui7cFaOSB/wfCS03/L1je06mDDkylVg29C5JHzTKDQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwEhzVa/l7f2W0zquJkUZKHKscgGg07DIJV051OnXs/ZVjvBteq EQG4Qf6Gle+EflM0/hmo+63UFm6rXyRmmrdK6POh6sTWR2MK63PCfpzYkvwJHp2Be+9d/Sck66b BKQiBGN6EHAE1vr/cZU4v0h0e9d8= X-Gm-Gg: ASbGnct8ovB9LXh0MV1AMnb7hXmWiVF+mn5ZpKLthvgEe0WzYPAANJ3l6gBkGb9FJge vgaXIUhVxfT8EnBXgMNQ4RB5ArFTWZb9cnS8sgMCBRU0uwQMaw73N X-Google-Smtp-Source: AGHT+IFyXLraneRYeaoComesWCK0StNxzEdl/jVs9prEEegyc1qcx67plVqMLx8+KSRXXMvopEsJrulNFSMMuiLqekg= X-Received: by 2002:a05:6402:2792:b0:5da:105b:86c2 with SMTP id 4fb4d7f45d1cf-5db7db078b7mr14992295a12.20.1737489762790; Tue, 21 Jan 2025 12:02:42 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 21 Jan 2025 12:02:42 -0800 From: Stefan Kangas In-Reply-To: <877c6okmlb.fsf@protonmail.com> References: <861pww5kuj.fsf@gnu.org> <87bjw0xl6s.fsf@protonmail.com> <86ldv442mh.fsf@gnu.org> <877c6okmlb.fsf@protonmail.com> MIME-Version: 1.0 Date: Tue, 21 Jan 2025 12:02:42 -0800 X-Gm-Features: AbW1kvZ14QRqYpO0b26DUlK9qKrCRh9_mqMi4cdYtL_erq1D2b0_Wa4lB9JGWgc Message-ID: Subject: Re: bug#75712: HAVE_RSVG: svg_css_length_to_pixels doesn't handle RSVG_UNIT_CH To: Pip Cet Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75712 Cc: 75712@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Pip Cet writes: > PSA: image_error takes Lisp_Object arguments, not integers. Something > for your (ever-growing, no doubt) TODO list, maybe? Sorry, you lost me. What do you propose here? image_error should accept things like an image.spec, so I don't see how it could be changed to accept integers. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 21 17:49:28 2025 Received: (at 75712) by debbugs.gnu.org; 21 Jan 2025 22:49:28 +0000 Received: from localhost ([127.0.0.1]:57719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1taN3o-0003ZW-3f for submit@debbugs.gnu.org; Tue, 21 Jan 2025 17:49:28 -0500 Received: from mail-10631.protonmail.ch ([79.135.106.31]:37791) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1taN3m-0003Z9-2I for 75712@debbugs.gnu.org; Tue, 21 Jan 2025 17:49:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1737499759; x=1737758959; bh=R0MoEUCByPP5y4qEM4rvVZ2R+07gxHC70DytqlcKgD4=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=k5340vQ60JlpPBPd0BLzCrqbj5RM9rttoSV1F1QOnE265/baKd0lSr72Jy3Du7F+X wozAyC6vBtWCyzxqHxbkaNVFXQiPp3Q+bseYL6rEcBikGgAkfdR+DGf95Jm/QuqW8G ruda5TfWjncfEuX6oabqwv8rOzXvrqMd2cu0UUHCkBrRmqoVvyJ8ke91st4GpH+713 WxT4iUqhZdRcU7UFc3h/WQU/iE3lqrShU8rcncJmwX8vZhn/OmJzLF2vx4eByuzdXx qwI7gl/NvYDr5oA7UTeyJE+e9Irz2Uy3fb8H4IRsQKmp1g+skboZ+gS/P2Jf2IiKyX wWHONh4Vq1dMg== Date: Tue, 21 Jan 2025 22:49:13 +0000 To: Stefan Kangas From: Pip Cet Subject: Re: bug#75712: HAVE_RSVG: svg_css_length_to_pixels doesn't handle RSVG_UNIT_CH Message-ID: <87o6zzn5pa.fsf@protonmail.com> In-Reply-To: References: <861pww5kuj.fsf@gnu.org> <87bjw0xl6s.fsf@protonmail.com> <86ldv442mh.fsf@gnu.org> <877c6okmlb.fsf@protonmail.com> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: ab43e3e01f8b2ddb64969a418b59f4d4a745875d MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75712 Cc: 75712@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "Stefan Kangas" writes: > Pip Cet writes: > >> PSA: image_error takes Lisp_Object arguments, not integers. Something >> for your (ever-growing, no doubt) TODO list, maybe? > > Sorry, you lost me. What do you propose here? I was proposing type safety, thinking there might be a better way than replacing image_error and add_to_log by macros. Didn't find one, did the macro thing, didn't find any bugs, so probably not worth a commit. I kind of think tiff_handler should use image_error, not add_to_log, but the two have been equivalent forever. > image_error should accept things like an image.spec, so I don't see how > it could be changed to accept integers. While we can mix and match Lisp_Objects and POD C types freely in varargs situations, it seems, all the symbols would clash (I thought %S was safe, but doprnt.c makes it an alias for %s), and there's little point anyway since using nonstandard format specifiers breaks ATTRIBUTE_FORMAT_PRINTF. So no real proposal left here. listn is a strange animal and we should probably use Flist instead, but that should wait until purespace is gone, so no patch there, either. Pip From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 21 18:40:23 2025 Received: (at 75712) by debbugs.gnu.org; 21 Jan 2025 23:40:23 +0000 Received: from localhost ([127.0.0.1]:58111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1taNr0-0006qu-Vg for submit@debbugs.gnu.org; Tue, 21 Jan 2025 18:40:23 -0500 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]:55644) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1taNqt-0006ll-V1 for 75712@debbugs.gnu.org; Tue, 21 Jan 2025 18:40:16 -0500 Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-5d3d14336f0so11442469a12.3 for <75712@debbugs.gnu.org>; Tue, 21 Jan 2025 15:40:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737502806; x=1738107606; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=cS5FcK5IoulPOMdTQgEu/KfT+1AOytvOznXeD6cs2x4=; b=SClFpImvARPjL3l7GBhKFcI7rupP2K5XnXn3a0Mz4AtjrkyTveqoLkbkyhmP8gVy/r HryAKUbr6AdI7CKzEkHEmzICAqaZ9LuGKljuyXEdwzoOP8VplHSgI5+0BkvN7DolDWuJ IT817A9EuDHWhFJmFy6e54uHW3FroXHkP0jjy+sbIxfk9a9/wGLswryjQKBYiif94vvP 4Gelp3Bz544TemUG6+sZ9VVQtLdABUAIkW5CYcmWnOdY6rTEYrD0XF1DSy6woEYpB250 V1kLnnc0EK/2A1Ibf+3gfcVixiad58wjjGKx5PQ/griymXi6z262+EnFZigRcUzl4N50 EW5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737502806; x=1738107606; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cS5FcK5IoulPOMdTQgEu/KfT+1AOytvOznXeD6cs2x4=; b=wyLRVPVtOHhZI30ZKlvEiokZUU75NKBOOEkgcSCfamGf77mBpC0vQXaLXKWjKP3yQo u+gEUYCpkSnwVpZ7mSMgIkyqwRkcGH9+ZXgZiJlkg/IhNVf7QPFrFlOFzg5RPXWXZinO iCymJwJq357RipWKlOLsdy2UTTgfNnRDmovz+tO0wyg2ypAoLffK+0Z6Mj9+zMAxPZLT r00frX8Rseu2tL5IsSyL+JD8lIA+9hi4ln/9oKqZZW+QJTPdC4pY3kgO7/liYrj7jNrw JMcnAyxNj0dNqu0WkHKNAfhRjnlOVXAVbq/70ENT8WwGNmgez6jXYSYDYWavDWuct/G2 eE1A== X-Forwarded-Encrypted: i=1; AJvYcCVU2kU24vxiZPdMboC+TpUs5/XkSOcpBnIFD2SSQ7Et7KYfOL6HyRlP8cuOdNvLNsEFrKXlrg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzebuJuF4RmKWAI2r68cHT4POyUcGI/N4dSVTno1ECzf/SnJ1jg N0CauJ47srObf6Od/c58J6u4Mlou0W0Fw3E1platSK2b1zAnLvH+/VD/nv7E2ya+vZZxgySt2Ze e2mYVKgRagU/ExWoN/cJdOyhy6u0= X-Gm-Gg: ASbGncv8tZlkGQ8dJScygw7c9lEiNNT5hB2qZsUSzhY6cqv9K31Yw4MXDghVE9QmSyy Cp5N7Azs9Zjoe6NxF6+wggnlmfcpHhmtIOyWJQSItqYxJjCvlpCbuLg== X-Google-Smtp-Source: AGHT+IE+yeA2WH8mBDaw/5prp8Q+IRp6aSzprHd3qsv0xslKRXoeAY24qOZLLHJiKZndjZOc+ai38bw7mETIdYrSOGY= X-Received: by 2002:a05:6402:2342:b0:5d1:2652:42ba with SMTP id 4fb4d7f45d1cf-5db7d313997mr18407675a12.16.1737502805475; Tue, 21 Jan 2025 15:40:05 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 21 Jan 2025 17:40:05 -0600 From: Stefan Kangas In-Reply-To: <87o6zzn5pa.fsf@protonmail.com> References: <861pww5kuj.fsf@gnu.org> <87bjw0xl6s.fsf@protonmail.com> <86ldv442mh.fsf@gnu.org> <877c6okmlb.fsf@protonmail.com> <87o6zzn5pa.fsf@protonmail.com> MIME-Version: 1.0 Date: Tue, 21 Jan 2025 17:40:05 -0600 X-Gm-Features: AbW1kvaj7cegW1d1ZLZvAKJ8hAyu6Ab_MI_pwLIk2PeLsTaS1gDkHsO_j2eJj6I Message-ID: Subject: Re: bug#75712: HAVE_RSVG: svg_css_length_to_pixels doesn't handle RSVG_UNIT_CH To: Pip Cet Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75712 Cc: 75712@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Pip Cet writes: > I kind of think tiff_handler should use image_error, not add_to_log, but > the two have been equivalent forever. I think it'd be worth changing that one call, if only to be fully locally consistent in image.c. > listn is a strange animal and we should probably use Flist instead, > but that should wait until purespace is gone, Yes, it seems like yet another post-"scratch/no-purespace merge" cleanup. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 22 17:59:29 2025 Received: (at 75712) by debbugs.gnu.org; 22 Jan 2025 22:59:29 +0000 Received: from localhost ([127.0.0.1]:37368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tajh3-00088d-1j for submit@debbugs.gnu.org; Wed, 22 Jan 2025 17:59:29 -0500 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]:54570) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tajh0-000886-3n for 75712@debbugs.gnu.org; Wed, 22 Jan 2025 17:59:27 -0500 Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-5da12190e75so639582a12.1 for <75712@debbugs.gnu.org>; Wed, 22 Jan 2025 14:59:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737586760; x=1738191560; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=/ZRfjEVNB+9+ZqWQaCSD+FwLm/AGMxI+FfScR5rZUTQ=; b=gWAy9En2X94KTS09eeTMHMT33FgQxQb5HMX93jNyONOSHvfzQyMscQ7XBb0IHKyPhm C0pFsp1rtcfZ+1wJy+dZkjIVwSQx9OSR8sJje7tAP9drRnxzx9sItPSsWXOSvVcTycr2 KXrlZcYugEOKoOFfR13JgBr4eCQO5i2Ukzxy0EqieR9CCQRsgyehdoB+mqOIlETYNRvp P50TV2ZlUITVxoqMU7Xv9WnuhbxuS1YBJPID3AljOHEcOkdz5GEOjpE7KizkWP+jtPrO 9n2hUiFs1jimiVhZ9cjxlUCsn+GOp6CuIM/FNBl/4BksnYk+w9NxSQCIWB2Ul8DP/18c PZPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737586760; x=1738191560; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/ZRfjEVNB+9+ZqWQaCSD+FwLm/AGMxI+FfScR5rZUTQ=; b=BX2019rvU4sRiaMJEq2vFNlis6vHA5pQvWg4yfK+J1kX8U8lciAjP5U1dZDzpA1S4t 0nrygRPJZ4Ku/agVXRy4YYGIAccWj+8J+LhiGVWMK2cGBYyFh0kJwILvpfLs9n/C4DDh IwkHfFxMB2n1UkGuTm4YEUZRqbQ1PoptwjKkm1rLAQlaqL2b0p3gEtwngDC5T9gCzv6Y CMe18RDtvd4WQU76Z5QXeu6I+b7RNapqOpkV0bGbYNDqvwL25Bs8ogNAAZv2k7yCIVxm ykXUpJl7paRodNzDz5Osp5CTz8re9iXvSmZh2BhjBNTnvJYTBn8jGtBtzv21fnlrjYmh Z48w== X-Forwarded-Encrypted: i=1; AJvYcCWQZiZDpnfJozrFi/36ZvHyp2FBgB+Re1qh/fiYL2imAhys76mtnF01EOKHIKdrKS5rbXKNPQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxXRxTm51dSuzoQRB06OxRkLIb+Lv4bZNO0bxPLUEilRXr8nHdF rgH7ELdWGRdKbn4KBBlac7gGn/a7dqm2zLIpyFnDj8E0GbUFT3nV+OW7Tx0LmfRh2BOzLNjfwDG lm+gUAjAbImtFC5ckoQPew+ygNehFwCellbs= X-Gm-Gg: ASbGncvLOF9GqnuQm2UrOwEF6RREqIkcLM28INV915cG2THBD3iEpDbG7AN1GPCMbNC 0oDlsgpHUZrAQ4IXZqX9+BigqLn4HcMA6w70Ps46VvejfC5jMv/xF X-Google-Smtp-Source: AGHT+IHAz6gOv5R49XBoyZCNb2O6Pc0XlJSvgfocCxpe+drfOb5ogDnHGkmn79kIF+dWAa/H8IjurqWi+ykh3Z9ZOE8= X-Received: by 2002:a05:6402:254a:b0:5da:9d4:ad6 with SMTP id 4fb4d7f45d1cf-5db7db0782emr24507643a12.28.1737586759676; Wed, 22 Jan 2025 14:59:19 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 22 Jan 2025 14:59:19 -0800 From: Stefan Kangas In-Reply-To: References: <861pww5kuj.fsf@gnu.org> <87bjw0xl6s.fsf@protonmail.com> <86ldv442mh.fsf@gnu.org> <877c6okmlb.fsf@protonmail.com> <87o6zzn5pa.fsf@protonmail.com> MIME-Version: 1.0 Date: Wed, 22 Jan 2025 14:59:19 -0800 X-Gm-Features: AWEUYZnCTTezEau1RxBOelujj8HmW3ydrXXxZRB0t5mTUckgQwASVULmule52jo Message-ID: Subject: Re: bug#75712: HAVE_RSVG: svg_css_length_to_pixels doesn't handle RSVG_UNIT_CH To: Pip Cet Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75712 Cc: 75712@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > Pip Cet writes: > >> I kind of think tiff_handler should use image_error, not add_to_log, but >> the two have been equivalent forever. > > I think it'd be worth changing that one call, if only to be fully > locally consistent in image.c. Now done. From unknown Wed Jun 18 23:11:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 20 Feb 2025 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator