GNU bug report logs - #75707
29.4; Bad face definitions in shell.el

Previous Next

Full log

Message #13 received at 75707 <at> debbugs.gnu.org (full text, mbox):

From: Anders Lindgren <andlind <at> gmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 75707 <at> debbugs.gnu.org
Subject: Re: bug#75707: 29.4; Bad face definitions in shell.el
Date: Thu, 23 Jan 2025 21:07:53 +0100

[Message part 1 (text/plain, inline)]

Hi!

Yes, that looks perfect. You can close this issue.

/ Anders

On Tue, Jan 21, 2025 at 1:00 AM Stefan Kangas <stefankangas <at> gmail.com>
wrote:

> Anders Lindgren <andlind <at> gmail.com> writes:
>
> > In `shell.el', there are a number of face definitions on the form:
> >
> > (defface shell-highlight-undef-alias-face
> >   '((t :inherit 'font-lock-variable-name-face))
> >   "Face used for shell command aliases."
> >   :group 'shell
> >   :version "29.1")
> >
> > Note that `font-lock-variable-name-face' is quoted, which it shouldn't
> be.
>
> I think these have been fixed on master, in commit b9ebacf40345.  We now
> also warn for such cases, since commit 8d0c8076c3f2.  This will wait
> until Emacs 31, however.
>
> Could you please take a look and see if that resolves this problem?
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.