From unknown Sat Aug 16 10:49:16 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#75707 <75707@debbugs.gnu.org> To: bug#75707 <75707@debbugs.gnu.org> Subject: Status: 29.4; Bad face definitions in shell.el Reply-To: bug#75707 <75707@debbugs.gnu.org> Date: Sat, 16 Aug 2025 17:49:16 +0000 retitle 75707 29.4; Bad face definitions in shell.el reassign 75707 emacs submitter 75707 Anders Lindgren severity 75707 normal tag 75707 moreinfo thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 20 18:30:35 2025 Received: (at submit) by debbugs.gnu.org; 20 Jan 2025 23:30:35 +0000 Received: from localhost ([127.0.0.1]:52073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ta1Dz-0000vu-EV for submit@debbugs.gnu.org; Mon, 20 Jan 2025 18:30:34 -0500 Received: from lists.gnu.org ([2001:470:142::17]:42988) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ta1Do-0000tC-69 for submit@debbugs.gnu.org; Mon, 20 Jan 2025 18:30:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ta0Gp-0006Fh-OZ for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2025 17:29:26 -0500 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ta0Gn-0002cT-GT for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2025 17:29:23 -0500 Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-5d0ac27b412so6712838a12.1 for ; Mon, 20 Jan 2025 14:29:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737412159; x=1738016959; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=yfIkqBbOomifAzCXy+1dzeT9kYSICE3m0I0g9dqIgH0=; b=SwMlgfO9lQW7+ONm9NGKhSVPLvRWFBxxttU3B4YgyKG6PyLyPTDjn3p2/0+WQSqXXA afP2Bpr6GxGt0S3rPx55HSBssWQxsJMV8JWeKTGyLc0gNBnMY3ra2kQaaIkgeJ/7Cax8 n+7JMIlHozV/cZw/YgUDSZuE0qWuGfJvyNu+b1xix0KVg/Qvjiu9MH/2qyuuX7QA6SPN kqaXqi4gI25HfF5cHaaxw3cZ+5b6cXnL4lxoIkwZqVtQ1GSlfF4Cq3NkGjC17YE7NwrS fZWcyZ2rvv9jhT0JUnV69utam2YOC9j5GlUyJxAf4v1Xhp6H5153To9eBRbPwyJvSv1h 25bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737412159; x=1738016959; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=yfIkqBbOomifAzCXy+1dzeT9kYSICE3m0I0g9dqIgH0=; b=oZESXsu9Jh1lAr5rIfOgz7MH2/Nhcl+YxoCwne9LL/AXbtt7MOJXK2NHOanb1Y9jrK NsGPU8InsP/L3HS8sSJ2Mbo+P/6cibeCtUtHCbGi87qPeD1DNfqR8BocXOOnf2CRobqJ zkJRy5MZlpInDWwrQZB9O6sxQy9uAvV7InvLllniYQTADQJMIzuK6QnMDZyXFy/AG82U iYURn53RK2c8TdpKvukOeKG8tVNYVc89BN+IGv4rn2uI6OXkBzOPLBk1QlaRG8QAcqwt szhx30H4i2yWmpsAOj8f2n2miAzjMpz95X+Kxn0jPPZ2rV1mWOpWWl2JVaaqile3ApXj ru1Q== X-Gm-Message-State: AOJu0YxfipWFIQd2lDb1cZIh1E3t4Fx9XFI+1h5SIPNjRZkzYoGOx1AC sMLUwVIUrAQtevpc/QbzqWyaf9cIDxr9wY7ESWbqUFElxc3T6cSo65wVvIuIHks3sNTM7W6Wosu KxjXE3CDs4OcZFA2SJgFAbnSM30mPEUI3 X-Gm-Gg: ASbGnctCyzv1G7ChBLlTZny6runN/NeABK0KvZvuNMRGRe6BSD5GsuPXnCkiwrPYcvw r8HkYI7KNTx5XHrywGsYsDpe3UiUvfS33UNYXmC0zC0cK4MckZEYw9heaJifQQo+sdnVmC3wkiI VliBWOBBpwNQ== X-Google-Smtp-Source: AGHT+IGDL68iiRdIXDiiSk4AsDLWNkfeOitXtPUElhquV1MNTQZsk7SChaGCM65rluTJhMBGwUWEebT1xcQ1VQzkwFg= X-Received: by 2002:a05:6402:5106:b0:5d4:4143:c06c with SMTP id 4fb4d7f45d1cf-5db7db086c2mr13974114a12.23.1737412158633; Mon, 20 Jan 2025 14:29:18 -0800 (PST) MIME-Version: 1.0 From: Anders Lindgren Date: Mon, 20 Jan 2025 23:29:07 +0100 X-Gm-Features: AbW1kvZUitoth2JejQGOXNy_BUrWCfOUanWoqQsqUFkY43X9Duu-SaZwGN4V93k Message-ID: Subject: 29.4; Bad face definitions in shell.el To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary="0000000000008b40d4062c2aca69" Received-SPF: pass client-ip=2a00:1450:4864:20::52b; envelope-from=andlind@gmail.com; helo=mail-ed1-x52b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --0000000000008b40d4062c2aca69 Content-Type: text/plain; charset="UTF-8" In `shell.el', there are a number of face definitions on the form: (defface shell-highlight-undef-alias-face '((t :inherit 'font-lock-variable-name-face)) "Face used for shell command aliases." :group 'shell :version "29.1") Note that `font-lock-variable-name-face' is quoted, which it shouldn't be. On one hand, Emacs seems to be able to display the face properly. On the other hand, when trying to retrieve the face properties using `face-attribute', it fails. In the example below, this is demonstrated. If you evaluate each line in *scratch* you will see this. (When inserting TEST into be buffer, the 'font-lock-face' property is used since the `face' property would immediately be overwritten by font-lock.) ------------------- (defface correct-inherit '((t :inherit font-lock-variable-name-face)) "Correct inherited definition.") (insert (propertize "TEST" 'font-lock-face 'correct-inherit)) (message "%s" (face-attribute 'correct-inherit :foreground nil t)) ;; ----- (defface bad-inherit '((t :inherit 'font-lock-variable-name-face)) "Correct inherited definition.") (insert (propertize "TEST" 'font-lock-face 'bad-inherit)) (message "%s" (face-attribute 'bad-inherit :foreground nil t)) ------------------- I guess the main priority is to fix `shell.el', but it would be nice if `face-attributes' would be able to retrieve the attribute values. Sincerely, Anders Lindgren Ps. I'm a long time Emacs user and developer with good knowledge regarding faces. In GNU Emacs 29.4 (build 1, aarch64-apple-darwin21.6.0, NS appkit-2113.60 Version 12.6.6 (Build 21G646)) of 2024-08-02 built on armbob.lan Windowing system distributor 'Apple', version 10.3.2575 System Description: macOS 15.1.1 Configured using: 'configure --with-ns '--enable-locallisppath=/Library/Application Support/Emacs/${version}/site-lisp:/Library/Application Support/Emacs/site-lisp' --with-modules 'CFLAGS=-DFD_SETSIZE=10000 -DDARWIN_UNLIMITED_SELECT' --with-x-toolkit=no' Configured features: ACL GLIB GMP GNUTLS JPEG JSON LIBXML2 MODULES NOTIFY KQUEUE NS PDUMPER PNG RSVG SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER ZLIB Important settings: value of $LANG: sv_SE.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads kqueue cocoa ns multi-tty make-network-process emacs) Memory information: ((conses 16 37908 7520) (symbols 48 5047 0) (strings 32 13106 1867) (string-bytes 1 376429) (vectors 16 10396) (vector-slots 8 163820 11918) (floats 8 22 25) (intervals 56 304 0) (buffers 984 11)) --0000000000008b40d4062c2aca69 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
In `shell.el', there are a number of face definit= ions on the form:

(defface shell-highlight-undef-a= lias-face
=C2=A0 '((t :inherit 'font-lock-variable-name-face))=C2=A0 "Face used for shell command aliases."
=C2=A0 :group = 'shell
=C2=A0 :version "29.1")

Note that `font-lock-variable-name-face' is quoted, which it shouldn&= #39;t be.

On one hand, Emacs seems to be able to d= isplay the face properly. On the other hand, when trying to retrieve the fa= ce properties using `face-attribute', it fails.

In the example below, this is demonstrated. If you evaluate each line in = *scratch* you will see this. (When inserting TEST into be buffer, the '= font-lock-face' property is used since the `face' property would im= mediately be overwritten by font-lock.)

-----= --------------
(defface correct-inherit
=C2=A0 '((t = :inherit font-lock-variable-name-face))
=C2=A0 "Correct inherited d= efinition.")

(insert (propertize "TEST" 'font-loc= k-face 'correct-inherit))

(message "%s" (face-attribut= e 'correct-inherit :foreground nil t))

;; -----

(defface = bad-inherit
=C2=A0 '((t :inherit 'font-lock-variable-name-face))=
=C2=A0 "Correct inherited definition.")

(insert (prope= rtize "TEST" 'font-lock-face 'bad-inherit))

(messa= ge "%s" (face-attribute 'bad-inherit :foreground nil t))
<= /div>
-------------------

I guess the main pri= ority is to fix `shell.el', but it would be nice if `face-attributes= 9; would be able to retrieve the attribute values.

Sincerely,
=C2=A0 =C2=A0 Anders Lindgren

Ps. I'm a long time Emacs user and developer with good knowledge rega= rding faces.



In GNU Emacs 29.4 (build 1, aarch64-apple= -darwin21.6.0, NS
=C2=A0appkit-2113.60 Version 12.6.6 (Build 21G646)) of= 2024-08-02 built on
=C2=A0armbob.lan
Windowing system distributor &#= 39;Apple', version 10.3.2575
System Description: =C2=A0macOS 15.1.1<= br>
Configured using:
=C2=A0'configure --with-ns '--enable-lo= callisppath=3D/Library/Application
=C2=A0Support/Emacs/${version}/site-l= isp:/Library/Application
=C2=A0Support/Emacs/site-lisp' --with-modul= es 'CFLAGS=3D-DFD_SETSIZE=3D10000
=C2=A0-DDARWIN_UNLIMITED_SELECT= 9; --with-x-toolkit=3Dno'

Configured features:
ACL GLIB GMP G= NUTLS JPEG JSON LIBXML2 MODULES NOTIFY KQUEUE NS PDUMPER
PNG RSVG SQLITE= 3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER ZLIB

Important settin= gs:
=C2=A0 value of $LANG: sv_SE.UTF-8
=C2=A0 locale-coding-system: u= tf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:=
=C2=A0 tooltip-mode: t
=C2=A0 global-eldoc-mode: t
=C2=A0 eldoc-m= ode: t
=C2=A0 show-paren-mode: t
=C2=A0 electric-indent-mode: t
= =C2=A0 mouse-wheel-mode: t
=C2=A0 tool-bar-mode: t
=C2=A0 menu-bar-mo= de: t
=C2=A0 file-name-shadow-mode: t
=C2=A0 global-font-lock-mode: t=
=C2=A0 font-lock-mode: t
=C2=A0 blink-cursor-mode: t
=C2=A0 line-= number-mode: t
=C2=A0 indent-tabs-mode: t
=C2=A0 transient-mark-mode:= t
=C2=A0 auto-composition-mode: t
=C2=A0 auto-encryption-mode: t
= =C2=A0 auto-compression-mode: t

Load-path shadows:
None found.
Features:
(shadow sort mail-extr emacsbug message mailcap yank-medi= a puny dired
dired-loaddefs rfc822 mml mml-sec password-cache epa derive= d epg rfc6068
epg-config gnus-util text-property-search time-date subr-x= mm-decode
mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils m= ailheader
cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util=
mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric=
uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/= ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd
fonts= et image regexp-opt fringe tabulated-list replace newcomment
text-mode l= isp-mode prog-mode register page tab-bar menu-bar rfn-eshadow
isearch ea= symenu timer select scroll-bar mouse jit-lock font-lock syntax
font-core= term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesi= an philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai= tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slo= vak czech european ethiopic indian cyrillic chinese
composite emoji-zwj = charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarra= y oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face ma= croexp files window text-properties
overlay sha1 md5 base64 format env c= ode-pages mule custom widget keymap
hashtable-print-readable backquote t= hreads kqueue cocoa ns multi-tty
make-network-process emacs)

Memo= ry information:
((conses 16 37908 7520)
=C2=A0(symbols 48 5047 0)
= =C2=A0(strings 32 13106 1867)
=C2=A0(string-bytes 1 376429)
=C2=A0(ve= ctors 16 10396)
=C2=A0(vector-slots 8 163820 11918)
=C2=A0(floats 8 2= 2 25)
=C2=A0(intervals 56 304 0)
=C2=A0(buffers 984 11))
--0000000000008b40d4062c2aca69-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 20 19:01:00 2025 Received: (at 75707) by debbugs.gnu.org; 21 Jan 2025 00:01:00 +0000 Received: from localhost ([127.0.0.1]:52280 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ta1hT-0002Xc-Jx for submit@debbugs.gnu.org; Mon, 20 Jan 2025 19:00:59 -0500 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]:42247) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1ta1hR-0002XI-UX for 75707@debbugs.gnu.org; Mon, 20 Jan 2025 19:00:58 -0500 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-5d3dce16a3dso6392530a12.1 for <75707@debbugs.gnu.org>; Mon, 20 Jan 2025 16:00:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737417651; x=1738022451; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=1A5N4lwCKWRX8vfIGijsMmOmrx/y81Omvr5xFy82N8k=; b=Auk/KEfwpclCEMZ3E9kAnXTOLq76BXjkFs+ZGUqo9vpwH/DZFRy5sn4DYO4QRYdV7L 5sGaPRW2YG4uxTZ7o/usWGr6qREu5fh4OU7lHiQnvCoNmMXLh6lq/1MNO4TMSOp+Sp25 Y8ZWXUOh6q9KrwLX3bu/MIYrc940KiVhoWa5DhSuAwi/gqI3oEvjD+9YO51vXkrrzCPR BlqAY3haeiAHKt31sh8V+M5GE8E3G4u6OQStvQ/DRbK8brN2amrcq+cQxGw9kyq8F57e 4MWoXB3Hv4nZBvmo8xI0UWb4JE4d2PkEV/TEoQFwVTBiP91/UXKvnGWkJXsByW80btGA s8Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737417651; x=1738022451; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1A5N4lwCKWRX8vfIGijsMmOmrx/y81Omvr5xFy82N8k=; b=Nbci9NMl+Bc955aIsnidVLL9B1m7H94lNqEMlrqtoNx7U1I0A9bJITQNYTk51Dv6Wb eKXl0hMUVjjv9BRGHepIs6Cy/IAtAJGPOhrSc1BnRhwJNxxSYgQG0C6bOK+GQkcyQUc4 eZgXcJxnwQPSuRj6VTcKH/21pRh00krOubZf0wjF1/Fff09R3U5UkDtlZ2z/ECwCbSQa BT7lyxsCKfChfCh59XaozUdGsaOdWsIr3VMBrFByjOJH/SkLtwbMnEwpprh7U5BmAbvo iG2531Y8BN0pa1Qo8YPzwZrd1ql1WW3WUDxaCB7uKDvEqHK6ikp/GR/6iVfqUXdVwKS5 BsJQ== X-Forwarded-Encrypted: i=1; AJvYcCViuBP+jHVE6n3AN37nMOmBwxxcUkX9G5EolzUWOeA9hZZyoqhk3PlGd/t3VdP+TIpDOMr5Zg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyFRsmDtpgMkr3hUD8MVjxk3p5JB0fgnk1cmMkG4ukKvJWylT0q WtRPibWPl8jEKBFcxQ3RFjjZwxtA1dVK8UUdJXzHOFlKaKRmzj+OQOSaC6Kd1Cl+6axRuO4NtQ4 2+Ea4mYnnWMyZhyCuA5joACj7PkNftSWy X-Gm-Gg: ASbGncto2xCk3Ajhz+3tt0mQg3l03MB8ma5ic3rc5LhpTPqRFObxLWQTEDG24RAPAJ2 C+LCFcIIPC6Q6NBsN91uaeE76/GNphgd7nZqRZioupStiOnCapaHmJA== X-Google-Smtp-Source: AGHT+IFxlTsKcYampyoU9gVtHsxwfrFpRlh730iUCAbAoaM4qfgXkSmfP9l7MlPUYPB0GbdEJ9wuWXMZ+4goYUWcLL4= X-Received: by 2002:a05:6402:2551:b0:5d3:d8e7:d6d2 with SMTP id 4fb4d7f45d1cf-5da0bac2e69mr20682549a12.1.1737417651181; Mon, 20 Jan 2025 16:00:51 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 20 Jan 2025 16:00:50 -0800 From: Stefan Kangas In-Reply-To: References: MIME-Version: 1.0 Date: Mon, 20 Jan 2025 16:00:50 -0800 X-Gm-Features: AbW1kvZTxJtaHlYTHLcUcZyOC1AXBvzh-_XGtXYKb_zOz_5tpgAx5YdnbKZ3N58 Message-ID: Subject: Re: bug#75707: 29.4; Bad face definitions in shell.el To: Anders Lindgren , 75707@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75707 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Anders Lindgren writes: > In `shell.el', there are a number of face definitions on the form: > > (defface shell-highlight-undef-alias-face > '((t :inherit 'font-lock-variable-name-face)) > "Face used for shell command aliases." > :group 'shell > :version "29.1") > > Note that `font-lock-variable-name-face' is quoted, which it shouldn't be. I think these have been fixed on master, in commit b9ebacf40345. We now also warn for such cases, since commit 8d0c8076c3f2. This will wait until Emacs 31, however. Could you please take a look and see if that resolves this problem? From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 20 21:30:20 2025 Received: (at control) by debbugs.gnu.org; 21 Jan 2025 02:30:21 +0000 Received: from localhost ([127.0.0.1]:52693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ta420-0005en-Hj for submit@debbugs.gnu.org; Mon, 20 Jan 2025 21:30:20 -0500 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]:60758) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1ta41x-00059K-VJ for control@debbugs.gnu.org; Mon, 20 Jan 2025 21:30:18 -0500 Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-5d90a5581fcso9014898a12.1 for ; Mon, 20 Jan 2025 18:30:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737426612; x=1738031412; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=RY04ffmfvkK+PTUoi/1YKFR6BEpABsfEep1H7KLXyhU=; b=gmH0VSfcAk6eYW/9l+gtIHh6poC65rvPo8HBlVrzeADLhbyYKiUSEOSB0ZyoKzcWuy vxlvlbSYNlyVld5C4MeadQMnoqahr2h02jOlUtgeqq0WqAP0IUJRSxHywobZhAQvhzCy I1y/IcnUGNRaAwVLHAlqKEXp5RYw3vdnNkT4mMeZNTy+8d/VB9AvqUL1tMvYonxMzyW5 K3tgydH2Tk+jxzpP6U9w807wMvxMoRG77oPIFso/GS8K6nAT08Z1zpGSs/AVnQJjLETE 0YiKYoWO7NdpLGiDGMlWNAyLuzxuDTILynmRCFscfSsN7kbp1LHNhkTG4hJ/JDCfP4E9 5DGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737426612; x=1738031412; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=RY04ffmfvkK+PTUoi/1YKFR6BEpABsfEep1H7KLXyhU=; b=wsr/c5482+elcYk1UR8jfEZSM+NG/Bd9pkmKhXGeusjmROAocRSbFk2YtcnxWgrK4N GGLaiXGDSs7kXm8egH92/Iurqs7BN5a+SRReDHB1Yw7X82loGEi5t0qzbEkinxBSHMA1 t6ljeBpobRAz77UNOcMkA6Rmmulrlin97bvgmP70+P2w9fr4gNUYuFLDUILUGpjKwjyE 0GLjppOKfss/I+sfnQbDXpLOFLMOhzZOKI/2YgcTQGxUPgfT0kMxRUweo4iVwDA1ZdKM S7megTDajNHd59WfyLG87ay3IdCYkEgml8bR2t5BUEHXkHlYzjKnUKwZ5n6qlGnafo6m hgsg== X-Gm-Message-State: AOJu0YzA/IeoRCfLN1+XtKn/s9+ZypQXGrjMc5Tz9HFhQEHPRqwpXkSD K67JT/Zbc85XKKbnC340w7e4jzQotBblEruoJaMLqfLihN2vCuhsZwbtt68LKks+jXtLENTqYay zNE/MXYpb7kJ8pq8VVD1WJ/RZQanTILYF X-Gm-Gg: ASbGncssAm3nPCPJRjMr00hYA2uIqlKltpjdwUFTUFBSYy3kkgR9SHacmGDrq0W3mJN sXJp4vyhTkGIwgUfF+MMWrxhISTgsEyjC9V14Ktys1lNPt8BpwwqrWg== X-Google-Smtp-Source: AGHT+IEK+c/vvT8h46fWasTbanT0cgzfcW5OR7M1g6gQHhcTRTebdCDuL1BIeVgvwXoS47kmj3j0L9x1qAPerGWOhI8= X-Received: by 2002:a05:6402:40c9:b0:5da:d76:7b2e with SMTP id 4fb4d7f45d1cf-5db7d0eed69mr15217632a12.0.1737426611868; Mon, 20 Jan 2025 18:30:11 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 20 Jan 2025 18:30:11 -0800 From: Stefan Kangas MIME-Version: 1.0 Date: Mon, 20 Jan 2025 18:30:11 -0800 X-Gm-Features: AbW1kvYQ21fNd8MERskvwU0xSEyS7QrvJsIKriAhEosPS3y3pmbSeICGy1s62dY Message-ID: Subject: control message for bug #75707 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 75707 + moreinfo quit From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 23 15:08:14 2025 Received: (at 75707) by debbugs.gnu.org; 23 Jan 2025 20:08:15 +0000 Received: from localhost ([127.0.0.1]:42505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tb3Us-0001uq-Fz for submit@debbugs.gnu.org; Thu, 23 Jan 2025 15:08:14 -0500 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]:44153) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tb3Up-0001uO-Hz for 75707@debbugs.gnu.org; Thu, 23 Jan 2025 15:08:12 -0500 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-5d3e6274015so2518030a12.0 for <75707@debbugs.gnu.org>; Thu, 23 Jan 2025 12:08:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737662885; x=1738267685; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=itGj/IZpMzK3zsOd5yCM3xrHUmWdspIFmdPdrmuII4o=; b=V0aflFFAK6zkZQsFpOI2PFiII+fDKndy8Xao1PsIrvw7gKy/rXqCwmkCOW4NSuOfu4 OKSbF1iChapfyVYv+ehzKQv6UftftrGJtZ8b3K4Zq248BZrZ6aqTy5Onxv4C6POjCRVk aYddfucnbu0PPWYIb38kBQEWwypQ8uWNjgsSnzjk+8SG/hxYFcKjCuQP4bFiZJUqjYLy 6gy+svpses8SwPISEeqcfvIgUdx4xQvL2GPcFAwVXb6S+/7U6lIk3EEzQUTe8HhQl0YC c8UqoP3WNooBpSSRka8jtDdPmosqfuZhtrMxHDankHgq8pDhyhzqkiO/ePJ//+UzZmzo s3fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737662885; x=1738267685; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=itGj/IZpMzK3zsOd5yCM3xrHUmWdspIFmdPdrmuII4o=; b=N1xvbI+6F4ZAjK9qdCwU7vQH9ACCwPpVvDzQunfhU3YWIwZemlbpO7tA8TSLDmnyF0 KRXVYJqm4zfMum6UfUEOWE47tkioqo6Ihuzs+7LdntjOPKrvCdr0xrUBCTTTfWBHcjfE WaU4rFCXKhiKJivdV+2Y5CvYciRpT99zfgx0dk/uQJM/oJjaJQWrTYYbn/B0LWHm1FVP 5/P/fNgdk7G+Fl9+eZZOyBpAobXcHzZ/2tvWXA2wFpaqBt/w6ttNYm5B+RtBNzedk/17 uvQ2x8FPA3/5iqhZrMXWazoBdZupuAv5RCTM9WBg8+Xs8u0e83M/cHqQy3oPn48LPW96 ooHA== X-Gm-Message-State: AOJu0YzY73OpwObjfUPTlskOCO1SluNGsmFG1R2+FHsGzC91ba7h+9uc L5Vb+go/ytnk9zuxqbesEr0S76vptqknSU+4m6w+LH+v7vqhpmErkk126msWfxqjejHTaR7G70N HdmpiP87WGnDZUCGl53faWv2UTgqB4w== X-Gm-Gg: ASbGncv4IN0AvM7aeWs3oQVSfK9RsEOV0WIXDdaNe9u7eLxywZNGRN1Opx1ZHzXEgyd D6vxbRwcfie5ZMNkN/O5mhvLe11jq3I45P6QvAO2/x/Hyv1DVc7Z3nC41dy+BA2s1HWzOwjGkbq hFcyWsQnvd2rmwhoP7s9gH X-Google-Smtp-Source: AGHT+IHuMIQ/sxo6D64AOwGlza4Lw84+yNEhANWGEhuGdrB4lZd+JogP9vRnNFBPUed3gwRIE6mXPhEbW9xj5vbjCU4= X-Received: by 2002:a05:6402:2342:b0:5db:67a7:e742 with SMTP id 4fb4d7f45d1cf-5db7d2f947dmr23215866a12.8.1737662884575; Thu, 23 Jan 2025 12:08:04 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Anders Lindgren Date: Thu, 23 Jan 2025 21:07:53 +0100 X-Gm-Features: AWEUYZlvfaLV9zOGnCxiz_6zpTio1xp1oj65fcO87Rxt1IeSDosmXlyZlY7GnzU Message-ID: Subject: Re: bug#75707: 29.4; Bad face definitions in shell.el To: Stefan Kangas Content-Type: multipart/alternative; boundary="000000000000f9862b062c652a76" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75707 Cc: 75707@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000f9862b062c652a76 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi! Yes, that looks perfect. You can close this issue. / Anders On Tue, Jan 21, 2025 at 1:00=E2=80=AFAM Stefan Kangas wrote: > Anders Lindgren writes: > > > In `shell.el', there are a number of face definitions on the form: > > > > (defface shell-highlight-undef-alias-face > > '((t :inherit 'font-lock-variable-name-face)) > > "Face used for shell command aliases." > > :group 'shell > > :version "29.1") > > > > Note that `font-lock-variable-name-face' is quoted, which it shouldn't > be. > > I think these have been fixed on master, in commit b9ebacf40345. We now > also warn for such cases, since commit 8d0c8076c3f2. This will wait > until Emacs 31, however. > > Could you please take a look and see if that resolves this problem? > --000000000000f9862b062c652a76 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi!

Yes, that looks perfect. You can cl= ose this issue.

/ Anders

On Tue, Jan 21, 2025 at 1:00=E2=80=AFAM Stefan Kangas <stefankangas@gmail.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">Anders Lindgren <andlind@gmail.com> = writes:

> In `shell.el', there are a number of face definitions on the form:=
>
> (defface shell-highlight-undef-alias-face
>=C2=A0 =C2=A0'((t :inherit 'font-lock-variable-name-face))
>=C2=A0 =C2=A0"Face used for shell command aliases."
>=C2=A0 =C2=A0:group 'shell
>=C2=A0 =C2=A0:version "29.1")
>
> Note that `font-lock-variable-name-face' is quoted, which it shoul= dn't be.

I think these have been fixed on master, in commit b9ebacf40345.=C2=A0 We n= ow
also warn for such cases, since commit 8d0c8076c3f2.=C2=A0 This will wait until Emacs 31, however.

Could you please take a look and see if that resolves this problem?
--000000000000f9862b062c652a76-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 23 16:26:03 2025 Received: (at 75707-done) by debbugs.gnu.org; 23 Jan 2025 21:26:03 +0000 Received: from localhost ([127.0.0.1]:42632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tb4iA-0005fP-P9 for submit@debbugs.gnu.org; Thu, 23 Jan 2025 16:26:02 -0500 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]:60642) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tb4i7-0005ep-SV for 75707-done@debbugs.gnu.org; Thu, 23 Jan 2025 16:26:01 -0500 Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-5d3ecae02beso2017524a12.0 for <75707-done@debbugs.gnu.org>; Thu, 23 Jan 2025 13:25:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737667554; x=1738272354; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=Vrlr1ZuxOMjwa2i/cCrYYp4kMDmd5epL/I9RbjhKb2Y=; b=DDHt+7vvCx99RL2d8GVAuUu0SK5j+rK10jCpDZOaN/ZEJkWh2CSpzqoKqi8/UXE5KM jVUcLXN52i7BmtN/xs54d3rg51EERkiZLs5MgqviIqnwkPWaMI+gd5ZolT2gRm+SBRCv X2kscWFqSmj9GMU9mtvUKO42eCRJ1x5HAOomU9R9DHWP3SlVsM6L/MgQ2U+iD/nZhuLa bD79oxpg0e9MfHp439ZCNr2ENG4P7oMHEqhSKtMs0wANKGbEJ/ZtPiNoEWEP0lN37ofy tz5StfdTQc9EkP3R+lFzJj9CrPh2VsOBge7h91TgGpbls8v066wZ+iJr3VYOQ65yHleP Szsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737667554; x=1738272354; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Vrlr1ZuxOMjwa2i/cCrYYp4kMDmd5epL/I9RbjhKb2Y=; b=tGlk74foJf414JLsDEVMWxgwmFB3Scgt2Vgh0a8fV1g9d/fjzp0TiXut6lfR52GZga GfPZ79x+WNTBgWcDkpUHnep+VL959qy5Smoq2MpRZLRvsbCVmEY8Yl4V9DLTK1dZ2Fil EaW4LAjTExw4OPs9jR5WVzRLLcvSgHiKo9qeYDuETLMoc2LkWk0noZffQ/6If2phnm2N WCuvLs7qN/X6if5lia9PhJd/zpjikFp4fqDSmpR/viTM8UlFVNBRjB8l5kwMt6t+uTZ5 bYZP3CGPs9cjHxVgSQ4ZkboMqWhESxmJrBajr9QxIX+Liy4VKVYhyWtDADrfyMNBcKYj TORw== X-Gm-Message-State: AOJu0YxNY3n8TNxECrJTsnQU5VgKA+S/AVbpnFU0WmyHr6W8GsOFxlnY CjnlV3jS1xlMs7GZbnwgFrHV0keVOjl7ClqjgBgqg2KZrTAmyOVtvPU5HfiszmBszXRhhkBS+he CCXf0d84bZafcAzRhZ9QUkL1NXi4= X-Gm-Gg: ASbGncuHYYWwCyBtF1AhtNobFwHMI2J7z0fJU5dU3P+MOs+48DIsWZZ7lljiZ43R/TN 48pJMB6b2VgRX6k4basGst1QdiJemsebUAhi3nrjfAoLeJ2F+n3ye29xJkenlP/Ak X-Google-Smtp-Source: AGHT+IHFjd7wP+iBmsscKvX5+m21Uy1gFxSbkLqfUpgz9gpmtcX3RJ7iHPgY/uJBPFhDBCJVKdnT4zbVGr2JxsfZ6oE= X-Received: by 2002:a05:6402:3487:b0:5d4:1ac2:277f with SMTP id 4fb4d7f45d1cf-5db7d2f5efdmr21479167a12.9.1737667553376; Thu, 23 Jan 2025 13:25:53 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 23 Jan 2025 15:25:53 -0600 From: Stefan Kangas In-Reply-To: References: MIME-Version: 1.0 Date: Thu, 23 Jan 2025 15:25:53 -0600 X-Gm-Features: AWEUYZnN8mCR4P3kPC0453SK9TTl6DcjvneUU_2FontcgWcRKRfNAJAApwcRl9g Message-ID: Subject: Re: bug#75707: 29.4; Bad face definitions in shell.el To: Anders Lindgren Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75707-done Cc: 75707-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Anders Lindgren writes: > Yes, that looks perfect. You can close this issue. Thanks for checking! I'm therefore closing this bug report. From unknown Sat Aug 16 10:49:16 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 21 Feb 2025 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator