Subject: Re: bug#75707: 29.4; Bad face definitions in shell.el

From: Anders Lindgren <[email-masked]>
Date: Thu, 23 Jan 2025 21:07:53 +0100

Hi!

Yes, that looks perfect. You can close this issue.

/ Anders

On Tue, Jan 21, 2025 at 1:00 AM Stefan Kangas <[email-masked]>
wrote:

> Anders Lindgren <[email-masked]> writes:
>
> > In `shell.el', there are a number of face definitions on the form:
> >
> > (defface shell-highlight-undef-alias-face
> >   '((t :inherit 'font-lock-variable-name-face))
> >   "Face used for shell command aliases."
> >   :group 'shell
> >   :version "29.1")
> >
> > Note that `font-lock-variable-name-face' is quoted, which it shouldn't
> be.
>
> I think these have been fixed on master, in commit b9ebacf40345.  We now
> also warn for such cases, since commit 8d0c8076c3f2.  This will wait
> until Emacs 31, however.
>
> Could you please take a look and see if that resolves this problem?
>