GNU bug report logs - #75691
31.0.50; tab-line mode adds extra space during in-buffer completion

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 75691 in the body.
You can then email your comments to 75691 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 31.0.50; tab-line mode adds extra space during in-buffer completion
Date: Mon, 20 Jan 2025 14:18:14 +0100

[Message part 1 (text/plain, inline)]

Hi all,

it seems that some recent changes in tab-line mode produce additional
vertical space during in-buffer completion.  To reproduce, start with
"emacs -Q" and then eval:

(progn
  (package-initialize t)
  (package-activate 'corfu)
  (global-corfu-mode)
  (setq tab-always-indent 'complete))

Now enter '(def' and hit TAB which gives for me:

[Without-tab-line.png (image/png, inline)]

[Message part 3 (text/plain, inline)]

Now activate tab-line mode and eval:

(global-tab-line-mode 1)

and hit TAB again after '(def' which now looks like this:

[With-tab-line.png (image/png, inline)]

[Message part 5 (text/plain, inline)]

Note the extra line between the text and the candidates.  I haven't
bisect this, but this behavior is new.

Best, Arash

In GNU Emacs 31.0.50 (build 1, aarch64-apple-darwin24.2.0, NS
 appkit-2575.30 Version 15.2 (Build 24C101)) of 2025-01-20 built on
 MacMutant.local
Repository revision: 458135155675a29a2c064998afc0cb416cd38b52
Repository branch: master
Windowing system distributor 'Apple', version 10.3.2575
System Description:  macOS 15.2

Configured using:
 'configure --with-ns --without-pop --without-mailutils --with-threads
 --with-modules --with-native-compilation --without-compress-install
 'CFLAGS=-O2 -g0 -pipe '
 'CPPFLAGS=-I/opt/homebrew/Cellar/gcc/14.2.0_1/include
 -I/opt/homebrew/Cellar/libgccjit/14.2.0_1/include
 -I/opt/homebrew/Cellar/gmp/6.3.0/include
 -I/opt/homebrew/Cellar/libxml2/2.13.5/include '
 'LDFLAGS=-L/opt/homebrew/Cellar/gcc/14.2.0_1/lib/gcc/current
 -L/opt/homebrew/Cellar/gmp/6.3.0/lib
 -L/opt/homebrew/Cellar/libxml2/2.13.5/lib ''

Configured features:
ACL GLIB GMP GNUTLS LCMS2 LIBXML2 MODULES NATIVE_COMP NOTIFY KQUEUE NS
PDUMPER PNG RSVG SQLITE3 THREADS TOOLKIT_SCROLL_BARS TREE_SITTER WEBP
XIM ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Message #8 received at 75691 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Daniel Mendler <mail <at> daniel-mendler.de>
Cc: Arash Esbati <arash <at> gnu.org>, 75691 <at> debbugs.gnu.org
Subject: Re: bug#75691: 31.0.50; tab-line mode adds extra space during
 in-buffer completion
Date: Mon, 20 Jan 2025 19:25:49 +0200

> it seems that some recent changes in tab-line mode produce additional
> vertical space during in-buffer completion.  To reproduce, start with
> "emacs -Q" and then eval:
>
> (progn
>   (package-initialize t)
>   (package-activate 'corfu)
>   (global-corfu-mode)
>   (setq tab-always-indent 'complete))
>
> Note the extra line between the text and the candidates.  I haven't
> bisect this, but this behavior is new.

Thanks for the report.

Daniel, in corfu.el there is no need anymore to use
`(window-tab-line-height)` because recently `window-edges`
was fixed in lisp/window.el by the commit ec20ebf2413.

The package exwm was updated in
https://github.com/emacs-exwm/exwm/commit/9cdfe95066a63666e211d54f898eed980b043f3a
https://github.com/emacs-exwm/exwm/commit/10bd61dbcf69110b2b029ac677c38bd076376d21
to use `window-tab-line-height` only conditionally on

  (when (< emacs-major-version 31))

For Corfu this would mean something like

  (yb (+ (cadr edge) (if (< emacs-major-version 31) (window-tab-line-height) 0) (or (cdr pos) 0) lh))

Message #11 received at 75691 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: Juri Linkov <juri <at> linkov.net>
Cc: Arash Esbati <arash <at> gnu.org>, 75691 <at> debbugs.gnu.org
Subject: Re: bug#75691: 31.0.50; tab-line mode adds extra space during
 in-buffer completion
Date: Mon, 20 Jan 2025 18:31:56 +0100

Juri Linkov <juri <at> linkov.net> writes:

>> it seems that some recent changes in tab-line mode produce additional
>> vertical space during in-buffer completion.  To reproduce, start with
>> "emacs -Q" and then eval:
>>
>> (progn
>>   (package-initialize t)
>>   (package-activate 'corfu)
>>   (global-corfu-mode)
>>   (setq tab-always-indent 'complete))
>>
>> Note the extra line between the text and the candidates.  I haven't
>> bisect this, but this behavior is new.
>
> Thanks for the report.
>
> Daniel, in corfu.el there is no need anymore to use
> `(window-tab-line-height)` because recently `window-edges`
> was fixed in lisp/window.el by the commit ec20ebf2413.
>
> The package exwm was updated in
> https://github.com/emacs-exwm/exwm/commit/9cdfe95066a63666e211d54f898eed980b043f3a
> https://github.com/emacs-exwm/exwm/commit/10bd61dbcf69110b2b029ac677c38bd076376d21
> to use `window-tab-line-height` only conditionally on
>
>   (when (< emacs-major-version 31))
>
> For Corfu this would mean something like

Thanks, fixed.

Daniel

Message #14 received at 75691 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Daniel Mendler <mail <at> daniel-mendler.de>
Cc: Arash Esbati <arash <at> gnu.org>, 75691 <at> debbugs.gnu.org
Subject: Re: bug#75691: 31.0.50; tab-line mode adds extra space during
 in-buffer completion
Date: Mon, 20 Jan 2025 20:32:05 +0200

>>> it seems that some recent changes in tab-line mode produce additional
>>> vertical space during in-buffer completion.  To reproduce, start with
>>> "emacs -Q" and then eval:
>>>
>>> (progn
>>>   (package-initialize t)
>>>   (package-activate 'corfu)
>>>   (global-corfu-mode)
>>>   (setq tab-always-indent 'complete))
>>>
>>> Note the extra line between the text and the candidates.  I haven't
>>> bisect this, but this behavior is new.
>>
>> Thanks for the report.
>>
>> Daniel, in corfu.el there is no need anymore to use
>> `(window-tab-line-height)` because recently `window-edges`
>> was fixed in lisp/window.el by the commit ec20ebf2413.
>>
>> The package exwm was updated in
>> https://github.com/emacs-exwm/exwm/commit/9cdfe95066a63666e211d54f898eed980b043f3a
>> https://github.com/emacs-exwm/exwm/commit/10bd61dbcf69110b2b029ac677c38bd076376d21
>> to use `window-tab-line-height` only conditionally on
>>
>>   (when (< emacs-major-version 31))
>>
>> For Corfu this would mean something like
>
> Thanks, fixed.

Not sure why (< emacs-major-version 30) since it was fixed only in Emacs 31.

Message #17 received at 75691 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: Juri Linkov <juri <at> linkov.net>
Cc: Arash Esbati <arash <at> gnu.org>, 75691 <at> debbugs.gnu.org
Subject: Re: bug#75691: 31.0.50; tab-line mode adds extra space during
 in-buffer completion
Date: Mon, 20 Jan 2025 19:57:09 +0100

Juri Linkov <juri <at> linkov.net> writes:

>>>> it seems that some recent changes in tab-line mode produce additional
>>>> vertical space during in-buffer completion.  To reproduce, start with
>>>> "emacs -Q" and then eval:
>>>>
>>>> (progn
>>>>   (package-initialize t)
>>>>   (package-activate 'corfu)
>>>>   (global-corfu-mode)
>>>>   (setq tab-always-indent 'complete))
>>>>
>>>> Note the extra line between the text and the candidates.  I haven't
>>>> bisect this, but this behavior is new.
>>>
>>> Thanks for the report.
>>>
>>> Daniel, in corfu.el there is no need anymore to use
>>> `(window-tab-line-height)` because recently `window-edges`
>>> was fixed in lisp/window.el by the commit ec20ebf2413.
>>>
>>> The package exwm was updated in
>>> https://github.com/emacs-exwm/exwm/commit/9cdfe95066a63666e211d54f898eed980b043f3a
>>> https://github.com/emacs-exwm/exwm/commit/10bd61dbcf69110b2b029ac677c38bd076376d21
>>> to use `window-tab-line-height` only conditionally on
>>>
>>>   (when (< emacs-major-version 31))
>>>
>>> For Corfu this would mean something like
>>
>> Thanks, fixed.
>
> Not sure why (< emacs-major-version 30) since it was fixed only in Emacs 31.

Indeed, thanks. Just a typo due to testing.

Daniel

Message #22 received at 75691-done <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: Daniel Mendler <mail <at> daniel-mendler.de>, 75691-done <at> debbugs.gnu.org
Subject: Re: bug#75691: 31.0.50; tab-line mode adds extra space during
 in-buffer completion
Date: Mon, 20 Jan 2025 21:04:40 +0100

Juri Linkov <juri <at> linkov.net> writes:

> Thanks, so now closing this report.

Many thanks to both of you.  I can confirm that the issue is resolved.

Best, Arash

Message #25 received at 75691-done <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Daniel Mendler <mail <at> daniel-mendler.de>
Cc: 75691-done <at> debbugs.gnu.org, Arash Esbati <arash <at> gnu.org>
Subject: Re: bug#75691: 31.0.50; tab-line mode adds extra space during
 in-buffer completion
Date: Mon, 20 Jan 2025 21:09:41 +0200

>>>>> it seems that some recent changes in tab-line mode produce additional
>>>>> vertical space during in-buffer completion.  To reproduce, start with
>>>>> "emacs -Q" and then eval:
>>>>>
>>>>> (progn
>>>>>   (package-initialize t)
>>>>>   (package-activate 'corfu)
>>>>>   (global-corfu-mode)
>>>>>   (setq tab-always-indent 'complete))
>>>>>
>>>>> Note the extra line between the text and the candidates.  I haven't
>>>>> bisect this, but this behavior is new.
>>>>
>>>> Thanks for the report.
>>>>
>>>> Daniel, in corfu.el there is no need anymore to use
>>>> `(window-tab-line-height)` because recently `window-edges`
>>>> was fixed in lisp/window.el by the commit ec20ebf2413.
>>>>
>>>> The package exwm was updated in
>>>> https://github.com/emacs-exwm/exwm/commit/9cdfe95066a63666e211d54f898eed980b043f3a
>>>> https://github.com/emacs-exwm/exwm/commit/10bd61dbcf69110b2b029ac677c38bd076376d21
>>>> to use `window-tab-line-height` only conditionally on
>>>>
>>>>   (when (< emacs-major-version 31))
>>>>
>>>> For Corfu this would mean something like
>>>
>>> Thanks, fixed.
>>
>> Not sure why (< emacs-major-version 30) since it was fixed only in Emacs 31.
>
> Indeed, thanks. Just a typo due to testing.

Thanks, so now closing this report.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.