GNU bug report logs - #75688
Replace wrapper scripts with search path value files in search-paths.d

Previous Next

Full log

View this message in rfc822 format

From: 宋文武 <iyzsong <at> envs.net>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 75688 <at> debbugs.gnu.org, 宋文武 <iyzsong <at> member.fsf.org>, Vivien Kraus <vivien <at> planete-kraus.eu>, Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: [bug#75688] GUIX_ify harmful environment variables and replace wrapper scripts with search path value files
Date: Mon, 27 Jan 2025 12:24:24 +0800

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:

>> * gnu/packages/patches/gdk-pixbuf-respect-GUIX_GDK_PIXBUF_MODULE_FILES.patch:
>
> nitpick: I'd name this patch
> gdk-pixbuf-honor-GUIX_GDK_PIXBUF_MODULE_FILES.patch (s/respect/honor/).
>
> [...]
>
> nitpick: "Load loaders" reads a bit loaded ;-).  I'd write "Load modules
> [...]" instead.
>
>> ++	gchar **guix_module_files = g_build_guix_search_path_dirs ("GUIX_GDK_PIXBUF_MODULE_FILES");
>> ++	for (int i = 0; guix_module_files[i] != NULL; i++)
>
> nitpick: I read a long time ago that ++i achieves the same and is more
> efficient, though I forgot the reasons.  Probably doesn't matter here,
> but could be neater (here and elsewhere).

Since it's not a big/hot loop, it doesn't matter here, and existed code use
"i++", so I'd leave it.

>
> Otherwise, for this commit alone,
>
> Reviewed-by: Maxim Cournoyer <maxim.cournoyer <at> gmail>
>
> (You'll want to give this series plenty of time for others to chime in).

I had update gdk-pixbuf patch for https://issues.guix.gnu.org/75795

The "search-paths.d" part of this series surely need more work, I'll
work on that later.

Thank you!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.