Subject: Re: [bug#75683] [PATCH] gnu: Add emacs-discourse-mode.

From: Yuval Langer <[email-masked]>
Date: Wed, 19 Feb 2025 13:39:56 +0200

On Tue, Feb 18, 2025 at 7:42 PM Nicolas Goaziou <[email-masked]> wrote:
>
> Hello,
>
> Yuval Langer <[email-masked]> writes:
>
> > * gnu/packages/emacs-xyz.scm (emacs-discourse-mode): New variable.
>
> Thank you.
>
> > +     (origin
> > +       (method git-fetch)
> > +       (uri (git-reference
> > +             (url "https://codeberg.org/glenneth/discourse-mode")
> > +             (commit "v0.2.4")))
>
> Please use (string-append "v" version) here.

Done. (pending submission)

> > +       (file-name (git-file-name name version))
> > +       (sha256
> > +        (base32 "0j2f0vclj6zrmk1hxyrrhkcpk74vqvq42g9wjqrjw827yjh2wm65"))))
> > +    (build-system emacs-build-system)
> > +    (propagated-inputs (list emacs-compat
> > +                             emacs-markdown-mode
> > +                             emacs-request))
> > +    (home-page "https://codeberg.org/glenneth/discourse-mode")
> > +    (synopsis "Emacs package for interacting with Discourse forums")
> > +    (description "Browse categories, view topics, read posts, and
> > +participate in discussions on Discourse, directly from Emacs.")
>
> Description is expected to contain "complete" sentences. Here,
> I suggest, unimaginatively:
>
>   This package lets you browse…

Done.

> There are some tests in the repo. Could you try running them during
> build? Or maybe they require internet access. I didn’t check.

There are no up-to-date tests I can run.  The author said he will
update them in a future version.

I will now submit my latest version of the package definition.

> Regards,
> --
> Nicolas Goaziou

Thank you,
Yuval Langer.