Subject: Re: [bug#75683] [PATCH] gnu: Add emacs-discourse-mode.

From: Ian Eure <[email-masked]>
Date: Mon, 17 Feb 2025 10:01:35 -0800

Hi Yuval,

Yuval Langer <[email-masked]> writes:

> * gnu/packages/emacs-xyz.scm (emacs-discourse-mode): New 
> variable.
> ---
>  gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm 
> b/gnu/packages/emacs-xyz.scm
> index 36cad3a7df..d4b868a89e 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -1564,6 +1564,31 @@ do manually if you wanted to keep the 
> buffers of a project neatly isolated in
>  separate, named tab groups.")
>        (license license:gpl3+))))
>  
> +(define-public emacs-discourse-mode
> +  (let ((commit "c5fde79990ab5d44786721f133b1c66764d6dc2b")
> +        (revision "1"))

Please remove this let form and use the release tag (instead of 
its commit hash), and send a v2 patch.

Thanks,

  -- Ian