GNU bug report logs - #75683
Add emacs-discourse-mode.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 75683 in the body.
You can then email your comments to 75683 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Yuval Langer <yuval.langer <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: Add emacs-discourse-mode.
Date: Mon, 20 Jan 2025 08:24:16 +0200

[Message part 1 (text/plain, inline)]

From the tagline on its Codeberg git repository page[1]:

> A modern Emacs package for seamless Discourse forum integration.

This Emacs mode is being written by Glenn Thompson.

Thank you!

[1]: https://codeberg.org/glenneth/discourse-mode

[0001-gnu-Add-emacs-discourse-mode.patch (text/x-patch, attachment)]

Message #8 received at 75683 <at> debbugs.gnu.org (full text, mbox):

From: Ian Eure <ian <at> retrospec.tv>
To: Yuval Langer <yuval.langer <at> gmail.com>
Cc: 75683 <at> debbugs.gnu.org
Subject: Re: [bug#75683] Add emacs-discourse-mode.
Date: Fri, 14 Feb 2025 06:49:10 -0800

Hi Yuval,

Yuval Langer <yuval.langer <at> gmail.com> writes:

>>From the tagline on its Codeberg git repository page[1]:
>
>> A modern Emacs package for seamless Discourse forum 
>> integration.
>
> This Emacs mode is being written by Glenn Thompson.
>
> Thank you!
>
> [1]: https://codeberg.org/glenneth/discourse-mode
>
> From c0bba4133a061eadbde67eae4e060da269171146 Mon Sep 17 
> 00:00:00 2001
> Message-Id: 
> <c0bba4133a061eadbde67eae4e060da269171146.1737353815.git.yuval.langer <at> gmail.com>
> From: Yuval Langer <yuval.langer <at> gmail.com>
> Date: Mon, 20 Jan 2025 08:15:51 +0200
> Subject: [PATCH] gnu: Add emacs-discourse-mode.
>
> * gnu/packages/emacs-xyz.scm (emacs-discourse-mode): New 
> variable.
> ---
>  gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm 
> b/gnu/packages/emacs-xyz.scm
> index 36cad3a7df..6c69df71f4 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -1564,6 +1564,31 @@ do manually if you wanted to keep the 
> buffers of a project neatly isolated in
>  separate, named tab groups.")
>        (license license:gpl3+))))
>  
> +(define-public emacs-discourse-mode
> +  (let ((commit "c5fde79990ab5d44786721f133b1c66764d6dc2b")
> +        (revision "1"))
> +    (package
> +      (name "emacs-discourse-mode")
> +      (version (git-version "0.2.4" revision commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url 
> "https://codeberg.org/glenneth/discourse-mode")
> +               (commit commit)))

Please use the tagged version (v0.2.4) instead of its commit and 
eliminate the `let' form.

> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32 
> "0j2f0vclj6zrmk1hxyrrhkcpk74vqvq42g9wjqrjw827yjh2wm65"))))
> +      (build-system emacs-build-system)
> +      (propagated-inputs (list emacs-compat
> +                               emacs-markdown-mode
> +                               emacs-request))
> +      (home-page 
> "https://codeberg.org/glenneth/discourse-mode")
> +      (synopsis "Emacs package for interacting with Discourse 
> forums")
> +      (description "Browse categories, view topics, read posts, 
> and
> +participate in discussions directly from Emacs.")

This should probably mention Discourse, ex:

   Browse categories, view topics, read posts, and participate in
   discussions on Discourse, directly from Emacs.

Would you please send a v2 patch, using `git send-email'?  Your 
patch was sent as an attachment, which doesn’t work with the Guix 
tooling.

Thanks,

 -- Ian

Message #11 received at 75683 <at> debbugs.gnu.org (full text, mbox):

From: Yuval Langer <yuval.langer <at> gmail.com>
To: 75683 <at> debbugs.gnu.org
Cc: Yuval Langer <yuval.langer <at> gmail.com>
Subject: [PATCH] gnu: Add emacs-discourse-mode.
Date: Sun, 16 Feb 2025 11:53:52 +0200

* gnu/packages/emacs-xyz.scm (emacs-discourse-mode): New variable.
---
 gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 36cad3a7df..d4b868a89e 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1564,6 +1564,31 @@ do manually if you wanted to keep the buffers of a project neatly isolated in
 separate, named tab groups.")
       (license license:gpl3+))))
 
+(define-public emacs-discourse-mode
+  (let ((commit "c5fde79990ab5d44786721f133b1c66764d6dc2b")
+        (revision "1"))
+    (package
+      (name "emacs-discourse-mode")
+      (version (git-version "0.2.4" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://codeberg.org/glenneth/discourse-mode")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0j2f0vclj6zrmk1hxyrrhkcpk74vqvq42g9wjqrjw827yjh2wm65"))))
+      (build-system emacs-build-system)
+      (propagated-inputs (list emacs-compat
+                               emacs-markdown-mode
+                               emacs-request))
+      (home-page "https://codeberg.org/glenneth/discourse-mode")
+      (synopsis "Emacs package for interacting with Discourse forums")
+      (description "Browse categories, view topics, read posts, and
+participate in discussions on Discourse, directly from Emacs.")
+      (license license:gpl3+))))
+
 (define-public emacs-disproject
   (package
     (name "emacs-disproject")
-- 
2.30.2

Message #14 received at 75683 <at> debbugs.gnu.org (full text, mbox):

From: Ian Eure <ian <at> retrospec.tv>
To: Yuval Langer <yuval.langer <at> gmail.com>
Cc: 75683 <at> debbugs.gnu.org
Subject: Re: [bug#75683] [PATCH] gnu: Add emacs-discourse-mode.
Date: Mon, 17 Feb 2025 10:01:35 -0800

Hi Yuval,

Yuval Langer <yuval.langer <at> gmail.com> writes:

> * gnu/packages/emacs-xyz.scm (emacs-discourse-mode): New 
> variable.
> ---
>  gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm 
> b/gnu/packages/emacs-xyz.scm
> index 36cad3a7df..d4b868a89e 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -1564,6 +1564,31 @@ do manually if you wanted to keep the 
> buffers of a project neatly isolated in
>  separate, named tab groups.")
>        (license license:gpl3+))))
>  
> +(define-public emacs-discourse-mode
> +  (let ((commit "c5fde79990ab5d44786721f133b1c66764d6dc2b")
> +        (revision "1"))

Please remove this let form and use the release tag (instead of 
its commit hash), and send a v2 patch.

Thanks,

 -- Ian

Message #17 received at 75683 <at> debbugs.gnu.org (full text, mbox):

From: Yuval Langer <yuval.langer <at> gmail.com>
To: 75683 <at> debbugs.gnu.org
Cc: Yuval Langer <yuval.langer <at> gmail.com>
Subject: [PATCH] gnu: Add emacs-discourse-mode.
Date: Tue, 18 Feb 2025 12:34:41 +0200

* gnu/packages/emacs-xyz.scm (emacs-discourse-mode): New variable.
---
 gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 36cad3a7df..5f34cf6355 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1564,6 +1564,29 @@ do manually if you wanted to keep the buffers of a project neatly isolated in
 separate, named tab groups.")
       (license license:gpl3+))))
 
+(define-public emacs-discourse-mode
+  (package
+    (name "emacs-discourse-mode")
+    (version "0.2.4")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://codeberg.org/glenneth/discourse-mode")
+             (commit "v0.2.4")))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0j2f0vclj6zrmk1hxyrrhkcpk74vqvq42g9wjqrjw827yjh2wm65"))))
+    (build-system emacs-build-system)
+    (propagated-inputs (list emacs-compat
+                             emacs-markdown-mode
+                             emacs-request))
+    (home-page "https://codeberg.org/glenneth/discourse-mode")
+    (synopsis "Emacs package for interacting with Discourse forums")
+    (description "Browse categories, view topics, read posts, and
+participate in discussions on Discourse, directly from Emacs.")
+    (license license:gpl3+)))
+
 (define-public emacs-disproject
   (package
     (name "emacs-disproject")
-- 
2.30.2

Message #20 received at 75683 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Yuval Langer <yuval.langer <at> gmail.com>
Cc: 75683 <at> debbugs.gnu.org
Subject: Re: [bug#75683] [PATCH] gnu: Add emacs-discourse-mode.
Date: Tue, 18 Feb 2025 18:42:03 +0100

Hello,

Yuval Langer <yuval.langer <at> gmail.com> writes:

> * gnu/packages/emacs-xyz.scm (emacs-discourse-mode): New variable.

Thank you.

> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://codeberg.org/glenneth/discourse-mode")
> +             (commit "v0.2.4")))

Please use (string-append "v" version) here.

> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "0j2f0vclj6zrmk1hxyrrhkcpk74vqvq42g9wjqrjw827yjh2wm65"))))
> +    (build-system emacs-build-system)
> +    (propagated-inputs (list emacs-compat
> +                             emacs-markdown-mode
> +                             emacs-request))
> +    (home-page "https://codeberg.org/glenneth/discourse-mode")
> +    (synopsis "Emacs package for interacting with Discourse forums")
> +    (description "Browse categories, view topics, read posts, and
> +participate in discussions on Discourse, directly from Emacs.")

Description is expected to contain "complete" sentences. Here,
I suggest, unimaginatively:

  This package lets you browse…

There are some tests in the repo. Could you try running them during
build? Or maybe they require internet access. I didn’t check.

Regards,
-- 
Nicolas Goaziou

Message #23 received at 75683 <at> debbugs.gnu.org (full text, mbox):

From: Yuval Langer <yuval.langer <at> gmail.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 75683 <at> debbugs.gnu.org
Subject: Re: [bug#75683] [PATCH] gnu: Add emacs-discourse-mode.
Date: Wed, 19 Feb 2025 13:39:56 +0200

On Tue, Feb 18, 2025 at 7:42 PM Nicolas Goaziou <mail <at> nicolasgoaziou.fr> wrote:
>
> Hello,
>
> Yuval Langer <yuval.langer <at> gmail.com> writes:
>
> > * gnu/packages/emacs-xyz.scm (emacs-discourse-mode): New variable.
>
> Thank you.
>
> > +     (origin
> > +       (method git-fetch)
> > +       (uri (git-reference
> > +             (url "https://codeberg.org/glenneth/discourse-mode")
> > +             (commit "v0.2.4")))
>
> Please use (string-append "v" version) here.

Done. (pending submission)

> > +       (file-name (git-file-name name version))
> > +       (sha256
> > +        (base32 "0j2f0vclj6zrmk1hxyrrhkcpk74vqvq42g9wjqrjw827yjh2wm65"))))
> > +    (build-system emacs-build-system)
> > +    (propagated-inputs (list emacs-compat
> > +                             emacs-markdown-mode
> > +                             emacs-request))
> > +    (home-page "https://codeberg.org/glenneth/discourse-mode")
> > +    (synopsis "Emacs package for interacting with Discourse forums")
> > +    (description "Browse categories, view topics, read posts, and
> > +participate in discussions on Discourse, directly from Emacs.")
>
> Description is expected to contain "complete" sentences. Here,
> I suggest, unimaginatively:
>
>   This package lets you browse…

Done.

> There are some tests in the repo. Could you try running them during
> build? Or maybe they require internet access. I didn’t check.

There are no up-to-date tests I can run.  The author said he will
update them in a future version.

I will now submit my latest version of the package definition.

> Regards,
> --
> Nicolas Goaziou

Thank you,
Yuval Langer.

Message #26 received at 75683 <at> debbugs.gnu.org (full text, mbox):

From: Yuval Langer <yuval.langer <at> gmail.com>
To: 75683 <at> debbugs.gnu.org
Cc: Yuval Langer <yuval.langer <at> gmail.com>
Subject: [PATCH] gnu: Add emacs-discourse-mode.
Date: Wed, 19 Feb 2025 13:43:08 +0200

* gnu/packages/emacs-xyz.scm (emacs-discourse-mode): New variable.
---
 gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 36cad3a7df..6bd7ff9d86 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1564,6 +1564,29 @@ do manually if you wanted to keep the buffers of a project neatly isolated in
 separate, named tab groups.")
       (license license:gpl3+))))
 
+(define-public emacs-discourse-mode
+  (package
+    (name "emacs-discourse-mode")
+    (version "0.2.4")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://codeberg.org/glenneth/discourse-mode")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0j2f0vclj6zrmk1hxyrrhkcpk74vqvq42g9wjqrjw827yjh2wm65"))))
+    (build-system emacs-build-system)
+    (propagated-inputs (list emacs-compat
+                             emacs-markdown-mode
+                             emacs-request))
+    (home-page "https://codeberg.org/glenneth/discourse-mode")
+    (synopsis "Emacs package for interacting with Discourse forums")
+    (description "This package lets you browse categories, view topics, read
+posts, and participate in discussions on Discourse, directly from Emacs.")
+    (license license:gpl3+)))
+
 (define-public emacs-disproject
   (package
     (name "emacs-disproject")
-- 
2.30.2

Message #29 received at 75683 <at> debbugs.gnu.org (full text, mbox):

From: Ian Eure <ian <at> retrospec.tv>
To: Yuval Langer <yuval.langer <at> gmail.com>
Cc: 75683 <at> debbugs.gnu.org
Subject: Re: [bug#75683] [PATCH] gnu: Add emacs-discourse-mode.
Date: Sat, 01 Mar 2025 10:04:08 -0800

Hi Yuval,

Pushed as dfc0ac7b1d.

Thanks,
 -- Ian

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.