GNU bug report logs - #75659
[PATCH 1/1] gnu: mpv: Add support for pipewire.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 75659 in the body.
You can then email your comments to 75659 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: soeren <at> soeren-tempel.net
To: guix-patches <at> gnu.org
Subject: [PATCH 1/1] gnu: mpv: Add support for pipewire.
Date: Sat, 18 Jan 2025 23:37:56 +0100

From: Sören Tempel <soeren <at> soeren-tempel.net>

* gnu/packages/video.scm (mpv): Add pipewire audio output support.
[propagated-inputs]: Add pipewire dependency.
---
 gnu/packages/video.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index b113bcd254..b6754153f4 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -2737,6 +2737,7 @@ (define-public mpv
            ;; XXX: lua > 5.2 is not currently supported; see meson.build
            lua-5.2
            mesa
+           pipewire
            pulseaudio
            shaderc
            wayland

Message #10 received at 75659-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: soeren <at> soeren-tempel.net
Cc: me <at> tobias.gr, gabriel <at> erlikon.ch, zhengjunjie <at> iscas.ac.cn,
 75659-done <at> debbugs.gnu.org
Subject: Re: [bug#75659] [PATCH 1/1] gnu: mpv: Add support for pipewire.
Date: Sun, 19 Jan 2025 21:39:53 -0500

On Sat, Jan 18, 2025 at 11:37:56PM +0100, soeren <at> soeren-tempel.net wrote:
> From: Sören Tempel <soeren <at> soeren-tempel.net>
> 
> * gnu/packages/video.scm (mpv): Add pipewire audio output support.
> [propagated-inputs]: Add pipewire dependency.

Thanks! Pushed as c247697a61aece2bca8f95d05bac84084c763775

Message #13 received at 75659 <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Wicki <gabriel <at> erlikon.ch>
To: 75659 <at> debbugs.gnu.org, soeren <at> soeren-tempel.net, leo <at> famulari.name
Subject: Pipewire for MPV support
Date: Mon, 20 Jan 2025 12:51:48 +0100

Hi you two!

Was this patch actually necessary?  I run mpv with pipewire regularly
and never run into issues (IIUC mpv connects to pipewire through
pipewire's pulseaudio interface).  Does this patch really solve anything
or just expand the number of inputs?

Thanks for your work nevertheless and thank you for an explication,

gabber

Message #16 received at 75659 <at> debbugs.gnu.org (full text, mbox):

From: Sören Tempel <soeren <at> soeren-tempel.net>
To: Gabriel Wicki <gabriel <at> erlikon.ch>
Cc: 75659 <at> debbugs.gnu.org, leo <at> famulari.name, soeren <at> soeren-tempel.net
Subject: Re: Pipewire for MPV support
Date: Mon, 20 Jan 2025 17:04:01 +0100

Hi,

I use pipewire without the pulseaudio emulation layer (which is a
supported configuration in Guix), in this setup mpv (without my patch)
doesn't work with pipewire. Other Linux distributions, e.g. Alpine
Linux, also build mpv with pipewire support.

Greetings
Sören

Gabriel Wicki <gabriel <at> erlikon.ch> wrote:
> Hi you two!
> 
> Was this patch actually necessary?  I run mpv with pipewire regularly
> and never run into issues (IIUC mpv connects to pipewire through
> pipewire's pulseaudio interface).  Does this patch really solve anything
> or just expand the number of inputs?
> 
> Thanks for your work nevertheless and thank you for an explication,
> 
> gabber

Message #19 received at 75659 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Sören Tempel <soeren <at> soeren-tempel.net>
Cc: Gabriel Wicki <gabriel <at> erlikon.ch>, 75659 <at> debbugs.gnu.org
Subject: Re: Pipewire for MPV support
Date: Mon, 20 Jan 2025 14:48:09 -0500

On Mon, Jan 20, 2025 at 05:04:01PM +0100, Sören Tempel wrote:
> I use pipewire without the pulseaudio emulation layer (which is a
> supported configuration in Guix), in this setup mpv (without my patch)
> doesn't work with pipewire. Other Linux distributions, e.g. Alpine
> Linux, also build mpv with pipewire support.

Thanks for the explanation, Sören!

I pushed this without any particular knowledge about the subject of
pipewire and mpv --- I've never even used pipewire. But I figure it was
safe since mpv still worked. If it causes some problem, please let us
know.

Message #22 received at 75659 <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Wicki <gabriel <at> erlikon.ch>
To: Leo Famulari <leo <at> famulari.name>
Cc: 75659 <at> debbugs.gnu.org,
 Sören Tempel <soeren <at> soeren-tempel.net>
Subject: Re: Pipewire for MPV support
Date: Wed, 05 Feb 2025 22:59:38 +0100

On Mon, Jan 20, 2025 at 05:04:01PM +0100, Sören Tempel wrote:
> I use pipewire without the pulseaudio emulation layer (which is a
> supported configuration in Guix), in this setup mpv (without my patch)
> doesn't work with pipewire. Other Linux distributions, e.g. Alpine
> Linux, also build mpv with pipewire support.
Interesting!  I must have missed the introduction of
home-pipewire-service-type, which I guess you're referring to here.

In general - and that's why I interjected in the first place - we try to
keep inputs of packages as minimalist as possible.  Without a (short)
statement of the necessity of adding one or a full-fledged bug report it
is hard for a reviewer to know why it is happening - especially for
someone like myself who is using pipewire and mpv on a regular basis
(without issues).

So, thanks for clarifying and the patch itself and the hint towards the
new home-service that I have now installed (and can finally drop
pipewire-pulse)!

Have a nice week!
g

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.