GNU bug report logs - #75641
[PATCH] gnu: Add woof-doom.

Previous Next

Full log

Message #17 received at 75641 <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> envs.net>
To: Andrew Wong <wongandj <at> icloud.com>
Cc: 75641 <at> debbugs.gnu.org, Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Adam Faiz <adam.faiz <at> disroot.org>
Subject: Re: [bug#75641] [PATCH v2] gnu: Add woof-doom.
Date: Sun, 02 Feb 2025 13:30:28 +0800

Andrew Wong <wongandj <at> icloud.com> writes:

> +(define-public woof-doom
> +  (package
> +    (name "woof-doom")
> +    (version "15.2.0")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/fabiangreffrath/woof")
> +             (commit (string-append "woof_" version))))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "04c7hm4jnr9aiz6w4520zww6b7j86qv9xaf87hdv48cjc9sp2ljk"))))
> +    (build-system cmake-build-system)
> +    (arguments
> +     (list
> +      #:tests? #f))

I see it has a 'demotest' directory, does it suit for our builder?
If not, could add a comment, eg: "no tests".

> +    (native-inputs (list python))
> +    (inputs (list sdl2
> +                  sdl2-net
> +                  openal
> +                  libsndfile
> +                  libebur128
> +                  yyjson
> +                  fluidsynth
> +                  libxmp))

In addition to yyjson, it have spng, minz bundled, would be good to
unboudle them. Eg: modify its CMakeLists.txt so that it only use bundled
sources when unable to find a system one, like what yyjson currently
does.  Then we can delete them in third-party via a 'snippet' in source.

Would you like to give a try?  Otherwise looks good to me, thank you!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.