GNU bug report logs - #75636
GTK memory leaks

Previous Next

Full log

Message #31 received at 75636-done <at> debbugs.gnu.org (full text, mbox):

From: Pip Cet <pipcet <at> protonmail.com>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 75636-done <at> debbugs.gnu.org
Subject: Re: bug#75636: GTK memory leaks
Date: Sat, 01 Feb 2025 23:31:19 +0000

Pip Cet <pipcet <at> protonmail.com> writes:

> "Po Lu" <luangruo <at> yahoo.com> writes:
>
>>> commit 5ed4aaa986dbf75f8565f4d8cdd3d1d1b38b6142 (HEAD)
>>> Author: Pip Cet <pipcet <at> protonmail.com>
>>>
>>>     Destroy GTK tool bar widget if it was never attached (bug#75636)
>>>
>>>     * src/gtkutil.c (xg_free_frame_widgets): Call gtk_widget_destroy on an
>>>     unpacked toolbar widget.
>>>
>>> diff --git a/src/gtkutil.c b/src/gtkutil.c
>>> index 0e9dd4dfe11..97582a524da 100644
>>> --- a/src/gtkutil.c
>>> +++ b/src/gtkutil.c
>>> @@ -1885,6 +1885,12 @@ xg_free_frame_widgets (struct frame *f)
>>>        if (tbinfo)
>>>          xfree (tbinfo);
>>>
>>> +      if (x->toolbar_widget && !x->toolbar_is_packed)
>>> +	{
>>> +	  gtk_widget_destroy (x->toolbar_widget);
>>> +	  x->toolbar_widget = NULL;
>>> +	}
>>> +
>>>        /* x_free_frame_resources should have taken care of it */
>>>  #ifndef HAVE_PGTK
>>>  #ifdef HAVE_XDBE
>>
>> LGTM.
>
> Thanks, pushed.

While GTK remains very slow due to MPS limitations and the way we work
around them, I'll file a new bug when we have a way around that, and
closing this one.  Thanks!

Pip

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.