GNU bug report logs - #75626
31.0.50; Dired misses or double-processes files when auto-revert-mode is enabled

Previous Next

Full log

Message #80 received at 75626 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Tassilo Horn <tsdh <at> gnu.org>
Cc: michael_heerdegen <at> web.de, 75626 <at> debbugs.gnu.org
Subject: Re: bug#75626: 31.0.50; Dired misses or double-processes files when
 auto-revert-mode is enabled
Date: Mon, 20 Jan 2025 15:07:17 +0200

> From: Tassilo Horn <tsdh <at> gnu.org>
> Cc: Eli Zaretskii <eliz <at> gnu.org>,   75626 <at> debbugs.gnu.org
> Date: Mon, 20 Jan 2025 07:06:20 +0100
> 
> diff --git a/lisp/dired.el b/lisp/dired.el
> index 2087a6f6f21..c78a13800e6 100644
> --- a/lisp/dired.el
> +++ b/lisp/dired.el
> @@ -1289,6 +1289,12 @@ dired-buffer-stale-p
>          ;; Do not auto-revert when the dired buffer can be currently
>          ;; written by the user as in `wdired-mode'.
>          buffer-read-only
> +         ;; When a dired operation using dired-map-over-marks is in
> +         ;; progress, inhibit-read-only is bound to some non-nil value
> +         ;; and we must not auto-revert because that could change the
> +         ;; order of files leading to skipping or double-processing (see
> +         ;; bug#75626).
> +         (not inhibit-read-only)
>          (dired-directory-changed-p dirname))))
>  
>  (defcustom dired-auto-revert-buffer nil
> --8<---------------cut here---------------end--------------->8---
> 
> Eli, good to go?

I answered that in my other message a few minutes ago.  I think we
should find a cleaner solution.

> And if so, master or emacs-30?

master, of course.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.